| Message ID | 20240319113213.19083-1-radu.sabau@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt-bindings: hwmon: pmbus: adp1050 : add bindings | expand |
On 19/03/2024 12:32, Radu Sabau wrote: > Add dt-bindings for adp1050 digital controller for isolated power supply > with pmbus interface voltage, current and temperature monitor. > > Signed-off-by: Radu Sabau <radu.sabau@analog.com> This is a friendly reminder during the review process. Nothing changed, absolutely nothing. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski > <krzysztof.kozlowski@linaro. > org> > Sent: Tuesday, March 19, > 2024 2:15 PM > To: Sabau, Radu bogdan > <Radu.Sabau@analog.com>; > Jean Delvare > <jdelvare@suse.com>; > Guenter Roeck <linux@roeck- > us.net>; Rob Herring > <robh@kernel.org>; > Krzysztof Kozlowski > <krzysztof.kozlowski+dt@lina > ro.org>; Conor Dooley > <conor+dt@kernel.org>; > Jonathan Corbet > <corbet@lwn.net>; Delphine > CC Chiu > <Delphine_CC_Chiu@Wiwyn > n.com>; linux- > hwmon@vger.kernel.org; > devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; > linux-doc@vger.kernel.org; > linux-i2c@vger.kernel.org > Subject: Re: [PATCH v2 1/2] > dt-bindings: hwmon: pmbus: > adp1050 : add bindings > > [External] > > On 19/03/2024 12:32, Radu > Sabau wrote: > > Add dt-bindings for > adp1050 digital controller for > isolated power supply > > with pmbus interface > voltage, current and > temperature monitor. > > > > Signed-off-by: Radu Sabau > <radu.sabau@analog.com> > > This is a friendly reminder > during the review process. > > Nothing changed, absolutely > nothing. > > It seems my or other > reviewer's previous > comments were not fully > addressed. Maybe the > feedback got lost between > the quotes, maybe you > just forgot to apply it. Please > go back to the previous > discussion and > either implement all > requested changes or keep > discussing them. > > Thank you. Indeed I forgot to address few comments regarding dt-bindings and I am very sorry for that, will make sure to address them in the next patch. > > Best regards, > Krzysztof
On Tue, 19 Mar 2024 13:32:02 +0200, Radu Sabau wrote: > Add dt-bindings for adp1050 digital controller for isolated power supply > with pmbus interface voltage, current and temperature monitor. > > Signed-off-by: Radu Sabau <radu.sabau@analog.com> > --- > .../bindings/hwmon/pmbus/adi,adp1050.yaml | 52 +++++++++++++++++++ > MAINTAINERS | 7 +++ > 2 files changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/requests/models.py", line 971, in json return complexjson.loads(self.text, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/json/__init__.py", line 346, in loads return _default_decoder.decode(s) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/json/decoder.py", line 337, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 912, in resolve_from_url document = self.resolve_remote(url) ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 1015, in resolve_remote result = requests.get(uri).json() ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/requests/models.py", line 975, in json raise RequestsJSONDecodeError(e.msg, e.doc, e.pos) requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/bin/dt-doc-validate", line 8, in <module> sys.exit(main()) ^^^^^^ File "/usr/local/lib/python3.11/dist-packages/dtschema/doc_validate.py", line 66, in main ret |= check_doc(f) ^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/dtschema/doc_validate.py", line 29, in check_doc for error in sorted(dtsch.iter_errors(), key=lambda e: e.linecol): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/dtschema/schema.py", line 120, in iter_errors meta_schema = self.resolver.resolve_from_url(self['$schema']) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 914, in resolve_from_url raise exceptions.RefResolutionError(exc) jsonschema.exceptions.RefResolutionError: Expecting value: line 1 column 1 (char 0) Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dts:26.17-30: Warning (reg_format): /example-0/i2c/adp1050@70:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 0) Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dts:18.13-29.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dts:22.24-28.15: Warning (avoid_default_addr_size): /example-0/i2c/adp1050@70: Relying on default #address-cells value Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: i2c: '#address-cells' is a dependency of '#size-cells' from schema $id: http://devicetree.org/schemas/reg.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: adp1050@70: '#adress-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: https://devicetree.org/schemas/hwmon/pmbus/adi,adp1050.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.example.dtb: adp1050@70: '#address-cells' is a dependency of '#size-cells' from schema $id: http://devicetree.org/schemas/reg.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240319113213.19083-1-radu.sabau@analog.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 19/03/2024 13:47, Sabau, Radu bogdan wrote: >> >> Thank you. > > Indeed I forgot to address few comments regarding dt-bindings > and I am very sorry for that, will make sure to address them > in the next patch. Please also confirm, e.g. paste results, of binding testing. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml new file mode 100644 index 000000000000..1a94b715c1f9 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: https://devicetree.org/schemas/hwmon/pmbus/adi,adp1050.yaml# +$schema: https://devicetree.org/meta-schemes/core.yaml# + +title: Analog Devices ADP1050 digital controller with PMBus interface + +maintainers: + - Radu Sabau <radu.sabau@analog.com> + +description: | + The ADP1050 is used to monitor system voltages, currents and temperatures. + Through the PMBus interface, the ADP1050 targets isolated power supplies + and has four individual monitors for input/output voltage, input current + and temperature. + Datasheet: + https://www.analog.com/en/products/adp1050.html + +properties: + compatible: + const: adi,adp1050 + + reg: + maxItems: 1 + + vcc-supply: true + +required: + - compatible + - reg + - vcc-supply + +additionalProperties: false + +examples: + - | + i2c { + #adress-cells = <1>; + #size-cells = <0>; + clock-frequency = <100000>; + adp1050@70 { + #adress-cells = <1>; + #size-cells = <0>; + compatible = "adi,adp1050"; + reg = <0x70>; + vcc-supply = <&vcc>; + }; + }; +... + diff --git a/MAINTAINERS b/MAINTAINERS index 1339918df52a..90b8e64e1f6a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -479,6 +479,13 @@ L: linux-wireless@vger.kernel.org S: Orphan F: drivers/net/wireless/admtek/adm8211.* +ADP1050 HARDWARE MONITOR DRIVER +M: Radu Sabau <radu.sabau@analog.com> +L: linux-hwmon@vger.kernel.org +S: Supported +W: https://ez.analog.com/linux-software-drivers +F: Dcumentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml + ADP1653 FLASH CONTROLLER DRIVER M: Sakari Ailus <sakari.ailus@iki.fi> L: linux-media@vger.kernel.org
Add dt-bindings for adp1050 digital controller for isolated power supply with pmbus interface voltage, current and temperature monitor. Signed-off-by: Radu Sabau <radu.sabau@analog.com> --- .../bindings/hwmon/pmbus/adi,adp1050.yaml | 52 +++++++++++++++++++ MAINTAINERS | 7 +++ 2 files changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml