| Message ID | 20240911122518.41393-2-wenliang202407@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [linux,dev-6.11,1/2] hwmon: modified ina2xx to match SY24655(SQ52205) | expand |
On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: > Modified the binding of ina2xx to make it compatible with SY24655. Rather, you should explain why the sy24655 is compatible with the ina2xx devices. > > Signed-off-by: Wenliang <wenliang202407@163.com> > --- > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > index 6ae961732e6b..400e7cefad17 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > @@ -29,6 +29,7 @@ properties: > - ti,ina237 > - ti,ina238 > - ti,ina260 > + - silergy,sy24655 Please add this in alphabetical order. Thanks, Conor. > > reg: > maxItems: 1 > -- > 2.17.1 >
On 11/09/2024 19:49, Conor Dooley wrote: > On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: >> Modified the binding of ina2xx to make it compatible with SY24655. > > Rather, you should explain why the sy24655 is compatible with the ina2xx > devices. > >> This looks like patch for some forked tree, like the BMC folks are doing. At least linux dev suggests it. Best regards, Krzysztof
Hey, On Tue, Oct 08, 2024 at 07:58:51PM +0800, wenliang yan wrote: > Modified the binding of ina2xx to make it compatible with SY24655. > > > > > Signed-off-by: Wenliang <wenliang202407@163.com> > > --- > > > > > SY24655 is a fixed gain power monitor from Silergy, with a power supply > > of 2.7-5.5V and communication mode of IIC capable of detecting bus voltage > > and voltage on shunt resistors. Its first 5 registers are identical to > > ina226, and also have alert and limit functions. So, the sy24655 is > > compatible with the ina2xx devices. This should be above the signoff and --- line. Your patch is pretty badly malformed, did you use b4 or git send-email to submit it? Cheers, Conor. > > > > > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > index 6ae961732e6b..05a9cb36cd82 100644 > > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > > @@ -20,6 +20,7 @@ description: | > > properties: > > compatible: > > enum: > > + - silergy,sy24655 > > - ti,ina209 > > - ti,ina219 > > - ti,ina220 > > -- > > 2.17.1 > >
On Tue, Oct 08, 2024 at 02:35:38PM +0200, Krzysztof Kozlowski wrote: > On 11/09/2024 19:49, Conor Dooley wrote: > > On Wed, Sep 11, 2024 at 08:25:18AM -0400, Wenliang wrote: > >> Modified the binding of ina2xx to make it compatible with SY24655. > > > > Rather, you should explain why the sy24655 is compatible with the ina2xx > > devices. > > > >> > > This looks like patch for some forked tree, like the BMC folks are > doing. At least linux dev suggests it. CC list wouldn't imply that it is.
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index 6ae961732e6b..400e7cefad17 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -29,6 +29,7 @@ properties: - ti,ina237 - ti,ina238 - ti,ina260 + - silergy,sy24655 reg: maxItems: 1
Modified the binding of ina2xx to make it compatible with SY24655. Signed-off-by: Wenliang <wenliang202407@163.com> --- Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + 1 file changed, 1 insertion(+)