| Message ID | 20240920-pmbus-wp-v1-2-d679ef31c483@baylibre.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | hwmon: (pmbus/core) support write protected pmbus regulators | expand |
On Fri, Sep 20, 2024 at 06:47:03PM +0200, Jerome Brunet wrote: > The machine specific regulator_init() appears to be unused. > It does not allow a lot of interactiona with the regulator framework, > since nothing from the framework is passed along (desc, config, > etc ...) > > Machine specific init may also be done with the added init_cb() in > the regulator description, so remove regulator_init(). This makes sense regardless of what happens with the rest of the series.
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 4c90ab5ad876..4666b0e226c2 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -5764,13 +5764,6 @@ regulator_register(struct device *dev, resolved_early = true; } - /* perform any regulator specific init */ - if (init_data && init_data->regulator_init) { - ret = init_data->regulator_init(rdev->reg_data); - if (ret < 0) - goto wash; - } - if (config->ena_gpiod) { ret = regulator_ena_gpio_request(rdev, config); if (ret != 0) { diff --git a/include/linux/regulator/machine.h b/include/linux/regulator/machine.h index 0cd76d264727..d0d700ff337a 100644 --- a/include/linux/regulator/machine.h +++ b/include/linux/regulator/machine.h @@ -285,8 +285,7 @@ struct regulator_init_data { int num_consumer_supplies; struct regulator_consumer_supply *consumer_supplies; - /* optional regulator machine specific init */ - int (*regulator_init)(void *driver_data); + /* optional regulator machine specific data */ void *driver_data; /* core does not touch this */ };
The machine specific regulator_init() appears to be unused. It does not allow a lot of interactiona with the regulator framework, since nothing from the framework is passed along (desc, config, etc ...) Machine specific init may also be done with the added init_cb() in the regulator description, so remove regulator_init(). Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- drivers/regulator/core.c | 7 ------- include/linux/regulator/machine.h | 3 +-- 2 files changed, 1 insertion(+), 9 deletions(-)