| Message ID | 20241024083055.82047-2-wenliang202407@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3,1/2] hwmon: modified ina2xx to match SY24655 | expand |
On Thu, Oct 24, 2024 at 04:30:55AM -0400, Wenliang wrote: > Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers. > > Because it is similar to INA226, the supply voltage and pin definitions > are the same. It also supports IIC communication, with only two > additional registers added for configuring and calculating average power. > > Signed-off-by: Wenliang <wenliang202407@163.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> The series has been send in response to an invalid message id: https://lore.kernel.org/all/20241024083055.82047-2-wenliang202407@163.com/ Don't send new versions as replies to earlier versions, that tends to get things lost in people's mailboxes. Cheers, Conor.
On Thu, Oct 24, 2024 at 05:32:19PM +0100, Conor Dooley wrote: > On Thu, Oct 24, 2024 at 04:30:55AM -0400, Wenliang wrote: > > Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers. > > > > Because it is similar to INA226, the supply voltage and pin definitions > > are the same. It also supports IIC communication, with only two > > additional registers added for configuring and calculating average power. > > > > Signed-off-by: Wenliang <wenliang202407@163.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Actually, I take that back. You can add it if you send the patch to the dt mailing list so it can be tested. Thanks, Conor.
On 10/24/24 01:30, Wenliang wrote: > Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers. > > Because it is similar to INA226, the supply voltage and pin definitions > are the same. It also supports IIC communication, with only two > additional registers added for configuring and calculating average power. > Again, please consult Documentation/process/submitting-patches.rst for both description and subject. "dt-bindings: Add SY24655 to ina2xx devicetree bindings" or similar would be a much better subject, and something like "SY24655 is similar to INA226. Its supply voltage and pin definitions are therefore the same. Compared to INA226, SY24655 has two additional registers for configuring and calculating average power." would be a much better patch description. Also, as already requested by Conor, please copy the devicetree mailing list on devicetree patches to enable automated testing. Thanks, Guenter > Signed-off-by: Wenliang <wenliang202407@163.com> > --- > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > index 6ae961732e6b..05a9cb36cd82 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > @@ -20,6 +20,7 @@ description: | > properties: > compatible: > enum: > + - silergy,sy24655 > - ti,ina209 > - ti,ina219 > - ti,ina220
On 24/10/2024 10:30, Wenliang wrote: > Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers. > > Because it is similar to INA226, the supply voltage and pin definitions > are the same. It also supports IIC communication, with only two > additional registers added for configuring and calculating average power. > > Signed-off-by: Wenliang <wenliang202407@163.com> <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index 6ae961732e6b..05a9cb36cd82 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -20,6 +20,7 @@ description: | properties: compatible: enum: + - silergy,sy24655 - ti,ina209 - ti,ina219 - ti,ina220
Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers. Because it is similar to INA226, the supply voltage and pin definitions are the same. It also supports IIC communication, with only two additional registers added for configuring and calculating average power. Signed-off-by: Wenliang <wenliang202407@163.com> --- Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 + 1 file changed, 1 insertion(+)