| Message ID | 20241103163908.11890-2-wenliang202407@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [linux,dev-6.11,v3,1/2] hwmon: (ina226) Add support for SY24655 | expand |
On 03/11/2024 17:39, Wenliang wrote: > From: book <book@100ask.localdomain> > > SY24655 is similar to INA226. Its supply voltage and pin definitions > are therefore the same. Compared to INA226, SY24655 has two additional > registers for configuring and calculating average power. > > Signed-off-by: book <book@100ask.localdomain> > Acked-by: Conor Dooley <conor.dooley@microchip.com> NAK, this never happened. If you think otherwise: provide proof, please. Nothing improved in this binding, actually it got even worse with fake email and probably name as well. Best regards, Krzysztof
On 03/11/2024 17:46, Krzysztof Kozlowski wrote: > On 03/11/2024 17:39, Wenliang wrote: >> From: book <book@100ask.localdomain> >> >> SY24655 is similar to INA226. Its supply voltage and pin definitions >> are therefore the same. Compared to INA226, SY24655 has two additional >> registers for configuring and calculating average power. >> >> Signed-off-by: book <book@100ask.localdomain> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > NAK, this never happened. If you think otherwise: provide proof, please. Hm, now I found previous v3, so ack happened, but patch still has incorrect author. Please really carefully read submitting patches document, especially parts about sending new versions, changelogs, subjects. > > Nothing improved in this binding, actually it got even worse with fake > email and probably name as well. Best regards, Krzysztof
On Sun, Nov 03, 2024 at 05:52:59PM +0100, Krzysztof Kozlowski wrote: > On 03/11/2024 17:46, Krzysztof Kozlowski wrote: > > On 03/11/2024 17:39, Wenliang wrote: > >> From: book <book@100ask.localdomain> > >> > >> SY24655 is similar to INA226. Its supply voltage and pin definitions > >> are therefore the same. Compared to INA226, SY24655 has two additional > >> registers for configuring and calculating average power. > >> > >> Signed-off-by: book <book@100ask.localdomain> > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > NAK, this never happened. If you think otherwise: provide proof, please. > > Hm, now I found previous v3, so ack happened, but patch still has > incorrect author. I didn't ack it with this weird authorship, so that needs to be fixed before the ack can be applied. > > Please really carefully read submitting patches document, especially > parts about sending new versions, changelogs, subjects. > > > > > > Nothing improved in this binding, actually it got even worse with fake > > email and probably name as well. > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml index 6ae961732e6b..05a9cb36cd82 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml @@ -20,6 +20,7 @@ description: | properties: compatible: enum: + - silergy,sy24655 - ti,ina209 - ti,ina219 - ti,ina220