From patchwork Mon Jun 17 08:14:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amy.Shih@advantech.com.tw X-Patchwork-Id: 10998303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD3FC112C for ; Mon, 17 Jun 2019 08:14:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A095A28717 for ; Mon, 17 Jun 2019 08:14:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 94F8328807; Mon, 17 Jun 2019 08:14:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E00C28717 for ; Mon, 17 Jun 2019 08:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbfFQIO6 (ORCPT ); Mon, 17 Jun 2019 04:14:58 -0400 Received: from aclms3.advantech.com.tw ([125.252.70.86]:39405 "EHLO ACLMS3.advantech.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfFQIO6 (ORCPT ); Mon, 17 Jun 2019 04:14:58 -0400 Received: from taipei08.ADVANTECH.CORP (unverified [172.20.0.235]) by ACLMS3.advantech.com.tw (Clearswift SMTPRS 5.6.0) with ESMTP id ; Mon, 17 Jun 2019 16:14:56 +0800 From: To: CC: , , , Jean Delvare , Guenter Roeck , , Subject: [v2 6/9] hwmon: (nct7904) Fix wrong return code in function nct7904_write_fan. Date: Mon, 17 Jun 2019 08:14:35 +0000 Message-ID: <70e520dfcf80c58045d2238a0af972d9cdbb6ac4.1560756733.git.amy.shih@advantech.com.tw> X-Mailer: git-send-email 2.17.1 In-Reply-To: <928e46508bbe1ebc0763c3d2403a5aebe95af552.1560756733.git.amy.shih@advantech.com.tw> References: <928e46508bbe1ebc0763c3d2403a5aebe95af552.1560756733.git.amy.shih@advantech.com.tw> MIME-Version: 1.0 X-Originating-IP: [172.17.10.58] X-ClientProxiedBy: ACLDAG.ADVANTECH.CORP (172.20.2.88) To taipei08.ADVANTECH.CORP (172.20.0.235) X-StopIT: No Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "amy.shih" In function nct7904_write_fan, the return code is either 0 or an error code. 0x1fff is not a valid return code. Thus, set return code to 0 when setting value is smaller or equal to 0. Signed-off-by: amy.shih --- Changes in v2: - Fix wrong return code 0x1fff in function nct7904_write_fan. drivers/hwmon/nct7904.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c index 95348eebe8e4..3fa3eb31d176 100644 --- a/drivers/hwmon/nct7904.c +++ b/drivers/hwmon/nct7904.c @@ -551,7 +551,7 @@ static int nct7904_write_fan(struct device *dev, u32 attr, int channel, switch (attr) { case hwmon_fan_min: if (val <= 0) - return 0x1fff; + return 0; val = clamp_val((1350000 + (val >> 1)) / val, 1, 0x1fff); tmp = (val >> 5) & 0xff;