| Message ID | 858d8af3ae9d15b62e36dc3deb50275f9c9869b0.1729622189.git.grantpeltier93@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: hwmon: pmbus: add bindings for isl68137 | expand |
On Tue, 22 Oct 2024 14:25:39 -0500, Grant Peltier wrote: > Add devicetree bindings to support declaring optional voltage dividers to > the rail outputs of supported digital multiphase regulators. Some > applications require Vout to exceed the voltage range that the Vsense pin > can detect. This binding definition allows users to define the > characteristics of a voltage divider placed between Vout and the Vsense > pin for any rail powered by the device. > > Signed-off-by: Grant Peltier <grantpeltier93@gmail.com> > --- > .../hwmon/pmbus/renesas,isl68137.yaml | 133 ++++++++++++++++++ > 1 file changed, 133 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml: properties:compatible:enum: ['renesas,isl68137', 'renesas,isl68137', 'renesas,isl68220', 'renesas,isl68221', 'renesas,isl68222', 'renesas,isl68223', 'renesas,isl68224', 'renesas,isl68225', 'renesas,isl68226', 'renesas,isl68227', 'renesas,isl68229', 'renesas,isl68233', 'renesas,isl68239', 'renesas,isl69222', 'renesas,isl69223', 'renesas,isl69224', 'renesas,isl69225', 'renesas,isl69227', 'renesas,isl69228', 'renesas,isl69234', 'renesas,isl69236', 'renesas,isl69239', 'renesas,isl69242', 'renesas,isl69243', 'renesas,isl69247', 'renesas,isl69248', 'renesas,isl69254', 'renesas,isl69255', 'renesas,isl69256', 'renesas,isl69259', 'renesas,isl69260', 'renesas,isl69268', 'renesas,isl69269', 'renesas,isl69298', 'renesas,raa228000', 'renesas,raa228004', 'renesas,raa228006', 'renesas,raa228228', 'renesas,raa229001', 'renesas,raa229004'] has non-unique elements hint: "enum" must be an array of either integers or strings from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml: $id: 'http://devicetree.org/schemas/hwmon/pmbus/renesas,isl68137.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#' from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml: ^channel@([0-3])$: Missing additionalProperties/unevaluatedProperties constraint doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/858d8af3ae9d15b62e36dc3deb50275f9c9869b0.1729622189.git.grantpeltier93@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Oct 22, 2024 at 02:25:39PM -0500, Grant Peltier wrote: > Add devicetree bindings to support declaring optional voltage dividers to > the rail outputs of supported digital multiphase regulators. Some > applications require Vout to exceed the voltage range that the Vsense pin > can detect. This binding definition allows users to define the > characteristics of a voltage divider placed between Vout and the Vsense > pin for any rail powered by the device. > > Signed-off-by: Grant Peltier <grantpeltier93@gmail.com> > --- > .../hwmon/pmbus/renesas,isl68137.yaml | 133 ++++++++++++++++++ > 1 file changed, 133 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml > new file mode 100644 > index 000000000..12004da53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml > @@ -0,0 +1,133 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/pmbus/renesas,isl68137.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas Digital Multiphase Voltage Regulators with PMBus > + > +maintainers: > + - Grant Peltier <grant.peltier.jg@renesas.com> > + > +description: You need '>' to preserve paragraphs. > + Renesas digital multiphase voltage regulators with PMBus. > + > + https://www.renesas.com/en/products/power-management/multiphase-power/multiphase-dcdc-switching-controllers > + > +properties: > + compatible: > + enum: > + - renesas,isl68137 > + - renesas,isl68137 > + - renesas,isl68220 > + - renesas,isl68221 > + - renesas,isl68222 > + - renesas,isl68223 > + - renesas,isl68224 > + - renesas,isl68225 > + - renesas,isl68226 > + - renesas,isl68227 > + - renesas,isl68229 > + - renesas,isl68233 > + - renesas,isl68239 > + - renesas,isl69222 > + - renesas,isl69223 > + - renesas,isl69224 > + - renesas,isl69225 > + - renesas,isl69227 > + - renesas,isl69228 > + - renesas,isl69234 > + - renesas,isl69236 > + - renesas,isl69239 > + - renesas,isl69242 > + - renesas,isl69243 > + - renesas,isl69247 > + - renesas,isl69248 > + - renesas,isl69254 > + - renesas,isl69255 > + - renesas,isl69256 > + - renesas,isl69259 > + - renesas,isl69260 > + - renesas,isl69268 > + - renesas,isl69269 > + - renesas,isl69298 > + - renesas,raa228000 > + - renesas,raa228004 > + - renesas,raa228006 > + - renesas,raa228228 > + - renesas,raa229001 > + - renesas,raa229004 > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +patternProperties: > + "^channel@([0-3])$": > + type: object > + description: | > + Represents ??? > + > + properties: > + reg: > + description: | Don't need '|' if there's no formatting. > + The channel (rail) index. > + items: > + minimum: 0 > + maximum: 3 > + > + vout-voltage-divider: Needs a vendor prefix. > + description: | > + Resistances of a voltage divider placed between Vout and the voltage > + sense pin for the given channel (rail). It has two numbers > + representing the resistances of the voltage divider provided as > + <R1 R2> which yields an adjusted Vout as > + Vout_adj = Vout * (R1 + R2) / R2 given the original Vout as reported > + by the Vsense pin. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 > + maxItems: 2 > + > + required: > + - reg > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + isl68239@60 { > + compatible = "renesas,isl68239"; > + reg = <0x60>; > + }; > + }; > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + isl68239@60 { > + compatible = "renesas,isl68239"; > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + channel@0 { > + reg = <0>; > + vout-voltage-divider = <1000 1000>; // Reported Vout/Pout would be scaled by 2 > + }; > + }; > + }; > -- > 2.39.5 >
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml new file mode 100644 index 000000000..12004da53 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml @@ -0,0 +1,133 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/renesas,isl68137.yaml +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas Digital Multiphase Voltage Regulators with PMBus + +maintainers: + - Grant Peltier <grant.peltier.jg@renesas.com> + +description: + Renesas digital multiphase voltage regulators with PMBus. + + https://www.renesas.com/en/products/power-management/multiphase-power/multiphase-dcdc-switching-controllers + +properties: + compatible: + enum: + - renesas,isl68137 + - renesas,isl68137 + - renesas,isl68220 + - renesas,isl68221 + - renesas,isl68222 + - renesas,isl68223 + - renesas,isl68224 + - renesas,isl68225 + - renesas,isl68226 + - renesas,isl68227 + - renesas,isl68229 + - renesas,isl68233 + - renesas,isl68239 + - renesas,isl69222 + - renesas,isl69223 + - renesas,isl69224 + - renesas,isl69225 + - renesas,isl69227 + - renesas,isl69228 + - renesas,isl69234 + - renesas,isl69236 + - renesas,isl69239 + - renesas,isl69242 + - renesas,isl69243 + - renesas,isl69247 + - renesas,isl69248 + - renesas,isl69254 + - renesas,isl69255 + - renesas,isl69256 + - renesas,isl69259 + - renesas,isl69260 + - renesas,isl69268 + - renesas,isl69269 + - renesas,isl69298 + - renesas,raa228000 + - renesas,raa228004 + - renesas,raa228006 + - renesas,raa228228 + - renesas,raa229001 + - renesas,raa229004 + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +patternProperties: + "^channel@([0-3])$": + type: object + description: | + Represents + + properties: + reg: + description: | + The channel (rail) index. + items: + minimum: 0 + maximum: 3 + + vout-voltage-divider: + description: | + Resistances of a voltage divider placed between Vout and the voltage + sense pin for the given channel (rail). It has two numbers + representing the resistances of the voltage divider provided as + <R1 R2> which yields an adjusted Vout as + Vout_adj = Vout * (R1 + R2) / R2 given the original Vout as reported + by the Vsense pin. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 2 + + required: + - reg + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + isl68239@60 { + compatible = "renesas,isl68239"; + reg = <0x60>; + }; + }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + isl68239@60 { + compatible = "renesas,isl68239"; + reg = <0x60>; + #address-cells = <1>; + #size-cells = <0>; + + channel@0 { + reg = <0>; + vout-voltage-divider = <1000 1000>; // Reported Vout/Pout would be scaled by 2 + }; + }; + };
Add devicetree bindings to support declaring optional voltage dividers to the rail outputs of supported digital multiphase regulators. Some applications require Vout to exceed the voltage range that the Vsense pin can detect. This binding definition allows users to define the characteristics of a voltage divider placed between Vout and the Vsense pin for any rail powered by the device. Signed-off-by: Grant Peltier <grantpeltier93@gmail.com> --- .../hwmon/pmbus/renesas,isl68137.yaml | 133 ++++++++++++++++++ 1 file changed, 133 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/renesas,isl68137.yaml