From patchwork Thu Feb 20 10:18:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Schumacher X-Patchwork-Id: 13983652 Received: from FR5P281CU006.outbound.protection.outlook.com (mail-germanywestcentralazon11022090.outbound.protection.outlook.com [40.107.149.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0BDF1EDA17; Thu, 20 Feb 2025 10:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.149.90 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740046703; cv=fail; b=Lgg6pqsBqPF5S1x4K0+kKNgM8RyeCC7GwrowJJLQA/vvfFnqTlnRYZ7hjzYaP8mOaO455niW4nnXlVttCDBOYykg7S2qbfR7tFcJUCBSZD5E2JyxoGgnCVrOdwxJFG0w7a9y2/nofF1g/c6ruJ07xTs4WjaRISrpkeeyCvNpxVA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740046703; c=relaxed/simple; bh=kJy06ltDgpL34pAwZWM1V+WMRgo/7mPFLxa4GMngmEk=; h=From:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=bhKl7eTpl538qFBp1nLwcqG0OgecmbmBSrJgBspe5kf9E9gmTVj+J61OMaUKjIqE0bemLP5YIs1NefOfc8PuEjrgJ+a/4goF/bsr/dq3G3rwOZHHoUVn/Q6m9NoWNLzGnbjUcn0SBF4CqXulT5xdKBOLZqAxpwStSrRiNaeM7ik= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iris-sensing.com; spf=pass smtp.mailfrom=iris-sensing.com; dkim=pass (2048-bit key) header.d=iris-sensing.com header.i=@iris-sensing.com header.b=USHeHIG+; arc=fail smtp.client-ip=40.107.149.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iris-sensing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iris-sensing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iris-sensing.com header.i=@iris-sensing.com header.b="USHeHIG+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PcnyXiRF+xU8q0ozMPVe/bVgAgfXzDgHR+golayMXTB4/VpFmSPoviaePeeVyEUb1SWUfEexpAsJL2FPGmY/lRKh55Kn/YkTzSJYWtJGKZYks8f9mgkaLb4d3OUE+QTtVRyRkwbdkbIDjZFvJc9lkdkyRkJzTCGUDA4NghwKi6scGB2DOqoRnbteJPhxozK457jhcbKmtdAghLZrYHc4O34AIqmjuCOVgGZfMMM0c3xlg8uXafJ9TCubvewRbY+KqnbQU55PI9vm5ILHUCHz+h5/XXAZ0htv8jMRh6XJksogr6TI8+xQN3o1/0XS7KjPhm4BUBPgsi9Z8GjeY0CjFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kJy06ltDgpL34pAwZWM1V+WMRgo/7mPFLxa4GMngmEk=; b=x4AmK8ariWi6ZQ0MIL11YOUYpvqG37FSBqXxxosC3zowXXyUkbYZOfHnacIdDyRITsRYSnL+xhspZaCstISN9PkplGYumt3mSCk5u1ZCBsf8zRnwfAJqIQHRS8kGyIMSDN8zkD+/E4YPOPjxKOww40IrxwXvVy+mQvDezrOJzKyiTNhmAwvtNc2Ufueolc+jG+YrUEldXLz9fyzS8VFWrydeEqtR3yMd8YsWdc4tPc0OqqPtlBcMb2qlQIVjZPn7iWoBySnX6+d0hz6M3Ara9nbmfQXPbGZoHPYBiQ1LICw0+7TSLGkMR1YGn335f/ClDa/fo7nhQi+kY9ovh8LU7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=iris-sensing.com; dmarc=pass action=none header.from=iris-sensing.com; dkim=pass header.d=iris-sensing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iris-sensing.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kJy06ltDgpL34pAwZWM1V+WMRgo/7mPFLxa4GMngmEk=; b=USHeHIG+qJiXLWjVLhDjci7fsQJMYj38dTtyYx6JkU8CKHiCR0b2eB5j2fuZK1xHptIHk4L5WQ2K5wksbq3fPt8RSHQDDLTk+4L6MVLNQqePG8inGwCYOZhnJW2zdwy59j1KyFYkA9+YuRezi5uWCp4+6+nE/qEMrUnFE3PKjxg85eX63CIJuVcBk6PLA6u5d6TJ8ZsluH8PUIMdDhTwkKEuyclSp2vZYX+8tQYPHYTsW02V2zeypeNUjgrZn3kjt+9ddu9BVlE2yiklNXkybVXcZiyq3flEY8h5OAI+4dFwBLl/HD/7pZnaLns9IWjkaJOCRMvI9Wbl5rYV8jG1HA== Received: from FR0P281MB2809.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:23::8) by FR0P281MB2047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:29::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Thu, 20 Feb 2025 10:18:17 +0000 Received: from FR0P281MB2809.DEUP281.PROD.OUTLOOK.COM ([fe80::d685:f312:e114:519e]) by FR0P281MB2809.DEUP281.PROD.OUTLOOK.COM ([fe80::d685:f312:e114:519e%3]) with mapi id 15.20.8466.015; Thu, 20 Feb 2025 10:18:17 +0000 From: Erik Schumacher CC: "linux@roeck-us.net" , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jdelvare@suse.com" Subject: [PATCH] hwmon: (ad7314) Validate leading zero bit and return error Thread-Topic: [PATCH] hwmon: (ad7314) Validate leading zero bit and return error Thread-Index: AQHbg4DCZYgTN21mOU+h0PycRP5rAw== Date: Thu, 20 Feb 2025 10:18:17 +0000 Message-ID: Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iris-sensing.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: FR0P281MB2809:EE_|FR0P281MB2047:EE_ x-ms-office365-filtering-correlation-id: 4eceffe9-e758-4c10-af51-08dd5197e4c1 x-ms-exchange-atpmessageproperties: SA x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?Q8e6r0weRKDUkrNUU4XOQvqn+B73D0A?= =?utf-8?q?wamjJD+lJWYt7/B2zZpWykYgP0DmCJCiAWqFUIw5PiR0IDdBtmD9HJKuGhzsRYPQJ?= =?utf-8?q?wLlyi5vP+8WgS045OvJnwgi15P8K65FBRMS4b8rHQIRazo64CIleqx1xbM4aO/JBW?= =?utf-8?q?nZzsoo8GD7RovQteEm4mT6TA3NkSYd7zOOnN4WbKGgdZ4IFoZlMH7p1m8AjX87PNn?= =?utf-8?q?zhaza/s+1i2hbU+wAucjHUxnVqIN+IKNTkUw8UAlEYWPnjOszQeXC06lRhzYbWl90?= =?utf-8?q?xfQ5tC6xQH1/Z0BKDYEeBCzL8v3cx6fezwXogXxEOISHMu09cerZr6eiQ7nS+r/MD?= =?utf-8?q?0JwdH5YiIDs/4h1kScyu/jZtsKjWJTQ3ZDD0KwBtYQNniglhvV5e04pgNDEkqYSXy?= =?utf-8?q?uP+X02QsX30GbC4f94Zzs42GjynB3PwI62oL8tz72PNr8t1+TpAub/qqcNWMP6Exr?= =?utf-8?q?TY4CVZD/MqbeNoeZRqmgxa63RJZW2PbEK5y+MxBID6lFJIoiidIbvMyJSr2/YfRSw?= =?utf-8?q?daBanA0FCQjFjR8wjZ44iSOMsCW85ur5dGw46yY8yTIp4BGqDBzyLjhXhfstB+0hU?= =?utf-8?q?3fTfyePXJXfruijkUZraZY3IGg/HyoRfBpEvYXm1nQZDn5or3fpbMKRSInfXZX3+Y?= =?utf-8?q?x2K2dO0PTKxaB7GSJ1GnzSFNIfQce70qcDIUeb79ivxW+Mi6/gUh6WrJYfgnaJ+r+?= =?utf-8?q?6vAIeeocKXM8ALUCtGz21bvdQUMDvKBDRgOPNhHZlPYsES9lUkX546rAoj0Gl7XCg?= =?utf-8?q?Ld24ef82S8JxzoXi175yiC7gJOMbKIB4frQhhYlk17UFFPp9ZfDtEJGayB8wRktE+?= =?utf-8?q?OBLoAqyQnwHmjmgvbfjelJqruydDzcN31keFSdqkMlj8zTFbHYkGrbQIw04OvUIiG?= =?utf-8?q?FqE3uJCwo2ftabVFZjgvQfil5blM06TdPfQuGKBr2Hm8NKIo6psz2yp118vsWkKbg?= =?utf-8?q?vTZ7XOdBqtiSX0nYBM6mV2BY80mkeySP5phlYAllgO9jXhFHrh3nOt7lK4A0ak/ll?= =?utf-8?q?CUT+RpWaoRVu+HR+zY5j7xQgBMK94EldF5wjCuYJAWBQ9HzsjMNYQ3oFqsOakdq1W?= =?utf-8?q?ChU6/r3ShKbRbpoDmAIFcvBDksVSYvnxYwATXbrnXXFrjmgvZ5TZbkcnXQfq+3dXo?= =?utf-8?q?AMmBXmaALgNwhn2OSV6gloHduMFTsrNN7MXGgf0GBEqACHrPZaN4EBtd+aUihhbFb?= =?utf-8?q?VRItwut5KnmwSw8niV6wrgqZnBMHWP54UfAvKBaWkl2TjHHYKUt6DCbobXnf+RsYc?= =?utf-8?q?XgDn5EDw5RkdqOEm1Jz/OLADwsmj1PMY82CVqxMrRRkUvmnINyB/8ONE2456daKuP?= =?utf-8?q?hFSdyKlYfgnTw5AxYTPqZMKgycY6pG2UNuMIgJIQPc4qRrcBtUjnf8c=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:FR0P281MB2809.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?t+KIux8Ilo84NbacOJbgKnFTqh7H?= =?utf-8?q?oPE/m3pJk3rTy4iZRgx6ArCQZzx4BE6DQ1IPzzFrO2E0J5XwNLDvgNBs94K99yA07?= =?utf-8?q?6zxqYLb7k5boywv90cZ8N2IW1uIFvG6C2ImETDwR0+IIUMimPFhZbYrCY2kD4Cqzo?= =?utf-8?q?8lBjnfTlWulYArgrNnWJAUY7DRAO8O2zHk6pJPD9vQm2N6AnU117kw90VpKI6lXLR?= =?utf-8?q?rdhbrWWNaXJi9BCl3EV1Vwo34qbOPNSGY3v93mBozA6B/BAvVV5TwJd7N+vivtJi5?= =?utf-8?q?ReZQfdiE1QqwEoZEbE4NNyH4M2SqdRDgvYIlOVvK4gndb4bFIsrlO1e9vxvKVOwIB?= =?utf-8?q?nYw+7hzm1rekkczRNqxpZ3ex1z/JwmAEevbQ9PvEGHSNKtdwB1kAocmi31UT/bUlN?= =?utf-8?q?ME7Qum5IFMLwk9ORM0ftBMLGdlG4EfIIeURyzpoICatvtRdYIJlEoHav4olx753cy?= =?utf-8?q?i5N1/N5X3rXOt3uiH505Phxj3xKaZ2nPjctXUi/1aAOl6uCZ2uNjTtFTZ3I0EYV9e?= =?utf-8?q?wNAckP0+RWwf6AHXY8ch+Q7XKZ30u5Ir2F3Ic/cja3QntEOHyTDvzYewOw5pYC5TI?= =?utf-8?q?QC/UGiDTR5zyt0OtxrGcGP3Vnk6+uAx+677EeFv7EyRfPiVKiLGBSi+kI8ToxNHRS?= =?utf-8?q?Rj+xPjiesRsR4nGVu+pFIe+8u+J8aSruoMvX4EG0lMkmfED4pQRRK6vwPEH/unMt/?= =?utf-8?q?r0MHHXgYBvn+K00HYZbpbvovsXHl/few9TwPGCQIqEzLS1HXKq9OInnS6LuFWRKFj?= =?utf-8?q?09U78v7xSrJh2ZQGJIv2To+ICcFexwGGkT7uO5Rny07OPdirNSc8CtnAFDt+dqpyj?= =?utf-8?q?2Aip/q+L8F3ld2xXMGiE/Dk5T4uhli4oSAvZed16CrWDs2I5l7/SZg8uK+Z5boUHG?= =?utf-8?q?GN+ZP2li1nsZEbB9Mi89X78mdvRxNgtItfWsoTtRwqMiM+sVQ+87+FOuOqsFf7BbQ?= =?utf-8?q?VnfvLj9hKoVI8FarCbpYkkz0zx9Ai9NXXBxFcRiGpGLVsJN9jugZ+IkbYWLJ56IXr?= =?utf-8?q?nYRkpKjSZUYqOd/ObrajcQ8blYGeybIZ0eZcX0BHkgOQ4PramnziIyhD0NFjnsBpX?= =?utf-8?q?MiUrlm+q87CoXWNas7nOACTpVd9ZLWFGOphOXaf3a0c61jPyQJRcon2XEPfgXhDuj?= =?utf-8?q?o6DzRylH9sVrqqDKiAMd382dgUoe97PsPpRKP6R4s2whjf203aTp5+nTXXzzD5YNR?= =?utf-8?q?/8oneOdDcD1s/qYqgVjzJc7wQ6qr2wffcZCJVy4kAXIfmvDV1U9y8eeyrNmfVfT7q?= =?utf-8?q?zrzLKBG11YqASP3D2iF2Q138kE6o+KBUhDOvZse4vDuMi03b7m6ScGSoYGprZm2m6?= =?utf-8?q?x5BQe7dcolYlkeNUug8RDLNEav63g16pjQkdD5BQWkBjz/i23eP0QMh3ddw84SQrg?= =?utf-8?q?kDpznga1MWgRYD3w6oxunuZpGCaqJky19TDjev9anuN1wUD5Z2F7XSjKeDCkTLxLZ?= =?utf-8?q?dMdy3ha+yWnMuSQnZsUJXXyePzI46cRz+S7x/bjB+NGl1EFN/pYRLokSotT5gEdxJ?= =?utf-8?q?VC9KB9qdY5AlZaqeOOkhnRedlfWk9loYlNqIjOtNaYFRFAs6pbwMhcQ=3D?= Content-ID: <24D7CCA1DB3E894AA79A7E9173164538@DEUP281.PROD.OUTLOOK.COM> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: iris-sensing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: FR0P281MB2809.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 4eceffe9-e758-4c10-af51-08dd5197e4c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2025 10:18:17.6103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 963f3913-ffae-43fd-856b-2dfd3f6604e3 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XBeWspnq7gNx7ojyYJ3fXOKTXluyeZX8xuZlvFmELwzQySONjgOD38A/KE2rywoqhh3BXZh3ymyERDZ0sQ2A5kaTy5wBmMPEsrR//QDmmf/Zx09TsAbuqsVRSb8WJ0m5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR0P281MB2047 A leading zero bit is sent on the bus before the temperature value is transmitted. If this bit is high, the connection might be unstable or it could mean that no AD7314 (or compatible) is connected on the bus. Return -ENXIO in that case. Signed-off-by: Erik Schumacher --- drivers/hwmon/ad7314.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c index 7802bbf5f958..025846f1f18b 100644 --- a/drivers/hwmon/ad7314.c +++ b/drivers/hwmon/ad7314.c @@ -65,6 +65,10 @@ static ssize_t ad7314_temperature_show(struct device *dev, return ret; switch (spi_get_device_id(chip->spi_dev)->driver_data) { case ad7314: + if (ret & BIT(15)) { + /* Invalid read-out, leading zero bit is missing */ + return -ENXIO; + } data = (ret & AD7314_TEMP_MASK) >> AD7314_TEMP_SHIFT; data = sign_extend32(data, 9);