mbox series

[v5,resend,0/6] i3c: master: some improvment for i3c master

Message ID 20231201222532.2431484-1-Frank.Li@nxp.com (mailing list archive)
Headers show
Series i3c: master: some improvment for i3c master | expand

Message

Frank Li Dec. 1, 2023, 10:25 p.m. UTC 
There are three major improvement

1. Add actual size in i3c_transfer because i3c allow target early termiate
transfer.
2. Add API for i3c_dev_gettstatus_format1 for i3c comand GET_STATUS.
3. svc master support hotjoin

Change log see each patches

Frank Li (6):
  i3c: master: add enable(disable) hot join in sys entry
  i3c: master: svc: add hot join support
  i3c: add actual_len in i3c_priv_xfer
  i3c: master: svc: rename read_len as actual_len
  i3c: master: svc: return actual transfer data len
  i3c: add API i3c_dev_gettstatus_format1() to get target device status

 drivers/i3c/device.c                |  24 ++++++
 drivers/i3c/internals.h             |   1 +
 drivers/i3c/master.c                | 109 ++++++++++++++++++++++++++++
 drivers/i3c/master/svc-i3c-master.c |  95 +++++++++++++++++++-----
 include/linux/i3c/device.h          |   3 +
 include/linux/i3c/master.h          |   5 ++
 6 files changed, 220 insertions(+), 17 deletions(-)

Comments

Frank Li Dec. 19, 2023, 4:29 p.m. UTC | #1 
On Fri, Dec 01, 2023 at 05:25:26PM -0500, Frank Li wrote:
> There are three major improvement
> 
> 1. Add actual size in i3c_transfer because i3c allow target early termiate
> transfer.
> 2. Add API for i3c_dev_gettstatus_format1 for i3c comand GET_STATUS.
> 3. svc master support hotjoin

Friendly ping. Any addtional comment about these patches?

Frank LI

> 
> Change log see each patches
> 
> Frank Li (6):
>   i3c: master: add enable(disable) hot join in sys entry
>   i3c: master: svc: add hot join support
>   i3c: add actual_len in i3c_priv_xfer
>   i3c: master: svc: rename read_len as actual_len
>   i3c: master: svc: return actual transfer data len
>   i3c: add API i3c_dev_gettstatus_format1() to get target device status
> 
>  drivers/i3c/device.c                |  24 ++++++
>  drivers/i3c/internals.h             |   1 +
>  drivers/i3c/master.c                | 109 ++++++++++++++++++++++++++++
>  drivers/i3c/master/svc-i3c-master.c |  95 +++++++++++++++++++-----
>  include/linux/i3c/device.h          |   3 +
>  include/linux/i3c/master.h          |   5 ++
>  6 files changed, 220 insertions(+), 17 deletions(-)
> 
> -- 
> 2.34.1
>
Alexandre Belloni Jan. 8, 2024, 12:03 a.m. UTC | #2 
On Fri, 01 Dec 2023 17:25:26 -0500, Frank Li wrote:
> There are three major improvement
> 
> 1. Add actual size in i3c_transfer because i3c allow target early termiate
> transfer.
> 2. Add API for i3c_dev_gettstatus_format1 for i3c comand GET_STATUS.
> 3. svc master support hotjoin
> 
> [...]

Applied, thanks!

[1/6] i3c: master: add enable(disable) hot join in sys entry
      commit: 317bacf960a4879af22d12175f47d284930b3273
[2/6] i3c: master: svc: add hot join support
      commit: 05b26c31a4859af9e75b7de77458e99358364fe1
[3/6] i3c: add actual_len in i3c_priv_xfer
      commit: e5e3df06ac98d15cfb10bb5c12356709365e91b2
[4/6] i3c: master: svc: rename read_len as actual_len
      commit: 6fb61734a74eaa307a5b6a0bee770e736d8acf89
[5/6] i3c: master: svc: return actual transfer data len
      commit: 6d1a19d34e2cc07ca9cdad8892da94e716e9d15f

Best regards,
Frank Li Jan. 9, 2024, 1:19 a.m. UTC | #3 
On Mon, Jan 08, 2024 at 01:03:50AM +0100, Alexandre Belloni wrote:
> 
> On Fri, 01 Dec 2023 17:25:26 -0500, Frank Li wrote:
> > There are three major improvement
> > 
> > 1. Add actual size in i3c_transfer because i3c allow target early termiate
> > transfer.
> > 2. Add API for i3c_dev_gettstatus_format1 for i3c comand GET_STATUS.
> > 3. svc master support hotjoin
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/6] i3c: master: add enable(disable) hot join in sys entry
>       commit: 317bacf960a4879af22d12175f47d284930b3273
> [2/6] i3c: master: svc: add hot join support
>       commit: 05b26c31a4859af9e75b7de77458e99358364fe1
> [3/6] i3c: add actual_len in i3c_priv_xfer
>       commit: e5e3df06ac98d15cfb10bb5c12356709365e91b2
> [4/6] i3c: master: svc: rename read_len as actual_len
>       commit: 6fb61734a74eaa307a5b6a0bee770e736d8acf89
> [5/6] i3c: master: svc: return actual transfer data len
>       commit: 6d1a19d34e2cc07ca9cdad8892da94e716e9d15f

Why not pckup 6/6: 
 i3c: add API i3c_dev_gettstatus_format1() to get target device status

Frank

> 
> Best regards,
> 
> -- 
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Alexandre Belloni Jan. 9, 2024, 7:35 a.m. UTC | #4 
On 08/01/2024 20:19:43-0500, Frank Li wrote:
> On Mon, Jan 08, 2024 at 01:03:50AM +0100, Alexandre Belloni wrote:
> > 
> > On Fri, 01 Dec 2023 17:25:26 -0500, Frank Li wrote:
> > > There are three major improvement
> > > 
> > > 1. Add actual size in i3c_transfer because i3c allow target early termiate
> > > transfer.
> > > 2. Add API for i3c_dev_gettstatus_format1 for i3c comand GET_STATUS.
> > > 3. svc master support hotjoin
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/6] i3c: master: add enable(disable) hot join in sys entry
> >       commit: 317bacf960a4879af22d12175f47d284930b3273
> > [2/6] i3c: master: svc: add hot join support
> >       commit: 05b26c31a4859af9e75b7de77458e99358364fe1
> > [3/6] i3c: add actual_len in i3c_priv_xfer
> >       commit: e5e3df06ac98d15cfb10bb5c12356709365e91b2
> > [4/6] i3c: master: svc: rename read_len as actual_len
> >       commit: 6fb61734a74eaa307a5b6a0bee770e736d8acf89
> > [5/6] i3c: master: svc: return actual transfer data len
> >       commit: 6d1a19d34e2cc07ca9cdad8892da94e716e9d15f
> 
> Why not pckup 6/6: 
>  i3c: add API i3c_dev_gettstatus_format1() to get target device status
> 

As it was discussed, it doesn't have any users.

> Frank
> 
> > 
> > Best regards,
> > 
> > -- 
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com