From patchwork Mon Oct 23 16:16:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13433178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34E3DC25B43 for ; Mon, 23 Oct 2023 16:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FawPtVxrp7/sz8LaCqrMp4+yHJFSm4PY7/whP0F7fMQ=; b=SIm76J5qGCVQ3R eIhDWBZM3co6kico2lvNUMXFwM1ZlxlLdSU+EhX6FsHyuo3qIZP7tlr4T6hOUWzn/kA9c5bKho4Gi pZ4QO8bPrpFCeP1zuSkPt+mO2t2REq1+ryj997DImRem/JUQs1prpLzxsaK65am1/8IQdpXEKpmMt 8zytJfSw/e+MCUa40kWx3udLOR2209EPhXnzQLgfkQ6x2tAgUXEGMQ3+xm301by0/fvue07WhiL4t IsaPmYHeLQ61HIAdqzaw8iJ/CuNzP5JyiFcE752UsWrHabv5/9H9/TQF2aHQ5IslcN5jSGLQmxhxR 86YD8mOpw2e+cyRF6QHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quxcU-007o6g-2r; Mon, 23 Oct 2023 16:17:34 +0000 Received: from mail-he1eur04on062f.outbound.protection.outlook.com ([2a01:111:f400:fe0d::62f] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quxcR-007nyM-1o for linux-i3c@lists.infradead.org; Mon, 23 Oct 2023 16:17:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRLI6FkfM/TdaI18u///YcnF0M0g1tIz0GvzM0xejITvTwaYIhkh/+mwTEOBeU0gvTiWJQSTt0jnelZEaLCcaZ9Q2VPV4oGKoyhvE4KqVyuh498Jl19lut+7cQyRawOyUR8Wx9Iu+DT50gXy2eIPKOM9kZQfAKWVH0JgrS1hwkBIzNAxQGDY37y/Omc7DnqDf46DyUgEpWXJTKC5dEmjduMBvtc4LaUTk4ILjtJfSge7u/bmUwYN10pb/9dK5/f+mGs/xap3KyIbwitgojhygMpVG+NOOBf+uJZfuAm5E9B5WMKA+aJdchc9L5IHzCC7TaChicD0G2twYbOVEVo3ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nxBwTfviefvCF4FZJghiatpkh63SM3ZApfysbHSxGKY=; b=SNnX29DqPMWWJ9x1Ds5XY/6Y5ps95vOjaahe6vSPe0wGM7Zlmbcql3s5IW8TEgkXJu42Ry+7iAl2uZtUbuVbxF6RAuuYVmmHr6AHZsDEwrPgKsAxQ4rBff0z6i59qZQf0TfhlE8t53ua+RiWURRKEPNY259vuGItGsJrW4/SwfYNX8CwbI3F33hkZfkyXbDTG9IRG5aCXGFK3FY6saxSCkeIecVyrFZHSSk/0JqP2a2meOrANJ2z4anAe2h3Xsnc7OdiEPhLv4B642QxppnLnjT4xOYjbo3v+2XUZ5yjyQojNA6DcyDyJbS2JWmzAGYcc9zhvENs7omtW5s5ZfV7oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nxBwTfviefvCF4FZJghiatpkh63SM3ZApfysbHSxGKY=; b=pbOcV8Av0KqKjZ5l+K+zgQjOsDMsYc4Vq1aB2o3MjVX2avT3yaZCu/SBJiXZIGGWNl/zF8JDHQFr8wHpctq69Yaz7vPQ5ww9INCPjHnMMv/spEugLKLdDpcOLw32T2Rw5VfnFTVCE1ogd2buW5liSZTdMYJ1GucalyYlSvl0w4s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:26 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:26 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Mon, 23 Oct 2023 12:16:58 -0400 Message-Id: <20231023161658.3890811-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: b6aa3968-6fb1-4441-0e8e-08dbd3e38bc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8zCVGeih/1XImRLE1hl3BcOTxLhQr7KRepfcuRX6ha/BJfmXPe6bw94yaVdNh/u58eVxmV4gO2G7rKDVqAMvxFpUKBj3eSgcoLeiEfUb9PHpDPX/IRpktinvigrtFPYRTtV2pNLnJ4DpIJm8jT/75kSVYyNg+G0uBU8SDYSx9pjaufZB3NDDimrQl0UE4sz5bahXtmzhUssUsK2KUuNqV+lgP4qb4EQJikJYuOqWf09CMo4tyEv9/eEZXX9KAlGi9faKO6je22yyUbMUCfQF9huuuliR/C+bvuUqc1xTgJa6t5nr1pGEyn0Qh1/uuNHFl5TnaXVjM5OGgadqH46Z5pxDHB6py35jhv+4QfTiowwJOGp9NCNhZXHWOKlnJO6Vsoyc0mXOH31DtIZeTH+IigJB0UlYdirJuPu+wXcMP6axN5DzHA8CvWfOfqo2X1cCGhCro5XfuQbbckm61zZf/WecHG8cGPPyZAP4CGhnxTOBZYQ5Yhh8xPCGKd7AWBg0ohTxfYUCOS7rD54Rm5yyAwOcxJMu0v0JRjWX5mDNBdRPVj56v1zy2dQWHQFJ6C68dRHx5jQ9tnDAy84qlCJgseWS1pP3jm6bz9/+16q6BoED0Y2vxAD3uBd6YyyuEMJW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PT1brGKV4OG8gqr6IIyZmMI+uNPU?= =?utf-8?q?VHvhy0J0lN1toYdiQCbNblKFGHrFAl/HZRLC5UiqZqGlJ54u6shusthfNVhDVzFI0?= =?utf-8?q?9/tcMLEY9f4GPrrULr2u0hBt5xHEIkQCfGR0B0Iv6Fx/u3lGwbMOm7x+CRQGA82PA?= =?utf-8?q?K3p+rxXwBFZV5ZM7cyifuAkemZNLuY2mPljBr7A6bH5snSY1YyL1EBFkfNI2YPLsX?= =?utf-8?q?l5Q0uKiFVHFGFc56iGG+xJWLaWm8nmeYfdGofxXYWcthmHXlEJWOiIzqmcWAuBY+e?= =?utf-8?q?vaOfeXICNB4VcaxMqQ73/H5ClGHYeSdd3sub3Hbh4BWnQkndIqJsHgtaSPq+G/wdc?= =?utf-8?q?qkfXcz3Vc6d5l1bBSEK8ALMhgzHzPEeO0PUYv1NG7/qXuVbLhwsCtJoAXfI8lwCzO?= =?utf-8?q?KOmsVDhT+medEc9IDAA+svkyNYYMRfYWI5xIx40bbLO+oMPbc8CW5i3L2SYw0QlZ8?= =?utf-8?q?t1GYER07ZoVBnDYae12I+n9FIpL7iS16Yw67u2PO9Ga94yd7oFbU5MwhZGKuoU0Lz?= =?utf-8?q?/ZUgJ9LAWUVbs8yZTIr0sKXJ3C9jHwlDBg8krNbBBCJDh/q0dMRvHo9/t9ltdiQvz?= =?utf-8?q?fo2jKB6UByqvyfTSMAfugNSe5fpq6wqoz23HzACEJn4NOMk6kRo3NI+uvjC1FWJFL?= =?utf-8?q?RwZZK+NqUlU/R0ABJozwTWdqm4U0eo6UfAkNkq6OYw06qfw0Ay7tsl8RBS0ZoVfDo?= =?utf-8?q?Nws567DT+YBRA89alcEhwFd/ZubveqJb8BeiyNQbP/kARFBrd3ksgPp9wavinPL/L?= =?utf-8?q?6pqhiojNqCpdgFZJNTC0nbb2bSRaERYNCBfI7Jxdf0v9Ho70/8y8KHDAxM78c79Gx?= =?utf-8?q?WZ/G2T02/19ZtLlVmPNDOeO3ckZ/Xire1kstm0JSYCN9oTNJ7I1XBAV5e9oIDpZtc?= =?utf-8?q?ACcQ/Xd0CZO96Xpsju5UAPBVXxtfS1jW233wyMzNchBfUnFO8mgiUlLEyBeY4bXgg?= =?utf-8?q?QUn4as3fdZb43s1aSGT+sW7Oim3BegBC0T8hDwaPTfQEz9ZdWk99Rha9ps9I8t+cg?= =?utf-8?q?DkqGs23ABdiuUIJmxQs1sNu4+Mf93a7m9BtRWEaf17YVMSkEIOzMhx4jfzQF9iEEB?= =?utf-8?q?Bh6vF98qiJSV9YAEwqbD+ihAtBVrnox94shgMGrXNJ+DLQZxfMAlzsJNpW+lmV4px?= =?utf-8?q?8Oxer4h/iyRKPW7Qh43tVGHlnLNVP+FG8HdZuP/iuwx+iMCGv4vZp091pwhmSQM+7?= =?utf-8?q?yqdgsX7FwhnB7o50MFZ0IUuqjtQE68zVpSz6tx01pUBqyXMGSrH6HpQqlsprOfKCu?= =?utf-8?q?aWKy2riyVHBeLm3Hk62Ym6DSk91JXM25UVrhKfzzumGZYEiVGLe7IL26wgZpbazDF?= =?utf-8?q?5m+E30ukTeulWkNuSz4pUtx13N8pvbqGV708nrcD+gCRWoN3X7yklRBra9tlVI13m?= =?utf-8?q?pxC6flc/FQL5gunO0H/ZLKhr7/KgqxYUZUW9YK559b+Ou40MdmERwN2Yblieqmd8F?= =?utf-8?q?4tyGm6GxxNlkoWh+imqplF3Pj18x7VQf+bRCr2ac500w2njWaLLaq5F6x5hc2oylm?= =?utf-8?q?xOXC/lq8NzQ7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6aa3968-6fb1-4441-0e8e-08dbd3e38bc9 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:26.0587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fv2aAifx1F2hnB4a9mY7Ky225TgNnfdoQNvWE8DzyfWWSXdNQy2obMMT08ujlHnYmFcBAsyMQlKzPObKwtOM2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_091731_604882_A5C934C3 X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org master side report: silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 BIT 20: TIMEOUT error The module has stalled too long in a frame. This happens when: - The TX FIFO or RX FIFO is not handled and the bus is stuck in the middle of a message, - No STOP was issued and between messages, - IBI manual is used and no decision was made. The maximum stall period is 100 μs. This can be considered as being just a warning as the system IRQ latency can easily be greater than 100us. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- Notes: Change from v3 to v4 - fixed missed update commit message Add dev_dbg for TIMEOUT case This can be considered as being just a warning as the system IRQ latency can easily be greater than 100us. Change from v2 to v3 - remove 10k at commit message Change from v1 to v2 -none Change from v1 to v2 -none Change from v2 to v3 - remove 10k at commit message Change from v1 to v2 -none Change from v1 to v2 -none drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 1a57fdebaa26d..6b6bdd163af4f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -93,6 +93,7 @@ #define SVC_I3C_MINTMASKED 0x098 #define SVC_I3C_MERRWARN 0x09C #define SVC_I3C_MERRWARN_NACK BIT(2) +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) #define SVC_I3C_MDMACTRL 0x0A0 #define SVC_I3C_MDATACTRL 0x0AC #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) @@ -226,6 +227,14 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { merrwarn = readl(master->regs + SVC_I3C_MERRWARN); writel(merrwarn, master->regs + SVC_I3C_MERRWARN); + + /* Ignore timeout error */ + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) { + dev_dbg(master->dev, "Warning condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", + mstatus, merrwarn); + return false; + } + dev_err(master->dev, "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", mstatus, merrwarn);