From patchwork Wed Oct 2 14:50:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13819874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F5F7CF6D2F for ; Wed, 2 Oct 2024 14:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vuCTp7U55UNDEXVP4RXy4YFu00e7GdTmEI0JGrh3Bxs=; b=e5MyxpAFlMlFFLTViQdYEQRf/3 bVLrR6gHVATPJUhs3rKjWhIHZui6Z4JPDQlEAVbu35qYBEwvy0QoKVPJ861zm4h4zYnoMw769A//V kiEZDgFwr+ZLu0SfeKi8hRA0xSc5s3kOuGGSPXM+FtXYW8xLfcnjbI0ojihzCX4mS8P+V6mK0Iwy+ agJHjaxSJjEZsGieCvEMtPi42kFrWKTSqGWRQj37xUzADToZokZnF+6/k3nDoQeGU6TA7nVGAuQiO 8eEA8B56xDDuxWRwoaNU0lriO5Rq7RF3YdgOJtQQwXfXSpPTJh3Sf8tegCQ2qvCmlqmwkJElYd6gp bIKax5vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sw0hq-00000006Swi-3BRo; Wed, 02 Oct 2024 14:51:58 +0000 Received: from mail-am6eur05on20610.outbound.protection.outlook.com ([2a01:111:f403:2612::610] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sw0h2-00000006Sin-1pn4 for linux-i3c@lists.infradead.org; Wed, 02 Oct 2024 14:51:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EXCgQmjw4FqVXa+2pcHmMRHXwJlwNe/owNrJ7VKWnEIJtDc0/NnmTZUPwdIjSzL9qX+fhpmTOVUbbOJA2KGdKbT6qOQufvBovZYr6EGisFcBk6COx9VyXc3x89rC+fHGYwTN1VvsL7d0dVE8aj/dU2/Yvx/0IQimYrlk4NAOdWlBx6Hd/UNxfLXpfUxATddwIooQJ7UPuB87G5wqPoolLosV67g9/qgGLOhx0qZ8ZxxZJW7yBtesijBiRlVOwCAdhQyGqGJE1BY10xpueRbbF9wcUz/8tiJ0bfOXkVTU/TUmZECHlDva1xB1lg+xwKMWqfRFIrihjF4xsh6GITAUzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LWw8O34Z1PaA0bIpNMoMDZht14UG39YKCT4LXoVb5rY=; b=lUGvaUtRRtHlk66NlAWYcun9d9Knf7vaFByYIoh4YVOMVDXHs9LxD1+N9vozXYvJQBcx6QJeqFU0xb0q5BtxliBuR97KWbJuX2XBi5rNCetxKuRsSTS0p9FTUmS8wU5P2dLGiaXMS6E+Le/juQE+y1s38SB8voipZKUTLGGFxXubIXbErgj2R68mjGXG9YGEGm+AyMdi9t3A3AFt4TludHEUKYOCxUq7sXINuk0PhLmtBmDg5PUz2MkIhCchH5rDqv+DYyyJNZuFKEuxgjTCA954+peu+42Ijl9yHc+FcxtZ8bm7GOsJLcs1ZH5uubLhEG6ECYhO62/Ocb1qGihhKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWw8O34Z1PaA0bIpNMoMDZht14UG39YKCT4LXoVb5rY=; b=dfdl3C36PIFZX14Mk4cVwg7Lm1AqK8VELgG+jXqq3Bg0A1eNPyt3ex03n+SKbJ1boWbKAGMu4EAYuQyOHwa2mdrkMf5uD8DcmkkuyYPS1d48Wes+6H4YbFV7hgB5DluKpQFcQEULNEFK+jSdtDnwjjfLszFhUx1Pg6jsKnUoeeQc672x8pvZjYrSt8nnU4Y7IKEB26oz+Wf6+YrjKdVp1KkRat8+w1WrjtBtcUhKbjnka0FgHYEWdL+TiHLwZGgdoXhPYUfEFyfzfrQOtkV2TKg49DLRDYg2xxAFz04D9o5H30ro2TJbG21qc9X73HEvap09nod9fmdw3pFvKzXRSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS1PR04MB9699.eurprd04.prod.outlook.com (2603:10a6:20b:482::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Wed, 2 Oct 2024 14:51:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8005.024; Wed, 2 Oct 2024 14:51:01 +0000 From: Frank Li Date: Wed, 02 Oct 2024 10:50:36 -0400 Subject: [PATCH v6 4/6] i3c: master: svc: use spin_lock_irqsave at svc_i3c_master_ibi_work() Message-Id: <20241002-svc-i3c-hj-v6-4-7e6e1d3569ae@nxp.com> References: <20241002-svc-i3c-hj-v6-0-7e6e1d3569ae@nxp.com> In-Reply-To: <20241002-svc-i3c-hj-v6-0-7e6e1d3569ae@nxp.com> To: Miquel Raynal , Conor Culhane , Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1727880649; l=2752; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=AHvZeWDy6/xYEqoA2DrJdTLBov3b0kSpblBok0ICshQ=; b=E9naYrDh21bcxEeOMa+vTbTy6zWSgauI4eieu801Jp/W05Hufc/Xrb1eTHaMVezNDN0Y1sfVO 2+1cW0Ih0TRAQOvFQxNuVyKgXv+9vzFnxgm8skshKaoPQkELanThnDT X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0177.namprd13.prod.outlook.com (2603:10b6:a03:2c7::32) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS1PR04MB9699:EE_ X-MS-Office365-Filtering-Correlation-Id: 68d26252-9578-4d03-ed30-08dce2f1a1c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?RQvvLL2U+GkpGRL/rWs6LYOxRvM/OvJ?= =?utf-8?q?z8z5CB6ZrKcGYah7s7i4PjDWV+YKxMjNymvFhczXfqTTBaH3RqfdY3xYKT2+3HgNv?= =?utf-8?q?uLbvK6uF/PuTfpHKda56SP0x0q6bZ24Jrd3BWFR1rShvhOr+BnAY9vPueu1edGBiu?= =?utf-8?q?KgGKSezFBOgjCKu70uGOwVUHdA277kSRa1NWwn9bzRHrjTC4lMvX/Ga54EJdfye9p?= =?utf-8?q?65haUC9g17jmWO68sFdGAPoWRRD5CAFpYmghpFXHk94Kbk/bFsubc/rLacO1I83yI?= =?utf-8?q?yF8F8v1yk9CRGP7tlD2zcysEk9HwBDiDngDkfqGieqe266wB1s3MGdtyNJ3dcZoXt?= =?utf-8?q?3C6W7BWR8hDF8Q6orIYVe1FZ+pY0otevTI0H2nxkExCUu/0g3WtG/QFcN5n1F62vW?= =?utf-8?q?kirLLkXExXKbZZVo2S7r2cmTBgOyIrfjoV0hTH2QtebBucYbg7SScSf87f1e8+m22?= =?utf-8?q?KfEbuXlGe5ayPKTOfy2BaMNiv0U9CZieqQVZ5zldFhaDasK9s2LEgGF71pYU7Cgib?= =?utf-8?q?286MfKpBGCc1eLhp++WssWGtzA/so/stuKyb/Dxr2ZpAIMai+Hlug7sbMU+EwIJrM?= =?utf-8?q?Pq828QjPVu/BCUt0+dckOns2deXbaTAt+mMXPk/FE3KEMYSBbaVOvXxvIX0rJGsyu?= =?utf-8?q?txfhGT/49gJGNt9xlrhxVUH1WWHdjLH8LIDeNlr25Y35LEmRmTX7VP3h7WVTOg8hI?= =?utf-8?q?9JtUNZDUcIE+VFP+MUxfWCcsKWpRiNKpZDaSqRH/PZ/ToqR3S2Vtj/68Y2XZ61inA?= =?utf-8?q?p2zP68jFJmnlrjEFterWyM5ciEs3ZctOnhsyTaP/0TvVlnJdLuE9KgiigEBR62z9s?= =?utf-8?q?r4cZSYFBIq7i/IVZsqrn9y0PVbK5oyRgv3KwuTI4h8NnHGhKWq2G7Y4Rw7MqNZPlI?= =?utf-8?q?JtpNin+Z1T0htrc0E3b39IJuONAbQadw3h7XT1kO+qd7aZi++c8QG0tGSr2gjj8vq?= =?utf-8?q?xj2od40g+FZo0pWo/7csKJqhk1hB0oUzFuCERhl9w5kQCvMMEoOzkzUOR5ItX7MiC?= =?utf-8?q?zNpqxS1e9yq5GWbwM+mZUjKiuGFFY1l+5v9oIPk98OR/D2xZHA+Q98Hv3am0+v5Zy?= =?utf-8?q?c11MG3UEHtnWAyiM4GIX3D0onNplbdX11zPqoOkc7CqvkSECTBnGdiIWNdpLK8n++?= =?utf-8?q?H5VxmvivEkgWUx4qulYiYgXu5vO1zKeceqYD1KJMA2dT8pSx1JBWfcQA/0YPzpYVV?= =?utf-8?q?vL8kQhofazQADX8pEgI7BEXsuCnQ6hbUb4rCdPjr8/aloBcvan83+DIIBOXZB5lWp?= =?utf-8?q?Y79xG4iO0c/NMd9j2D2rWIg0uNwxu7mjfxA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4PxHd1VB2F6S97f0m2TIXAju5xPN?= =?utf-8?q?DaK670hlpib4Uu3pZOIQ2mPxQ/cjIxKAZBIzKg/kOudnxcuD5UFbjQPrV9z3JuMNG?= =?utf-8?q?2BduaQ0UEx8tl3fyXiHpHD14n4qqzhCO2c+LyRCVVbIXHxJwNBR9bJGqm0iqcY+nt?= =?utf-8?q?nrx0cWHBJY/0c2KJTc7oMIe0juunn+GGLgjgEvlyY8C4kcMOEyTcWUaz/p5OXksk6?= =?utf-8?q?cOuCP0uoT4OnM0enZLki9Vo4Zj1uOmqt8+512nCU7fw9Py0d6F3nY4OSfwYVAgj70?= =?utf-8?q?tdDzL3z1WuDlGCx7CFGbQxCGKtXHPpNhHbwmrbPdG2P33R16wU8rai+JKgYfhsLmF?= =?utf-8?q?2YpwJ0lNDXlUZNzexYcCaKQhyHFZ/JAUuk1kLP1rCF7M0mjp7kIQ75A3IavA7I64y?= =?utf-8?q?JdkB4kFJnbf/sVP1rb+ciXbKo+Dafp0EwqIdaf3mS7AzBrZJV38qvqWA8O8JJM3mW?= =?utf-8?q?npc1uCjgNQciEtn6m5g659ICdPH1K4sWHnWf9ScUlfx9i7sBZotYGUl/ZXEbK+Oqq?= =?utf-8?q?D/sYZl81ABSOdARtEWnN2raQbDd/QMaphx8tiXGqpPrBsVja20EagagWqoedNH3UB?= =?utf-8?q?n4niCrqYjc47HogTiTHoQnFF62wDqo8LuOgy3XTY6c2x2qsMxLJtDEiweTAgWjyQF?= =?utf-8?q?4Q923/KjQii6AFPI0CYYFskwyu2IiPO49KQLaMqYI5MTrw/FZyi2IvPhO2LyjYbve?= =?utf-8?q?MpSj28EcA3lDUjxP7mu3t1dNvErCnZKkDu0iXLqCsTXcDuVf8QwH6XuUCGGBJpkmr?= =?utf-8?q?BCrEky55P+q1g5NeIcDprmtWG+oJealwm7CPLdMDCZXmwIGOwsXhfURvmqkk2aOG6?= =?utf-8?q?CKO1i4Uzx0UixolSkGnu2Ji+LcDVVgUiLEhXKeJZGj90svJ39mBxXriwL8IuuXWij?= =?utf-8?q?pwvNeQ4iItRF6Vw5L3hbDhvWZEWdfr1x5W419IHxwb2ak/PVcvGDyQeXK3OqTJEDr?= =?utf-8?q?6nf7dxaeo/s4gNlvSR4OXcBwy5uoGh02fGNqQ122kN0D78Ri1RfwqNJQPNEJu98bz?= =?utf-8?q?pDP69ItuYxb3Wi26ajHpDooo81OrbnfswsU5jkqrp0I3dowX/PWA2z/IKEahwu5+z?= =?utf-8?q?SvPhgkUJRTM28ID7T1hcnMloyoh3sAtFRPoRiAswZxsB7Cb2J9iSgx9NYNmy59MHN?= =?utf-8?q?wxXhYhoRhQiRY5cnbkwgmsYbiM//84LzRGwWIe1BUyA+/KaLNcH8PrvMUtdeO9WpX?= =?utf-8?q?IDxmVwoK+SxmVqFuAtOUSPRQ18tWrWG4FyllORMZ67ZXctOYsqElmv9UlxbFpCf5H?= =?utf-8?q?RwycCPvMOtikv3F0COb7DR8B097+f8363lg0ObMq7wuTPkWSruoiTiJEcH+lXU6hg?= =?utf-8?q?DNOhH8MiSPZ6lDeuc2S9wJLRb8HwBbqIoWlrf3IEpqHYoywWn1aqEZ4rY9WxDsiXc?= =?utf-8?q?GD8zxh5053KDQ6sEeQBVkYjRj+LvzBGQQ/zwS41joTcyGeolKT7n+4sTqB6PDRlZ0?= =?utf-8?q?UygKuyBBtcibdXdgJpAAZMhvBdqA7EvsCNvKYjBhBOJ2sOq4obSicfgL0aq+TCwEv?= =?utf-8?q?ud7Pm3lDtgqA?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68d26252-9578-4d03-ed30-08dce2f1a1c4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2024 14:51:00.9681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nL0mxQ1QKI3wM3AqqmtH9vozwrF+KuB6h+RSW2i3d7fg3rIHHtSNhfaeeMlanGNsedJJG7LhSBh/I4IPjKu8OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9699 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_075108_519888_D59BCAAB X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org According to I3C spec ver 1.1, 09-Jun-2021, section 5.1.2.5: The I3C Controller shall hold SCL low while the Bus is in ACK/NACK Phase of I3C/I2C transfer. But maximum stall time is 100us. The IRQs have to be disabled to prevent schedule during the whole I3C transaction, otherwise, the I3C bus timeout may happen if any irq or schedule happen during transaction. Replace mutex with spin_lock_irqsave() to avoid stalling SCL more than 100us. Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Change from v5 to v6 - reduce timeout to 100us, normal get IBIWIN at 9th SCL. 100us will timeout by i3c spec. Change from v3-v4 - improve commit message - needn't mutex here, other place already use spin_lock_saveirq to protent i3c transfer. --- drivers/i3c/master/svc-i3c-master.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 5df0ec02d73ce..ed3f1bfbea37a 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -436,7 +436,16 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) u32 status, val; int ret; - mutex_lock(&master->lock); + /* + * According to I3C spec ver 1.1, 09-Jun-2021, section 5.1.2.5: + * + * The I3C Controller shall hold SCL low while the Bus is in ACK/NACK Phase of I3C/I2C + * transfer. But maximum stall time is 100us. The IRQs have to be disabled to prevent + * schedule during the whole I3C transaction, otherwise, the I3C bus timeout may happen if + * any irq or schedule happen during transaction. + */ + guard(spinlock_irqsave)(&master->xferqueue.lock); + /* * IBIWON may be set before SVC_I3C_MCTRL_REQUEST_AUTO_IBI, causing * readl_relaxed_poll_timeout() to return immediately. Consequently, @@ -456,8 +465,8 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) master->regs + SVC_I3C_MCTRL); /* Wait for IBIWON, should take approximately 100us */ - ret = readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val, - SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); + ret = readl_relaxed_poll_timeout_atomic(master->regs + SVC_I3C_MSTATUS, val, + SVC_I3C_MSTATUS_IBIWON(val), 0, 100); if (ret) { dev_err(master->dev, "Timeout when polling for IBIWON\n"); svc_i3c_master_emit_stop(master); @@ -529,7 +538,6 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) reenable_ibis: svc_i3c_master_enable_interrupts(master, SVC_I3C_MINT_SLVSTART); - mutex_unlock(&master->lock); } static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)