From patchwork Fri Dec 20 11:33:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13916643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29602E7718D for ; Fri, 20 Dec 2024 11:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SxHpAPYyjQ8REbmK/2q3P9P/xwgyj+S5H+HAq9cvRco=; b=CVAmtQP6DK62tP +Zh4fkLL2iYmK1vkqfUek7V5R/SogrjV51ObEpVzuuOKrYrmrCyKB42+FEBWX9A9oImhcr2XPM/Qg p6GTCBzwEKymZHGtjJEYZYuGY2nry+Oux/E3qlRNY/hDYGfHeqxLtbkTssjxhaSrgBBwn9s/g/pgb 5nJnjnuHOl3VIYpYRdS/v4AaC+ALO2R0yhSObIL/xmbweGZeD26MyLZLTUNzp2UZe4YxgGKSeA5++ JjK5S3ORREPT6J7XkUnxS+Bb+SqyDPCNBfH8fw5XvnuSloKXbmXZM25VW5nsoQOsnLYlpgaVHjFJX PzAvApwZRFnlEPwwLbAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tObGH-00000004mxu-3tBd; Fri, 20 Dec 2024 11:33:41 +0000 Received: from zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tObGF-00000004mvB-3C1l for linux-i3c@lists.infradead.org; Fri, 20 Dec 2024 11:33:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Xle8vB4tioG0noyMlph488LEaOgkNcMUcx711tLKtDQ=; b=DvKXHZ E6sa8osmBPAmLZAxnYmUvqb4aaU5Dd18iLQNg3ISos1/vhTWDlQAYh2ypr3SpVyO cHRS7jTgpQR0XiIhcHAN5ZpEnBry5XOoMw6+KF4Dv828B9U1OAsTGZxZMJwYa24+ 3sfBxRo5ysuRPBIvd8TvmXVG+3zlOjbdphpwq0b5uDA6incMolKXEccKFjsnS+ph HaDHkrOLVAAcyXPeoQXBehaPSsqdtqK8ooEexrVqYpoOxL/o+KMgSq7kBfLzsZZt Fcu1peqThM1T06cUyZJZJ5v/vZqe2IAd9xbojbCWZSe+GZ+kbiDRD29/gDEQrisy LOci0rnhp89kcnvA== Received: (qmail 991002 invoked from network); 20 Dec 2024 12:33:38 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 20 Dec 2024 12:33:38 +0100 X-UD-Smtp-Session: l3s3148p1@IZaTBLIp0uIujnsY From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Yury Norov , linux-i3c@lists.infradead.org, Wolfram Sang , Alexandre Belloni Subject: [PATCH RFT RESEND 4/5] i3c: mipi-i3c-hci: use get_parity8 helper instead of open coding it Date: Fri, 20 Dec 2024 12:33:32 +0100 Message-Id: <20241220113335.17937-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241220113335.17937-1-wsa+renesas@sang-engineering.com> References: <20241220113335.17937-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241220_033340_065601_0E86E766 X-CRM114-Status: UNSURE ( 7.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang --- drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c index 47b9b4d4ed3f..ac67016932b0 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c @@ -40,15 +40,6 @@ #define dat_w0_write(i, v) writel(v, hci->DAT_regs + (i) * 8) #define dat_w1_write(i, v) writel(v, hci->DAT_regs + (i) * 8 + 4) -static inline bool dynaddr_parity(unsigned int addr) -{ - addr |= 1 << 7; - addr += addr >> 4; - addr += addr >> 2; - addr += addr >> 1; - return (addr & 1); -} - static int hci_dat_v1_init(struct i3c_hci *hci) { unsigned int dat_idx; @@ -123,7 +114,7 @@ static void hci_dat_v1_set_dynamic_addr(struct i3c_hci *hci, dat_w0 = dat_w0_read(dat_idx); dat_w0 &= ~(DAT_0_DYNAMIC_ADDRESS | DAT_0_DYNADDR_PARITY); dat_w0 |= FIELD_PREP(DAT_0_DYNAMIC_ADDRESS, address) | - (dynaddr_parity(address) ? DAT_0_DYNADDR_PARITY : 0); + (get_parity8(address) ? 0 : DAT_0_DYNADDR_PARITY); dat_w0_write(dat_idx, dat_w0); }