From patchwork Mon Jan 6 09:27:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 13927100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 000F8E7719C for ; Mon, 6 Jan 2025 09:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NFm8l6LPRZ5Id0DiGLpxz8LWyWC5OMEX8ZLLzo+Nlmo=; b=jxowqcgXe4ym+T dzn6MuI2QHXJRWRCnYs1qdvr5wV1BBPwZoLyrdFk6r0EV6n7wWNxUz0KkmuHODJ4r7qHRaLMeQcc8 DLQ0uKktDbbPmUSBZP5DyxT3N0JWVBUDCQpZ9B5M7ef27u6KpnLt2rRq9/3+oStXlw1PDPCnRvkbL tOG+JoGxxM/4lwDikSRIMwQxtC8B1gVMFsYimXXU0fss6U+CQlHkzsTMI6ON7BxrpEWX0tYR7Ltgb QEkjJoI3DMjmV5dAtLZqhtOo7Ne8sHvt8mh/VoicE7QKxelmiECAmzvOdN3N3sfWu6N/Qya1vDBl9 H85A3+RpykmicZ34SeQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tUjOe-00000000gL0-35ew; Mon, 06 Jan 2025 09:27:40 +0000 Received: from zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tUjOU-00000000gH3-3r65 for linux-i3c@lists.infradead.org; Mon, 06 Jan 2025 09:27:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=Ta1yRvPmk5gWC8V3XFdegSgto4i6026D0epR4X2xhig=; b=Qij2Cc LM1RRwo4VymSORu7F1VP1pfl+/P/5ihzXTIQ3pRpn7s0AbMSvkfUL7WYdHgE7cuC +upm6jeCmLdl31m9iYkwgQQSbPm7Ke2bLolDl06mD5tJYynbBQc6DZlYSm7Hv8Y0 Cn3/u9NOhlxez0uxP1E1wMEgDvgKWVxt4pW03bJFSbGABFwEWRUQFhDzUF4SXdE6 sx7wGBmzZFp77+Az+Wo4AZyISdRcZ41ZwNk2zRQmf/K8f7V7tmHEKVEz+aPPw65j 5FV4WYpRpRvOWIPLOOUApUmjJooXGgCVVLFbDgtMJiYWVjneqapQynCfuiSUXI/s eN+wjJbiJocPxZ9g== Received: (qmail 1727955 invoked from network); 6 Jan 2025 10:27:29 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 6 Jan 2025 10:27:29 +0100 X-UD-Smtp-Session: l3s3148p1@rny7PAYr/JsgAwDPXw20AOMQ2KO98fSH From: Wolfram Sang To: linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , Jarkko Nikula , Alexandre Belloni Subject: [PATCH v3 4/5] i3c: mipi-i3c-hci: use parity8 helper instead of open coding it Date: Mon, 6 Jan 2025 10:27:22 +0100 Message-ID: <20250106092725.22869-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250106092725.22869-1-wsa+renesas@sang-engineering.com> References: <20250106092725.22869-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_012731_227444_780FE529 X-CRM114-Status: UNSURE ( 8.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang Tested-by: Jarkko Nikula --- drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c index 47b9b4d4ed3f..85c4916972e4 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c @@ -40,15 +40,6 @@ #define dat_w0_write(i, v) writel(v, hci->DAT_regs + (i) * 8) #define dat_w1_write(i, v) writel(v, hci->DAT_regs + (i) * 8 + 4) -static inline bool dynaddr_parity(unsigned int addr) -{ - addr |= 1 << 7; - addr += addr >> 4; - addr += addr >> 2; - addr += addr >> 1; - return (addr & 1); -} - static int hci_dat_v1_init(struct i3c_hci *hci) { unsigned int dat_idx; @@ -123,7 +114,7 @@ static void hci_dat_v1_set_dynamic_addr(struct i3c_hci *hci, dat_w0 = dat_w0_read(dat_idx); dat_w0 &= ~(DAT_0_DYNAMIC_ADDRESS | DAT_0_DYNADDR_PARITY); dat_w0 |= FIELD_PREP(DAT_0_DYNAMIC_ADDRESS, address) | - (dynaddr_parity(address) ? DAT_0_DYNADDR_PARITY : 0); + (parity8(address) ? 0 : DAT_0_DYNADDR_PARITY); dat_w0_write(dat_idx, dat_w0); }