| Message ID | e03fb41054a8431b27cc84c3d83ada9464172ef7.1567071213.git.vitor.soares@synopsys.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | i3c: remove device if failed on pre_assign_dyn_addr() | expand |
On Thu, 29 Aug 2019 12:19:35 +0200 Vitor Soares <Vitor.Soares@synopsys.com> wrote: > For today the reattach function only update the device address on the > controller. > > Update the location to the first available too, will optimize the > enumeration process avoiding additional checks to keep the available > positions on address table consecutive. Given the number of available slots I honestly don't think it makes a difference, but I also don't mind this change, so Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> > --- > drivers/i3c/master/dw-i3c-master.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c > index 1d83c97..62261ac 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -898,6 +898,22 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, > struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); > struct i3c_master_controller *m = i3c_dev_get_master(dev); > struct dw_i3c_master *master = to_dw_i3c_master(m); > + int pos; > + > + pos = dw_i3c_master_get_free_pos(master); > + > + if (data->index > pos && pos > 0) { > + writel(0, > + master->regs + > + DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); > + > + master->addrs[data->index] = 0; > + master->free_pos |= BIT(data->index); > + > + data->index = pos; > + master->addrs[pos] = dev->info.dyn_addr; > + master->free_pos &= ~BIT(pos); > + } > > writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr), > master->regs +
Hi Boris, From: Boris Brezillon <boris.brezillon@collabora.com> Date: Thu, Aug 29, 2019 at 12:15:19 > On Thu, 29 Aug 2019 12:19:35 +0200 > Vitor Soares <Vitor.Soares@synopsys.com> wrote: > > > For today the reattach function only update the device address on the > > controller. > > > > Update the location to the first available too, will optimize the > > enumeration process avoiding additional checks to keep the available > > positions on address table consecutive. > > Given the number of available slots I honestly don't think it makes a > difference, but I also don't mind this change, so The slots are HW dependent. The point is, I need to guarantee the available slot are consecutives. If you have any suggestion I appreciate. > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > > > > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> > > --- > > drivers/i3c/master/dw-i3c-master.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c > > index 1d83c97..62261ac 100644 > > --- a/drivers/i3c/master/dw-i3c-master.c > > +++ b/drivers/i3c/master/dw-i3c-master.c > > @@ -898,6 +898,22 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, > > struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); > > struct i3c_master_controller *m = i3c_dev_get_master(dev); > > struct dw_i3c_master *master = to_dw_i3c_master(m); > > + int pos; > > + > > + pos = dw_i3c_master_get_free_pos(master); > > + > > + if (data->index > pos && pos > 0) { > > + writel(0, > > + master->regs + > > + DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); > > + > > + master->addrs[data->index] = 0; > > + master->free_pos |= BIT(data->index); > > + > > + data->index = pos; > > + master->addrs[pos] = dev->info.dyn_addr; > > + master->free_pos &= ~BIT(pos); > > + } > > > > writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr), > > master->regs + Best regards, Vitor Soares
diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 1d83c97..62261ac 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -898,6 +898,22 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); struct i3c_master_controller *m = i3c_dev_get_master(dev); struct dw_i3c_master *master = to_dw_i3c_master(m); + int pos; + + pos = dw_i3c_master_get_free_pos(master); + + if (data->index > pos && pos > 0) { + writel(0, + master->regs + + DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); + + master->addrs[data->index] = 0; + master->free_pos |= BIT(data->index); + + data->index = pos; + master->addrs[pos] = dev->info.dyn_addr; + master->free_pos &= ~BIT(pos); + } writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr), master->regs +
For today the reattach function only update the device address on the controller. Update the location to the first available too, will optimize the enumeration process avoiding additional checks to keep the available positions on address table consecutive. Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> --- drivers/i3c/master/dw-i3c-master.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)