mbox series

[RESEND,v3,00/30] Update cros_ec_commands.h

Message ID 20190603183401.151408-1-gwendal@chromium.org (mailing list archive)
Headers show
Series Update cros_ec_commands.h | expand

Message

Gwendal Grignou June 3, 2019, 6:33 p.m. UTC 
The interface between CrosEC embedded controller and the host,
described by cros_ec_commands.h, as diverged from what the embedded
controller really support.

The source of thruth is at
https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h

That include file is converted to remove ACPI and Embedded only code.

From now on, cros_ec_commands.h will be automatically generated from
the file above, do not modify directly.

Fell free to squash the commits below.

v3 resent: Add Fabien's ack.

Changes in v3:
- Rebase after commit 81888d8ab1532 ("mfd: cros_ec: Update the EC feature codes")
- Add Acked-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Fabien Lahoudere <fabien.lahoudere@collabora.com>

Changes in v2:
- Move I2S changes at the end of the patchset, squashed with change in
  sound/soc/codecs/cros_ec_codec.c to match new interface.
- Add Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Gwendal Grignou (30):
  mfd: cros_ec: Update license term
  mfd: cros_ec: Zero BUILD_ macro
  mfd: cros_ec: set comments properly
  mfd: cros_ec: add ec_align macros
  mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values
  mfd: cros_ec: use BIT macro
  mfd: cros_ec: Update ACPI interface definition
  mfd: cros_ec: move HDMI CEC API definition
  mfd: cros_ec: Remove zero-size structs
  mfd: cros_ec: Add Flash V2 commands API
  mfd: cros_ec: Add PWM_SET_DUTY API
  mfd: cros_ec: Add lightbar v2 API
  mfd: cros_ec: Expand hash API
  mfd: cros_ec: Add EC transport protocol v4
  mfd: cros_ec: Complete MEMS sensor API
  mfd: cros_ec: Fix event processing API
  mfd: cros_ec: Add fingerprint API
  mfd: cros_ec: Fix temperature API
  mfd: cros_ec: Complete Power and USB PD API
  mfd: cros_ec: Add API for keyboard testing
  mfd: cros_ec: Add Hibernate API
  mfd: cros_ec: Add Smart Battery Firmware update API
  mfd: cros_ec: Add I2C passthru protection API
  mfd: cros_ec: Add API for EC-EC communication
  mfd: cros_ec: Add API for Touchpad support
  mfd: cros_ec: Add API for Fingerprint support
  mfd: cros_ec: Add API for rwsig
  mfd: cros_ec: Add SKU ID and Secure storage API
  mfd: cros_ec: Add Management API entry points
  mfd: cros_ec: Update I2S API

 include/linux/mfd/cros_ec_commands.h | 3658 ++++++++++++++++++++------
 sound/soc/codecs/cros_ec_codec.c     |    8 +-
 2 files changed, 2915 insertions(+), 751 deletions(-)

Comments

Mark Brown June 3, 2019, 7:42 p.m. UTC | #1 
On Mon, Jun 03, 2019 at 11:33:31AM -0700, Gwendal Grignou wrote:
> The interface between CrosEC embedded controller and the host,
> described by cros_ec_commands.h, as diverged from what the embedded
> controller really support.

I'm not clear why I keep getting copied on this series or why it's being
resent?
Lee Jones June 4, 2019, 5:47 a.m. UTC | #2 
On Mon, 03 Jun 2019, Mark Brown wrote:

> On Mon, Jun 03, 2019 at 11:33:31AM -0700, Gwendal Grignou wrote:
> > The interface between CrosEC embedded controller and the host,
> > described by cros_ec_commands.h, as diverged from what the embedded
> > controller really support.
> 
> I'm not clear why I keep getting copied on this series or why it's being
> resent?

Not sure why you're copied in, but I asked him to resend.
Lee Jones June 4, 2019, 5:59 a.m. UTC | #3 
On Mon, 03 Jun 2019, Gwendal Grignou wrote:

> The interface between CrosEC embedded controller and the host,
> described by cros_ec_commands.h, as diverged from what the embedded
> controller really support.
> 
> The source of thruth is at
> https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> 
> That include file is converted to remove ACPI and Embedded only code.
> 
> From now on, cros_ec_commands.h will be automatically generated from
> the file above, do not modify directly.
> 
> Fell free to squash the commits below.
> 
> v3 resent: Add Fabien's ack.

Thanks for doing that.

In future, please ensure *-bys tags are in chronological order with
the first one either being a Suggested-by or your SoB.  Reviews, tests
etc usually come *after* first submission.

I've changed this for you this time, yes in all 30 patches!  :)

Anyway, all applied, thanks.
Enric Balletbo Serra June 6, 2019, 11:25 a.m. UTC | #4 
Hi Lee,

Missatge de Lee Jones <lee.jones@linaro.org> del dia dt., 4 de juny
2019 a les 8:00:
>
> On Mon, 03 Jun 2019, Gwendal Grignou wrote:
>
> > The interface between CrosEC embedded controller and the host,
> > described by cros_ec_commands.h, as diverged from what the embedded
> > controller really support.
> >
> > The source of thruth is at
> > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> >
> > That include file is converted to remove ACPI and Embedded only code.
> >
> > From now on, cros_ec_commands.h will be automatically generated from
> > the file above, do not modify directly.
> >
> > Fell free to squash the commits below.
> >
> > v3 resent: Add Fabien's ack.
>
> Thanks for doing that.
>
> In future, please ensure *-bys tags are in chronological order with
> the first one either being a Suggested-by or your SoB.  Reviews, tests
> etc usually come *after* first submission.
>
> I've changed this for you this time, yes in all 30 patches!  :)
>
> Anyway, all applied, thanks.
>

Could you do an immutable branch with those? I've few patches that
depends on those changes and probably I'll have more. Otherwise, I'll
wait for those to land.

Thanks,
 Enric

> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel