mbox series

[0/5] move buffer allocation into st_sensors_buffer

Message ID 20190731215250.16403-1-denis.ciocca@st.com (mailing list archive)
Headers show
Series move buffer allocation into st_sensors_buffer | expand

Message

Denis CIOCCA July 31, 2019, 9:52 p.m. UTC
As proposed by Alexandru, memory allocation and de-allocation can be
performed in a more neat way in st_sensors_buffer.

Denis Ciocca (5):
  iio:common: introduce st_sensors_buffer_preenable/predisable functions
  iio:accel: do not allocate/de-allocate buffer here but link setup_ops
    to st_sensors_buffer
  iio:gyro: do not allocate/de-allocate buffer here but link setup_ops
    to st_sensors_buffer
  iio:magn: do not allocate/de-allocate buffer here but link setup_ops
    to st_sensors_buffer
  iio:pressure: do not allocate/de-allocate buffer here but link
    setup_ops to st_sensors_buffer

 drivers/iio/accel/st_accel_buffer.c           | 14 +++---------
 .../iio/common/st_sensors/st_sensors_buffer.c | 22 +++++++++++++++++++
 drivers/iio/gyro/st_gyro_buffer.c             | 14 +++---------
 drivers/iio/magnetometer/st_magn_buffer.c     | 14 +++---------
 drivers/iio/pressure/st_pressure_buffer.c     | 14 +++---------
 include/linux/iio/common/st_sensors.h         |  2 ++
 6 files changed, 36 insertions(+), 44 deletions(-)

Comments

Alexandru Ardelean Aug. 1, 2019, 8:23 a.m. UTC | #1
On Wed, 2019-07-31 at 14:52 -0700, Denis Ciocca wrote:
> [External]
> 
> As proposed by Alexandru, memory allocation and de-allocation can be
> performed in a more neat way in st_sensors_buffer.
> 

Thank you for this series as well.
As a note: I think this depends on the previous series: "[PATCH v2 0/4] preenable/postenable/predisable fixup for ST
drivers"

The changeset looks neat.

Alex

> Denis Ciocca (5):
>   iio:common: introduce st_sensors_buffer_preenable/predisable functions
>   iio:accel: do not allocate/de-allocate buffer here but link setup_ops
>     to st_sensors_buffer
>   iio:gyro: do not allocate/de-allocate buffer here but link setup_ops
>     to st_sensors_buffer
>   iio:magn: do not allocate/de-allocate buffer here but link setup_ops
>     to st_sensors_buffer
>   iio:pressure: do not allocate/de-allocate buffer here but link
>     setup_ops to st_sensors_buffer
> 
>  drivers/iio/accel/st_accel_buffer.c           | 14 +++---------
>  .../iio/common/st_sensors/st_sensors_buffer.c | 22 +++++++++++++++++++
>  drivers/iio/gyro/st_gyro_buffer.c             | 14 +++---------
>  drivers/iio/magnetometer/st_magn_buffer.c     | 14 +++---------
>  drivers/iio/pressure/st_pressure_buffer.c     | 14 +++---------
>  include/linux/iio/common/st_sensors.h         |  2 ++
>  6 files changed, 36 insertions(+), 44 deletions(-)
>