[v4,0/4] iio: adc: at91: misc driver cleanups

Message

Alexandru Ardelean Sept. 30, 2020, 1:50 p.m. UTC

This whole thing started because the lkp bot haunted me for a while with
this build warning:

>> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable
>> 'at91_adc_dt_ids' [-Wunused-const-variable]
   static const struct of_device_id at91_adc_dt_ids[] = {
                                    ^
   1 warning generated.

The fix may likely be patch 'iio: adc: at91_adc: add Kconfig dependency
on the OF symbol'; was pointed out by Jonathan.

Changelog v3 -> v4:
- https://lore.kernel.org/linux-iio/[e-mail]/T/#t
- for patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'
   * updated/cleand up commit description
   * remove redundant pdata erorr message
   * return error code from at91_adc_probe_dt()
   * remove 'if (!node)' null check in at91_adc_probe_dt()
- added 'Reviewed-by: Alexandre Belloni <[e-mail]>'
  for patch: 'iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr()'

Changelog v2 -> v3:
- https://lore.kernel.org/linux-iio/[e-mail]/T/#t
- added 'Reviewed-by: Alexandre Belloni <[e-mail]>'
  for patches:
     iio: adc: at91_adc: use of_device_get_match_data() helper
     iio: adc: at91_adc: const-ify some driver data
- fixed description for patch 'iio: adc: at91_adc: add Kconfig dependency on the OF symbol'
- squash patches:
     iio: adc: at91_adc: add Kconfig dependency on the OF symbol
     iio: adc: at91_adc: remove of_match_ptr() usage
- added patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'

Changelog v1 -> v2:
- https://lore.kernel.org/linux-iio/CA+U=[e-mail]/T/#m7c0efef4dc623776fe8bafdb5f734b0eaca50f82
- for patch 'iio: adc: at91_adc: use of_device_get_match_data() helper'
  changed description; it's just tidy-up patch, not a fix
- added 2 more patches:
  - iio: adc: at91_adc: add Kconfig dependency on the OF symbol
  - iio: adc: at91_adc: remove of_match_ptr() usage

Alexandru Ardelean (4):
  iio: adc: at91_adc: use of_device_get_match_data() helper
  iio: adc: at91_adc: const-ify some driver data
  iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove
    of_match_ptr()
  iio: adc: at91_adc: remove platform data and move defs in driver file

 drivers/iio/adc/Kconfig                |  2 +-
 drivers/iio/adc/at91_adc.c             | 73 ++++++++++----------------
 include/linux/platform_data/at91_adc.h | 49 -----------------
 3 files changed, 28 insertions(+), 96 deletions(-)
 delete mode 100644 include/linux/platform_data/at91_adc.h

Comments

Jonathan Cameron Oct. 10, 2020, 4:05 p.m. UTC | #1

On Wed, 30 Sep 2020 16:50:44 +0300
Alexandru Ardelean <[e-mail]> wrote:

> This whole thing started because the lkp bot haunted me for a while with
> this build warning:
> 
> >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable
> >> 'at91_adc_dt_ids' [-Wunused-const-variable]  
>    static const struct of_device_id at91_adc_dt_ids[] = {
>                                     ^
>    1 warning generated.
> 
> The fix may likely be patch 'iio: adc: at91_adc: add Kconfig dependency
> on the OF symbol'; was pointed out by Jonathan.

Series applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it and see what we missed.

Thanks,

Jonathan

> 
> Changelog v3 -> v4:
> - https://lore.kernel.org/linux-iio/[e-mail]/T/#t
> - for patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'
>    * updated/cleand up commit description
>    * remove redundant pdata erorr message
>    * return error code from at91_adc_probe_dt()
>    * remove 'if (!node)' null check in at91_adc_probe_dt()
> - added 'Reviewed-by: Alexandre Belloni <[e-mail]>'
>   for patch: 'iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr()'
> 
> Changelog v2 -> v3:
> - https://lore.kernel.org/linux-iio/[e-mail]/T/#t
> - added 'Reviewed-by: Alexandre Belloni <[e-mail]>'
>   for patches:
>      iio: adc: at91_adc: use of_device_get_match_data() helper
>      iio: adc: at91_adc: const-ify some driver data
> - fixed description for patch 'iio: adc: at91_adc: add Kconfig dependency on the OF symbol'
> - squash patches:
>      iio: adc: at91_adc: add Kconfig dependency on the OF symbol
>      iio: adc: at91_adc: remove of_match_ptr() usage
> - added patch: 'iio: adc: at91_adc: remove platform data and move defs in driver file'
> 
> Changelog v1 -> v2:
> - https://lore.kernel.org/linux-iio/CA+U=[e-mail]/T/#m7c0efef4dc623776fe8bafdb5f734b0eaca50f82
> - for patch 'iio: adc: at91_adc: use of_device_get_match_data() helper'
>   changed description; it's just tidy-up patch, not a fix
> - added 2 more patches:
>   - iio: adc: at91_adc: add Kconfig dependency on the OF symbol
>   - iio: adc: at91_adc: remove of_match_ptr() usage
> 
> Alexandru Ardelean (4):
>   iio: adc: at91_adc: use of_device_get_match_data() helper
>   iio: adc: at91_adc: const-ify some driver data
>   iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove
>     of_match_ptr()
>   iio: adc: at91_adc: remove platform data and move defs in driver file
> 
>  drivers/iio/adc/Kconfig                |  2 +-
>  drivers/iio/adc/at91_adc.c             | 73 ++++++++++----------------
>  include/linux/platform_data/at91_adc.h | 49 -----------------
>  3 files changed, 28 insertions(+), 96 deletions(-)
>  delete mode 100644 include/linux/platform_data/at91_adc.h
>