mbox series

[v5,0/3] iio: acpi_als: Add sotfware trigger support

Message ID 20201229015300.3037816-1-gwendal@chromium.org (mailing list archive)
Headers show
Series iio: acpi_als: Add sotfware trigger support | expand

Message

Gwendal Grignou Dec. 29, 2020, 1:52 a.m. UTC 
Some devices (chromebooks) present the ACPI ALS device but do not have
ability to notify when a new sample is present.
Add support for software trigger (hrtimer/sysfs-trigger) to allow
retrieving samples using iio buffers.

The first path fully adds timestamp channel, the second adds a local
variable in probe routine and the last one adds trigger support.

This patch assumes the patch "iio: set default trig->dev.parent" is
applied.


Gwendal Grignou (3):
  iio: acpi_als: Add timestamp channel
  iio: acpi_als: Add local variable dev in probe
  iio: acpi_als: Add trigger support

 drivers/iio/light/acpi-als.c | 121 +++++++++++++++++++++++------------
 1 file changed, 81 insertions(+), 40 deletions(-)

Comments

Jonathan Cameron Dec. 29, 2020, 5:39 p.m. UTC | #1 
On Mon, 28 Dec 2020 17:52:57 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:

> Some devices (chromebooks) present the ACPI ALS device but do not have
> ability to notify when a new sample is present.
> Add support for software trigger (hrtimer/sysfs-trigger) to allow
> retrieving samples using iio buffers.
> 
> The first path fully adds timestamp channel, the second adds a local
> variable in probe routine and the last one adds trigger support.
> 
> This patch assumes the patch "iio: set default trig->dev.parent" is
> applied.
I'm asking for a rebase of that series.  Otherwise this looks good to me

Thanks,

Jonathan

> 
> 
> Gwendal Grignou (3):
>   iio: acpi_als: Add timestamp channel
>   iio: acpi_als: Add local variable dev in probe
>   iio: acpi_als: Add trigger support
> 
>  drivers/iio/light/acpi-als.c | 121 +++++++++++++++++++++++------------
>  1 file changed, 81 insertions(+), 40 deletions(-)
>
Jonathan Cameron Feb. 21, 2021, 4:15 p.m. UTC | #2 
On Tue, 29 Dec 2020 17:39:10 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 28 Dec 2020 17:52:57 -0800
> Gwendal Grignou <gwendal@chromium.org> wrote:
> 
> > Some devices (chromebooks) present the ACPI ALS device but do not have
> > ability to notify when a new sample is present.
> > Add support for software trigger (hrtimer/sysfs-trigger) to allow
> > retrieving samples using iio buffers.
> > 
> > The first path fully adds timestamp channel, the second adds a local
> > variable in probe routine and the last one adds trigger support.
> > 
> > This patch assumes the patch "iio: set default trig->dev.parent" is
> > applied.  
> I'm asking for a rebase of that series.  Otherwise this looks good to me

Hi Gwendal,

Given the dependency isn't ready yet, please resend this series once it
is in place. 

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > 
> > 
> > Gwendal Grignou (3):
> >   iio: acpi_als: Add timestamp channel
> >   iio: acpi_als: Add local variable dev in probe
> >   iio: acpi_als: Add trigger support
> > 
> >  drivers/iio/light/acpi-als.c | 121 +++++++++++++++++++++++------------
> >  1 file changed, 81 insertions(+), 40 deletions(-)
> >   
>