| Message ID | 20210510125523.1271237-1-aardelean@deviqon.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ad_sigma_delta: convert all drivers to device-managed | expand |
On Mon, 10 May 2021 15:55:12 +0300 Alexandru Ardelean <aardelean@deviqon.com> wrote: > Well, for lack of a better title that's what this series does. > It merges Jonathan's patches from: > * https://lore.kernel.org/linux-iio/20210508182319.488551-1-jic23@kernel.org/ > Patch 3/3 was a polished a bit with my comments from that review and also > to use the devm_ad_sd_setup_buffer_and_trigger() function. > * https://lore.kernel.org/linux-iio/20210509114118.660422-1-jic23@kernel.org/ > Added only to base the conversion to devm_ > > The AD Sigma Delta family of ADC drivers share a lot of the logic in the > ad_sigma_delta lib-driver. > > This set introduces a devm_ad_sd_setup_buffer_and_trigger() call, which > aims to replace the 'ad_sd_{setup,cleanup}_buffer_and_trigger()' pair. > > This helps with converting the AD7780, AD7791, AD7793 and AD7192 > drivers use be fully converted to device-managed functions. Almost perfect code wise (just the one bug that predates this series I think). Couple of notes on series from process point of view. 1) Fixes at the front. Makes for uglier series but nicer backporting. 2) Sign-off on everything - even the ones from me that you didn't change. From DCO point of view you handled them (passed them back to me ;) so need your sign off. I have occasionally wondered if I should sign off again when this happens :) If you don't do a v2, just reply to say you are fine with me fixing the sign offs and I can do it whilst applying. Thanks, Jonathan > > Alexandru Ardelean (7): > iio: adc: ad_sigma_delta: introduct > devm_ad_sd_setup_buffer_and_trigger() > iio: adc: ad7793: convert to device-managed functions > iio: adc: ad7791: convert to device-managed functions > iio: adc: ad7780: convert to device-managed functions > iio: adc: ad7192: use devm_clk_get_optional() for mclk > iio: adc: ad7192: convert to device-managed functions > iio: adc: ad_sigma_delta: remove > ad_sd_{setup,cleanup}_buffer_and_trigger() > > Jonathan Cameron (4): > iio: adc: ad7192: Avoid disabling a clock that was never enabled. > iio: adc: ad7124: Fix missbalanced regulator enable / disable on > error. > iio: adc: ad7124: Fix potential overflow due to non sequential channel > numbers > iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop > remove() > > drivers/iio/adc/ad7124.c | 84 ++++++++++-------------- > drivers/iio/adc/ad7192.c | 90 +++++++++++--------------- > drivers/iio/adc/ad7780.c | 38 +++-------- > drivers/iio/adc/ad7791.c | 44 ++++--------- > drivers/iio/adc/ad7793.c | 53 +++++---------- > drivers/iio/adc/ad_sigma_delta.c | 82 ++++++++--------------- > include/linux/iio/adc/ad_sigma_delta.h | 4 +- > 7 files changed, 141 insertions(+), 254 deletions(-) >
On Mon, May 10, 2021 at 8:52 PM Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > > On Mon, 10 May 2021 15:55:12 +0300 > Alexandru Ardelean <aardelean@deviqon.com> wrote: > > > Well, for lack of a better title that's what this series does. > > It merges Jonathan's patches from: > > * https://lore.kernel.org/linux-iio/20210508182319.488551-1-jic23@kernel.org/ > > Patch 3/3 was a polished a bit with my comments from that review and also > > to use the devm_ad_sd_setup_buffer_and_trigger() function. > > * https://lore.kernel.org/linux-iio/20210509114118.660422-1-jic23@kernel.org/ > > Added only to base the conversion to devm_ > > > > The AD Sigma Delta family of ADC drivers share a lot of the logic in the > > ad_sigma_delta lib-driver. > > > > This set introduces a devm_ad_sd_setup_buffer_and_trigger() call, which > > aims to replace the 'ad_sd_{setup,cleanup}_buffer_and_trigger()' pair. > > > > This helps with converting the AD7780, AD7791, AD7793 and AD7192 > > drivers use be fully converted to device-managed functions. > > Almost perfect code wise (just the one bug that predates this series I think). > > Couple of notes on series from process point of view. > > 1) Fixes at the front. Makes for uglier series but nicer backporting. ack > 2) Sign-off on everything - even the ones from me that you didn't change. From DCO > point of view you handled them (passed them back to me ;) so need your > sign off. I have occasionally wondered if I should sign off again when this > happens :) ack; will do it; > > If you don't do a v2, just reply to say you are fine with me fixing the sign offs > and I can do it whilst applying. i'll send a V2 > > Thanks, > > Jonathan > > > > > Alexandru Ardelean (7): > > iio: adc: ad_sigma_delta: introduct > > devm_ad_sd_setup_buffer_and_trigger() > > iio: adc: ad7793: convert to device-managed functions > > iio: adc: ad7791: convert to device-managed functions > > iio: adc: ad7780: convert to device-managed functions > > iio: adc: ad7192: use devm_clk_get_optional() for mclk > > iio: adc: ad7192: convert to device-managed functions > > iio: adc: ad_sigma_delta: remove > > ad_sd_{setup,cleanup}_buffer_and_trigger() > > > > Jonathan Cameron (4): > > iio: adc: ad7192: Avoid disabling a clock that was never enabled. > > iio: adc: ad7124: Fix missbalanced regulator enable / disable on > > error. > > iio: adc: ad7124: Fix potential overflow due to non sequential channel > > numbers > > iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop > > remove() > > > > drivers/iio/adc/ad7124.c | 84 ++++++++++-------------- > > drivers/iio/adc/ad7192.c | 90 +++++++++++--------------- > > drivers/iio/adc/ad7780.c | 38 +++-------- > > drivers/iio/adc/ad7791.c | 44 ++++--------- > > drivers/iio/adc/ad7793.c | 53 +++++---------- > > drivers/iio/adc/ad_sigma_delta.c | 82 ++++++++--------------- > > include/linux/iio/adc/ad_sigma_delta.h | 4 +- > > 7 files changed, 141 insertions(+), 254 deletions(-) > > >
Well, for lack of a better title that's what this series does. It merges Jonathan's patches from: * https://lore.kernel.org/linux-iio/20210508182319.488551-1-jic23@kernel.org/ Patch 3/3 was a polished a bit with my comments from that review and also to use the devm_ad_sd_setup_buffer_and_trigger() function. * https://lore.kernel.org/linux-iio/20210509114118.660422-1-jic23@kernel.org/ Added only to base the conversion to devm_ The AD Sigma Delta family of ADC drivers share a lot of the logic in the ad_sigma_delta lib-driver. This set introduces a devm_ad_sd_setup_buffer_and_trigger() call, which aims to replace the 'ad_sd_{setup,cleanup}_buffer_and_trigger()' pair. This helps with converting the AD7780, AD7791, AD7793 and AD7192 drivers use be fully converted to device-managed functions. Alexandru Ardelean (7): iio: adc: ad_sigma_delta: introduct devm_ad_sd_setup_buffer_and_trigger() iio: adc: ad7793: convert to device-managed functions iio: adc: ad7791: convert to device-managed functions iio: adc: ad7780: convert to device-managed functions iio: adc: ad7192: use devm_clk_get_optional() for mclk iio: adc: ad7192: convert to device-managed functions iio: adc: ad_sigma_delta: remove ad_sd_{setup,cleanup}_buffer_and_trigger() Jonathan Cameron (4): iio: adc: ad7192: Avoid disabling a clock that was never enabled. iio: adc: ad7124: Fix missbalanced regulator enable / disable on error. iio: adc: ad7124: Fix potential overflow due to non sequential channel numbers iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop remove() drivers/iio/adc/ad7124.c | 84 ++++++++++-------------- drivers/iio/adc/ad7192.c | 90 +++++++++++--------------- drivers/iio/adc/ad7780.c | 38 +++-------- drivers/iio/adc/ad7791.c | 44 ++++--------- drivers/iio/adc/ad7793.c | 53 +++++---------- drivers/iio/adc/ad_sigma_delta.c | 82 ++++++++--------------- include/linux/iio/adc/ad_sigma_delta.h | 4 +- 7 files changed, 141 insertions(+), 254 deletions(-)