mbox series

[v2,0/6] IIO: Runtime PM related cleanups.

Message ID 20210516162103.1332291-1-jic23@kernel.org (mailing list archive)
Headers show
Series IIO: Runtime PM related cleanups. | expand

Message

Jonathan Cameron May 16, 2021, 4:20 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Changes since v1:
* Drop all patches since applied.
* Clean up some more unbalanced cases that Mauro pointed out.
* One additional fix for lack of put in an error path.
* Dropped zpa2326 patch for now.  The use of runtime pm in that driver
  is sufficiently odd that it needs a closer look before any changes.

Note the unbalanced put is not a bug as such, because the runtime pm core
protects against the reference count going negative.  However, it is
a bad pattern to have copied into new drivers (as it confuses me)
so I'd like to clear it out.

Inspired by Mauro's work on similar issues in media and Julia's
coccicheck script.

There will be at least one more set of these once this first set
have flushed out any mistakes I may have made.

I checked my assumptions around the excess pm_runtime_put_noidle
calls in QEMU but may well be missing something even so.

Cc: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Cc: Matt Ranostay <matt.ranostay@konsulko.com>

Jonathan Cameron (6):
  iio: imu: mpu6050: Balance runtime pm + use
    pm_runtime_resume_and_get()
  iio: adc: ads1015: Balance runtime pm +  pm_runtime_resume_and_get()
  iio: chemical: atlas-sensor: Balance runtime pm +
    pm_runtime_resume_and_get()
  iio: prox: pulsed-light-v2: Fix misbalance runtime pm in error path
  iio: prox: pulsed-light-v2: Use pm_runtime_resume_and_get()
  iio: pressure: icp10100: Balance runtime pm + use
    pm_runtime_resume_and_get()

 drivers/iio/adc/ti-ads1015.c                  |  5 +----
 drivers/iio/chemical/atlas-sensor.c           | 13 ++++---------
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c    | 19 ++++++-------------
 drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c |  6 ++----
 drivers/iio/pressure/icp10100.c               |  5 +++--
 .../iio/proximity/pulsedlight-lidar-lite-v2.c |  7 +++++--
 6 files changed, 21 insertions(+), 34 deletions(-)