| Message ID | 20210610095300.3613-1-stephan@gerhold.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: accel: bmc150: Add support for BMA253/BMA254 | expand |
Hi, On 6/10/21 11:52 AM, Stephan Gerhold wrote: > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > The current situation is very confusing: BMA254 is supported by the bma180 > driver, but BMA255 is supported by the bmc150-accel driver. > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > and BMA253/BMA254 would be a bit better supported in bmc150 > (which has support for the motion trigger/interrupt). > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > over to bmc150, removing some unnecessary code from the bma180 driver. > > I asked Linus Walleij to test these patches on BMA254 a while ago > and he suggested that I already add his Reviewed-by. > > Stephan Gerhold (6): > iio: accel: bmc150: Drop misleading/duplicate chip identifiers > dt-bindings: iio: accel: bma255: Document bosch,bma253 > iio: accel: bmc150: Add device IDs for BMA253 > dt-bindings: iio: bma255: Allow multiple interrupts > dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema > iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans > > .../bindings/iio/accel/bosch,bma180.yaml | 3 +- > .../bindings/iio/accel/bosch,bma255.yaml | 9 +- > drivers/iio/accel/Kconfig | 6 +- > drivers/iio/accel/bma180.c | 91 +++---------------- > drivers/iio/accel/bmc150-accel-core.c | 36 ++------ > drivers/iio/accel/bmc150-accel-i2c.c | 34 ++++--- > drivers/iio/accel/bmc150-accel-spi.c | 31 ++++--- > drivers/iio/accel/bmc150-accel.h | 10 -- > 8 files changed, 67 insertions(+), 153 deletions(-) >
On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > The current situation is very confusing: BMA254 is supported by the bma180 > driver, but BMA255 is supported by the bmc150-accel driver. > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > and BMA253/BMA254 would be a bit better supported in bmc150 > (which has support for the motion trigger/interrupt). > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > over to bmc150, removing some unnecessary code from the bma180 driver. > > I asked Linus Walleij to test these patches on BMA254 a while ago > and he suggested that I already add his Reviewed-by. I add After addressing comments per patch 1, feel free to add my Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> to the series. And I guess you can drop Laurentiu Palcu email because most of those sensor drivers were done by an Intel team that is not at the company anymore for a few years. > Stephan Gerhold (6): > iio: accel: bmc150: Drop misleading/duplicate chip identifiers > dt-bindings: iio: accel: bma255: Document bosch,bma253 > iio: accel: bmc150: Add device IDs for BMA253 > dt-bindings: iio: bma255: Allow multiple interrupts > dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema > iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver > > .../bindings/iio/accel/bosch,bma180.yaml | 3 +- > .../bindings/iio/accel/bosch,bma255.yaml | 9 +- > drivers/iio/accel/Kconfig | 6 +- > drivers/iio/accel/bma180.c | 91 +++---------------- > drivers/iio/accel/bmc150-accel-core.c | 36 ++------ > drivers/iio/accel/bmc150-accel-i2c.c | 34 ++++--- > drivers/iio/accel/bmc150-accel-spi.c | 31 ++++--- > drivers/iio/accel/bmc150-accel.h | 10 -- > 8 files changed, 67 insertions(+), 153 deletions(-) > > -- > 2.31.1 >
On Thu, Jun 10, 2021 at 01:29:26PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > > The current situation is very confusing: BMA254 is supported by the bma180 > > driver, but BMA255 is supported by the bmc150-accel driver. > > > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > > and BMA253/BMA254 would be a bit better supported in bmc150 > > (which has support for the motion trigger/interrupt). > > > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > > over to bmc150, removing some unnecessary code from the bma180 driver. > > > > I asked Linus Walleij to test these patches on BMA254 a while ago > > and he suggested that I already add his Reviewed-by. > > I add > > > After addressing comments per patch 1, feel free to add my > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > to the series. > Thanks for the review! I think the re-ordering should be a separate commit to make the diff not too confusing. Is it fine for you if I send that as a follow-up patch? I already have two more patches that would conflict with the reordering, so it would be easier to include that in the next series. But I can also re-send the entire series with the extra patch if you prefer that, just let me know. :) > And I guess you can drop Laurentiu Palcu email because most of those > sensor drivers were done by an Intel team that is not at the company > anymore for a few years. > Oh yeah, got a lot of mails that it couldn't be delivered to Laurentiu. Oh well. Thanks, Stephan
On Thu, Jun 10, 2021 at 1:48 PM Stephan Gerhold <stephan@gerhold.net> wrote: > On Thu, Jun 10, 2021 at 01:29:26PM +0300, Andy Shevchenko wrote: > > On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > > > The current situation is very confusing: BMA254 is supported by the bma180 > > > driver, but BMA255 is supported by the bmc150-accel driver. > > > > > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > > > and BMA253/BMA254 would be a bit better supported in bmc150 > > > (which has support for the motion trigger/interrupt). > > > > > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > > > over to bmc150, removing some unnecessary code from the bma180 driver. > > > > > > I asked Linus Walleij to test these patches on BMA254 a while ago > > > and he suggested that I already add his Reviewed-by. > > > > I add > > > > > > After addressing comments per patch 1, feel free to add my > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > to the series. > > > > Thanks for the review! > > I think the re-ordering should be a separate commit to make the diff not > too confusing. Is it fine for you if I send that as a follow-up patch? > I already have two more patches that would conflict with the reordering, > so it would be easier to include that in the next series. > > But I can also re-send the entire series with the extra patch if you > prefer that, just let me know. :) I think that doing the reordering first (if there are no fixes so far) is a good idea.
On Thu, Jun 10, 2021 at 01:51:22PM +0300, Andy Shevchenko wrote: > On Thu, Jun 10, 2021 at 1:48 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > On Thu, Jun 10, 2021 at 01:29:26PM +0300, Andy Shevchenko wrote: > > > On Thu, Jun 10, 2021 at 12:56 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > > > > > The Bosch BMA253 accelerometer is very similar to both BMA254 and BMA255. > > > > The current situation is very confusing: BMA254 is supported by the bma180 > > > > driver, but BMA255 is supported by the bmc150-accel driver. > > > > > > > > It turns out the bma180 and bmc150-accel drivers have quite some overlap, > > > > and BMA253/BMA254 would be a bit better supported in bmc150 > > > > (which has support for the motion trigger/interrupt). > > > > > > > > This series adds BMA253 support to bmc150-accel and also moves BMA254 > > > > over to bmc150, removing some unnecessary code from the bma180 driver. > > > > > > > > I asked Linus Walleij to test these patches on BMA254 a while ago > > > > and he suggested that I already add his Reviewed-by. > > > > > > I add > > > > > > > > > After addressing comments per patch 1, feel free to add my > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > to the series. > > > > > > > Thanks for the review! > > > > I think the re-ordering should be a separate commit to make the diff not > > too confusing. Is it fine for you if I send that as a follow-up patch? > > I already have two more patches that would conflict with the reordering, > > so it would be easier to include that in the next series. > > > > But I can also re-send the entire series with the extra patch if you > > prefer that, just let me know. :) > > I think that doing the reordering first (if there are no fixes so far) > is a good idea. > OK, I will try to do that somehow. I will probably prepend one of my additional patches to this series since it has a Fixes: tag that would just cause the stable people headaches later when backporting. Thanks, Stephan