mbox series

[0/4] iio: accel: bmc150: Add support for INT2 and BMC156

Message ID 20210719112156.27087-1-stephan@gerhold.net (mailing list archive)
Headers show
Series iio: accel: bmc150: Add support for INT2 and BMC156 | expand

Message

Stephan Gerhold July 19, 2021, 11:21 a.m. UTC 
This series makes it possible to set up interrupts with the BMC150 driver
on boards where only the INT2 pin is connected (and not INT1). This is
particularly always the case for BMC156 since for some reason it only
has the INT2 pin and not the INT1 pin.

These changes were already partially discussed here:
https://lore.kernel.org/linux-iio/YMOphuXSoODIVX06@gerhold.net/

Stephan Gerhold (4):
  dt-bindings: iio: accel: bma255: Add interrupt-names
  dt-bindings: iio: accel: bma255: Add bosch,bmc156_accel
  iio: accel: bmc150: Make it possible to configure INT2 instead of INT1
  iio: accel: bmc150: Add support for BMC156

 .../bindings/iio/accel/bosch,bma255.yaml      | 27 +++++++
 drivers/iio/accel/Kconfig                     |  5 +-
 drivers/iio/accel/bmc150-accel-core.c         | 77 +++++++++++++++----
 drivers/iio/accel/bmc150-accel-i2c.c          | 10 ++-
 drivers/iio/accel/bmc150-accel-spi.c          | 10 ++-
 drivers/iio/accel/bmc150-accel.h              |  9 ++-
 6 files changed, 118 insertions(+), 20 deletions(-)

Comments

Andy Shevchenko July 19, 2021, 12:34 p.m. UTC | #1 
On Mon, Jul 19, 2021 at 2:26 PM Stephan Gerhold <stephan@gerhold.net> wrote:
>
> This series makes it possible to set up interrupts with the BMC150 driver
> on boards where only the INT2 pin is connected (and not INT1). This is
> particularly always the case for BMC156 since for some reason it only
> has the INT2 pin and not the INT1 pin.
>
> These changes were already partially discussed here:
> https://lore.kernel.org/linux-iio/YMOphuXSoODIVX06@gerhold.net/

I forgot the story, but the series sounds to me like déjà-vu. Please,
remind me if it was sent once before? If yes, then this one misses
version bumping and/or changelog.
Stephan Gerhold July 19, 2021, 12:42 p.m. UTC | #2 
On Mon, Jul 19, 2021 at 03:34:50PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 19, 2021 at 2:26 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> >
> > This series makes it possible to set up interrupts with the BMC150 driver
> > on boards where only the INT2 pin is connected (and not INT1). This is
> > particularly always the case for BMC156 since for some reason it only
> > has the INT2 pin and not the INT1 pin.
> >
> > These changes were already partially discussed here:
> > https://lore.kernel.org/linux-iio/YMOphuXSoODIVX06@gerhold.net/
> 
> I forgot the story, but the series sounds to me like déjà-vu. Please,
> remind me if it was sent once before? If yes, then this one misses
> version bumping and/or changelog.
> 

Hm, no I didn't send this one before. :)

Perhaps you are confusing it with the patch series I sent for BMA253
support recently [1] which is where I mentioned I would work on BMC156
support as well as follow-up series (see link above). :)

Thanks!
Stephan

[1]: https://lore.kernel.org/linux-iio/20210611080903.14384-1-stephan@gerhold.net/