[v12,0/2] iio: accel: add support for ADXL355

Message ID	20210811073027.124619-1-puranjay12@gmail.com (mailing list archive)
Headers	show Return-Path: <linux-iio-owner@kernel.org> From: Puranjay Mohan <puranjay12@gmail.com> To: Michael.Hennerich@analog.com, jic23@kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, lars@metafoo.de, Dragos.Bogdan@analog.com, Darius.Berghe@analog.com, andy.shevchenko@gmail.com Cc: Puranjay Mohan <puranjay12@gmail.com> Subject: [PATCH v12 0/2] iio: accel: add support for ADXL355 Date: Wed, 11 Aug 2021 13:00:25 +0530 Message-Id: <20210811073027.124619-1-puranjay12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	iio: accel: add support for ADXL355 \| expand [v12,0/2] iio: accel: add support for ADXL355 [v12,1/2] dt-bindings: iio: accel: Add DT binding doc for ADXL355 [v12,2/2] iio: accel: Add driver support for ADXL355

Message ID

20210811073027.124619-1-puranjay12@gmail.com (mailing list archive)

Headers

From: Puranjay Mohan <puranjay12@gmail.com>
To: Michael.Hennerich@analog.com, jic23@kernel.org,
        devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, lars@metafoo.de,
        Dragos.Bogdan@analog.com, Darius.Berghe@analog.com,
        andy.shevchenko@gmail.com
Cc: Puranjay Mohan <puranjay12@gmail.com>
Subject: [PATCH v12 0/2] iio: accel: add support for ADXL355
Date: Wed, 11 Aug 2021 13:00:25 +0530
Message-Id: <20210811073027.124619-1-puranjay12@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

iio: accel: add support for ADXL355 | expand

Message

Puranjay Mohan Aug. 11, 2021, 7:30 a.m. UTC

Add the dt-bindings and the driver for ADXL355 3-axis MEMS Accelerometer.

Changes since v11:
1. Add forward declaration of struct device in header.
2. Use defines for power-of-10s.

Changes since v10:
1. Use macros for powers-of-10 in fill_3db_frequency_tbl().
2. Change names of gotos.
3. add commas to non-terminal lines.

Changes since v9:
1. Fix white space issues, remove extra lines.
2. Include bits.h and device.h
3. Add commas to non-terminal lines in structs etc.

Changes since v8:
1. Make scale and offset defines inline and remove them.
2. Change dt-binding doc to state interrupt polarity only for DRDY pin.
3. Remove triggered buffer support from this patch series.

Changes since v7:
1. Update MAINTAINERS to show all driver files.
2. Set CONFIGS for buffered support in Kconfig.

Changes since v6:
1. Use interrupt-names property in device tree document.
2. Add triggered buffer support.
3. Use a static table for offset and data registers.
4. Fix coding style issues.
5. move defines from header to c file.

Changes since v5:
1. Used get_unaligned_be24() and  get_unaligned_be16() to parse
acceleration and temperature data. This solves sparse errors and also
make the code more understandable.

Changes since v4:
1. Fix errors reported by sparse.

Changes since v3:
1. Fix errors in yaml DT doc.
2. Change SPDX-License-Identifier to GPL-2.0-only OR BSD-2-Clause

Changes since v2:
1. Add separate DT binding doc in yaml.
2. Use ____cacheline_aligned buffer for regmap_bulk_read/write calls.
3. Make code consistent by using same style in switch case.
4. Use FIELD_PREP in place of custom macros.
5. Make Kconfig description more informative.

Changes since v1:
1. Remove the declarations for static regmap structures from adxl355.h.
This was missed in the v1 and caused errors.
2. Make switch case statements consistent by directly returning from
each case rather than saving the return in a variable.
3. Some coding style changes.

Changes since v0:
1. Move adxl355_hpf_3db_table to adxl355_data structure. This is done to make
sure that each device gets its own table.
2. Make local regmap definitions private to adxl355_core.c.
3. Other minor coding style changes.

Puranjay Mohan (2):
  dt-bindings: iio: accel: Add DT binding doc for ADXL355
  iio: accel: Add driver support for ADXL355

 .../bindings/iio/accel/adi,adxl355.yaml       |  88 +++
 MAINTAINERS                                   |  10 +
 drivers/iio/accel/Kconfig                     |  29 +
 drivers/iio/accel/Makefile                    |   3 +
 drivers/iio/accel/adxl355.h                   |  21 +
 drivers/iio/accel/adxl355_core.c              | 584 ++++++++++++++++++
 drivers/iio/accel/adxl355_i2c.c               |  62 ++
 drivers/iio/accel/adxl355_spi.c               |  65 ++
 8 files changed, 862 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl355.yaml
 create mode 100644 drivers/iio/accel/adxl355.h
 create mode 100644 drivers/iio/accel/adxl355_core.c
 create mode 100644 drivers/iio/accel/adxl355_i2c.c
 create mode 100644 drivers/iio/accel/adxl355_spi.c

Comments

Andy Shevchenko Aug. 11, 2021, 4:01 p.m. UTC | #1

On Wed, Aug 11, 2021 at 10:30 AM Puranjay Mohan <puranjay12@gmail.com> wrote:
>
> Add the dt-bindings and the driver for ADXL355 3-axis MEMS Accelerometer.
>
> Changes since v11:
> 1. Add forward declaration of struct device in header.

> 2. Use defines for power-of-10s.

TWIMC, Wolfram applied patch against units.h to add the SI prefixes:
https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?id=26471d4a6cf8d5d0bd0fb55c7169de7d67cc703a

Puranjay Mohan Aug. 12, 2021, 4:26 a.m. UTC | #2

On Wed, Aug 11, 2021 at 9:32 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Aug 11, 2021 at 10:30 AM Puranjay Mohan <puranjay12@gmail.com> wrote:
> >
> > Add the dt-bindings and the driver for ADXL355 3-axis MEMS Accelerometer.
> >
> > Changes since v11:
> > 1. Add forward declaration of struct device in header.
>
> > 2. Use defines for power-of-10s.
>
> TWIMC, Wolfram applied patch against units.h to add the SI prefixes:
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?id=26471d4a6cf8d5d0bd0fb55c7169de7d67cc703a
>
I will change to this once this patch gets merged.
> --
> With Best Regards,
> Andy Shevchenko