mbox series

[v2,0/4] iio: potentiometer: Add support for DS3502

Message ID 20220214033620.4059-1-jagathjog1996@gmail.com (mailing list archive)
Headers show
Series iio: potentiometer: Add support for DS3502 | expand

Message

Jagath Jog J Feb. 14, 2022, 3:36 a.m. UTC
Add dt-bindings and support for Maxim DS3502 into existing ds1803 driver.
DS3502 is a 7 bit Nonvolatile Digital Potentiometer.

Changes since v1:
1. Fixes the alignment to match the open parenthesis in separate patch
2. Adding available functionality for ds1803 driver in separate patch
3. Moving maxim_potentiometer members into ds1803_cfg structure
4. Droping of the INFO_ENABLE channel type
5. Firmware entry with data is used instead of id->driver_data to
   to retrieve the chip specific data.

Jagath Jog J (4):
  iio: potentiometer: Alignment to match the open parenthesis
  iio: potentiometer: Add available functionality
  iio: potentiometer: Add support for Maxim DS3502
  dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices

 .../devicetree/bindings/trivial-devices.yaml  |   2 +
 drivers/iio/potentiometer/Kconfig             |   6 +-
 drivers/iio/potentiometer/ds1803.c            | 141 +++++++++++++-----
 3 files changed, 106 insertions(+), 43 deletions(-)

Comments

Andy Shevchenko Feb. 14, 2022, 11:33 a.m. UTC | #1
On Mon, Feb 14, 2022 at 5:36 AM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Add dt-bindings and support for Maxim DS3502 into existing ds1803 driver.
> DS3502 is a 7 bit Nonvolatile Digital Potentiometer.

A very good start! A few minor comments to be addressed and one patch
has to be split to at least three.