mbox series

[v4,00/10] iio: sx9324/9360: Add settings for precharge, gain and internal resistor

Message ID 20220429220144.1476049-1-gwendal@chromium.org (mailing list archive)
Headers show
Series iio: sx9324/9360: Add settings for precharge, gain and internal resistor | expand

Message

Gwendal Grignou April 29, 2022, 10:01 p.m. UTC
For Semtech sensors SX9324 and SX9360, allow confugration of the
pre-charge resistor (9324/9360) and internal resistor (9324).

Fix register name spelling mistakes first and set default value properly
for sx9324 internal resistor register.

The 9360 changes are independent from the 9324 changes, but they are
very similar.

Changes since v4:
- Add analog gain setting
- Add missing test when property is not found
- Fix dt-schema errors.

Changes since v3:
- Rename reserved field as _RESERVED_
- Fix invalid string matching with match_string()
- Fix cut and paste error in device tree bindings.

Changes since v2:
- use -ohms instead of -kohms, as ohms is a defined unit in
  dt-schema.git dtschema/schemas/property-units.yaml

Changes sinve v1:
- Add kOhm Unit, add a new patch to fix invalid register setting.

Gwendal Grignou (10):
  iio: sx9324: Fix default precharge internal resistance register
  iio: sx9324: Fix register field spelling
  dt-bindings: iio: sx9324: Add precharge resistor setting
  iio: sx9324: Add precharge internal resistance setting
  dt-bindings: iio: sx9324: Add internal compensation resistor setting
  iio: sx9324: Add Setting for internal compensation resistor
  dt-bindings: iio: sx9324: Add input analog gain
  iio: sx9324: Add Setting for internal analog gain
  dt-bindings: iio: sx9360: Add precharge resistor setting
  iio: sx9360: Add pre-charge resistor setting

 .../iio/proximity/semtech,sx9324.yaml         | 30 +++++++++
 .../iio/proximity/semtech,sx9360.yaml         |  9 +++
 drivers/iio/proximity/sx9324.c                | 66 +++++++++++++++++--
 drivers/iio/proximity/sx9360.c                | 15 ++++-
 4 files changed, 114 insertions(+), 6 deletions(-)

Comments

Jonathan Cameron May 1, 2022, 5:20 p.m. UTC | #1
On Fri, 29 Apr 2022 15:01:34 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:

> For Semtech sensors SX9324 and SX9360, allow confugration of the
> pre-charge resistor (9324/9360) and internal resistor (9324).
> 
> Fix register name spelling mistakes first and set default value properly
> for sx9324 internal resistor register.
> 
> The 9360 changes are independent from the 9324 changes, but they are
> very similar.

Other than the question I raised on the analog gain patch and
the need to leave time for a DT review of the last couple of 
binding patches, this looks good to me.  If it looks like that
might take a while I might pick up the first 6 patches without
waiting for the last 4.

Thanks,

Jonathan

> 
> Changes since v4:
> - Add analog gain setting
> - Add missing test when property is not found
> - Fix dt-schema errors.
> 
> Changes since v3:
> - Rename reserved field as _RESERVED_
> - Fix invalid string matching with match_string()
> - Fix cut and paste error in device tree bindings.
> 
> Changes since v2:
> - use -ohms instead of -kohms, as ohms is a defined unit in
>   dt-schema.git dtschema/schemas/property-units.yaml
> 
> Changes sinve v1:
> - Add kOhm Unit, add a new patch to fix invalid register setting.
> 
> Gwendal Grignou (10):
>   iio: sx9324: Fix default precharge internal resistance register
>   iio: sx9324: Fix register field spelling
>   dt-bindings: iio: sx9324: Add precharge resistor setting
>   iio: sx9324: Add precharge internal resistance setting
>   dt-bindings: iio: sx9324: Add internal compensation resistor setting
>   iio: sx9324: Add Setting for internal compensation resistor
>   dt-bindings: iio: sx9324: Add input analog gain
>   iio: sx9324: Add Setting for internal analog gain
>   dt-bindings: iio: sx9360: Add precharge resistor setting
>   iio: sx9360: Add pre-charge resistor setting
> 
>  .../iio/proximity/semtech,sx9324.yaml         | 30 +++++++++
>  .../iio/proximity/semtech,sx9360.yaml         |  9 +++
>  drivers/iio/proximity/sx9324.c                | 66 +++++++++++++++++--
>  drivers/iio/proximity/sx9360.c                | 15 ++++-
>  4 files changed, 114 insertions(+), 6 deletions(-)
>