mbox series

[0/2] iio: adc: stm32: Fix ADC IRQ handling on STM32F4

Message ID 20220506225617.1774604-1-yannick.brosseau@gmail.com (mailing list archive)
Headers show
Series iio: adc: stm32: Fix ADC IRQ handling on STM32F4 | expand

Message

Yannick Brosseau May 6, 2022, 10:56 p.m. UTC 
Recent changes to the STM32 ADC irq handling broke the STM32F4 platforms
These two patches bring it back to a working state.

Yannick Brosseau (2):
  iio: adc: stm32: Iterate through all ADCs in irq handler
  iio: adc: stm32: Fix check for spurious IRQs on STM32F4

 drivers/iio/adc/stm32-adc-core.c | 7 ++++++-
 drivers/iio/adc/stm32-adc.c      | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)

Comments

Paul Cercueil May 6, 2022, 11:05 p.m. UTC | #1 
Hi Yannick,

Le ven., mai 6 2022 at 18:56:15 -0400, Yannick Brosseau 
<yannick.brosseau@gmail.com> a écrit :
> Recent changes to the STM32 ADC irq handling broke the STM32F4 
> platforms
> These two patches bring it back to a working state.

If the STM32 ADC was broken recently, and these two patches fix it, 
then I'd expect to see a Fixes: tag on both commits and Cc: 
linux-stable.

Cheers,
-Paul

> Yannick Brosseau (2):
>   iio: adc: stm32: Iterate through all ADCs in irq handler
>   iio: adc: stm32: Fix check for spurious IRQs on STM32F4
> 
>  drivers/iio/adc/stm32-adc-core.c | 7 ++++++-
>  drivers/iio/adc/stm32-adc.c      | 9 ++++++---
>  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> --
> 2.36.0
>
Jonathan Cameron May 7, 2022, 1:58 p.m. UTC | #2 
On Sat, 07 May 2022 00:05:00 +0100
Paul Cercueil <paul@crapouillou.net> wrote:

> Hi Yannick,
> 
> Le ven., mai 6 2022 at 18:56:15 -0400, Yannick Brosseau 
> <yannick.brosseau@gmail.com> a écrit :
> > Recent changes to the STM32 ADC irq handling broke the STM32F4 
> > platforms
> > These two patches bring it back to a working state.  
> 
> If the STM32 ADC was broken recently, and these two patches fix it, 
> then I'd expect to see a Fixes: tag on both commits and Cc: 
> linux-stable.

I normally add the Cc: for stable, but don't mind for obvious cases
if patches come in with it already there.

Sometimes the marking can be timing dependent (no point in sending
things to stable if they are going to hit in the same cycle etc)

Absolutely agree on fixes tag though!

Thanks,

Jonathan

> 
> Cheers,
> -Paul
> 
> > Yannick Brosseau (2):
> >   iio: adc: stm32: Iterate through all ADCs in irq handler
> >   iio: adc: stm32: Fix check for spurious IRQs on STM32F4
> > 
> >  drivers/iio/adc/stm32-adc-core.c | 7 ++++++-
> >  drivers/iio/adc/stm32-adc.c      | 9 ++++++---
> >  2 files changed, 12 insertions(+), 4 deletions(-)
> > 
> > --
> > 2.36.0
> >   
> 
>