mbox series

[V9,0/5] iio: accel: sca3300: add compatible for scl3300

Message ID 20220529061853.3044893-1-Qing-wu.Li@leica-geosystems.com.cn (mailing list archive)
Headers show
Series iio: accel: sca3300: add compatible for scl3300 | expand

Message

LI Qingwu May 29, 2022, 6:18 a.m. UTC 
The current driver support sca3300 only, modified to support SCL3300.
Verified with SCL3300 on IMX8MM.

SCL3300 is a three-axis accelerometer sensor with angle output, 
the change adds the support of scl3300 and inclination data output.


Changes in v9: 
 - Rename angle to angle_supported.
 - Delete reg_val &= GENMASK(1, 0), it's redundant.
 - Fix typo of comments.


LI Qingwu (5):
  dt-bindings: iio: accel: sca3300: Document murata,scl3300
  iio: accel: sca3300: add define for temp channel for reuse.
  iio: accel: sca3300: modified to support multi chips
  iio: accel: sca3300: Add support for SCL3300
  iio: accel: sca3300: Add inclination channels

 .../bindings/iio/accel/murata,sca3300.yaml    |   1 +
 drivers/iio/accel/sca3300.c                   | 323 +++++++++++++++---
 2 files changed, 269 insertions(+), 55 deletions(-)

Comments

Tomas Melin May 30, 2022, 9:58 a.m. UTC | #1 
On 29/05/2022 09:18, LI Qingwu wrote:
> The current driver support sca3300 only, modified to support SCL3300.
> Verified with SCL3300 on IMX8MM.
> 
> SCL3300 is a three-axis accelerometer sensor with angle output, 
> the change adds the support of scl3300 and inclination data output.
> 
> 
> Changes in v9: 
>  - Rename angle to angle_supported.
>  - Delete reg_val &= GENMASK(1, 0), it's redundant.
>  - Fix typo of comments.
> 
> 
> LI Qingwu (5):
>   dt-bindings: iio: accel: sca3300: Document murata,scl3300
>   iio: accel: sca3300: add define for temp channel for reuse.
>   iio: accel: sca3300: modified to support multi chips
>   iio: accel: sca3300: Add support for SCL3300
>   iio: accel: sca3300: Add inclination channels
> 
>  .../bindings/iio/accel/murata,sca3300.yaml    |   1 +
>  drivers/iio/accel/sca3300.c                   | 323 +++++++++++++++---
>  2 files changed, 269 insertions(+), 55 deletions(-)
> 

Reviewed-by: Tomas Melin <tomas.melin@vaisala.com>
Jonathan Cameron June 3, 2022, 5:38 p.m. UTC | #2 
On Mon, 30 May 2022 12:58:59 +0300
Tomas Melin <tomas.melin@vaisala.com> wrote:

> On 29/05/2022 09:18, LI Qingwu wrote:
> > The current driver support sca3300 only, modified to support SCL3300.
> > Verified with SCL3300 on IMX8MM.
> > 
> > SCL3300 is a three-axis accelerometer sensor with angle output, 
> > the change adds the support of scl3300 and inclination data output.
> > 
> > 
> > Changes in v9: 
> >  - Rename angle to angle_supported.
> >  - Delete reg_val &= GENMASK(1, 0), it's redundant.
> >  - Fix typo of comments.
> > 
> > 
> > LI Qingwu (5):
> >   dt-bindings: iio: accel: sca3300: Document murata,scl3300
> >   iio: accel: sca3300: add define for temp channel for reuse.
> >   iio: accel: sca3300: modified to support multi chips
> >   iio: accel: sca3300: Add support for SCL3300
> >   iio: accel: sca3300: Add inclination channels
> > 
> >  .../bindings/iio/accel/murata,sca3300.yaml    |   1 +
> >  drivers/iio/accel/sca3300.c                   | 323 +++++++++++++++---
> >  2 files changed, 269 insertions(+), 55 deletions(-)
> >   
> 
> Reviewed-by: Tomas Melin <tomas.melin@vaisala.com>

Series applied to the togreg branch of iio.git and pushed out for now as
testing to let 0-day see if it can find anything we missed.

Thanks,

Jonathan