mbox series

[0/2] iio: Convert some drivers from deprecated UNIVERSAL_DEV_PM_OPS()

Message ID 20220807190414.1039028-1-jic23@kernel.org (mailing list archive)
Headers show
Series iio: Convert some drivers from deprecated UNIVERSAL_DEV_PM_OPS() | expand

Message

Jonathan Cameron Aug. 7, 2022, 7:04 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

During discussions of the new PM macro definitions, it because clear that
UNIVERSAL_DEV_PM_OPS() generally doesn't make much sense as it can lead
to unnecessary work.

For the drivers in this set I've taken a look at how the ops are used
and believe we can just switch to DEFINE_RUNTIME_PM_OPS() which will only
do the suspend if the device is not already runtime suspended.

I'd like some review of these (more than for the straight forward NOP conversions).

Thanks,

Jonathan


Jonathan Cameron (2):
  iio: pressure: icp10100: Switch from UNIVERSAL to
    DEFINE_RUNTIME_DEV_PM_OPS().
  iio: temp: mlx90632: Switch form UNVIVERSAL to
    DEFINE_RUNTIME_DEV_PM_OPS()

 drivers/iio/pressure/icp10100.c    | 10 +++++-----
 drivers/iio/temperature/mlx90632.c | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

Andy Shevchenko Aug. 8, 2022, 9:30 a.m. UTC | #1
On Sun, Aug 7, 2022 at 8:59 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> During discussions of the new PM macro definitions, it because clear that
> UNIVERSAL_DEV_PM_OPS() generally doesn't make much sense as it can lead
> to unnecessary work.
>
> For the drivers in this set I've taken a look at how the ops are used
> and believe we can just switch to DEFINE_RUNTIME_PM_OPS() which will only
> do the suspend if the device is not already runtime suspended.
>
> I'd like some review of these (more than for the straight forward NOP conversions).

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Thanks,
>
> Jonathan
>
>
> Jonathan Cameron (2):
>   iio: pressure: icp10100: Switch from UNIVERSAL to
>     DEFINE_RUNTIME_DEV_PM_OPS().
>   iio: temp: mlx90632: Switch form UNVIVERSAL to
>     DEFINE_RUNTIME_DEV_PM_OPS()
>
>  drivers/iio/pressure/icp10100.c    | 10 +++++-----
>  drivers/iio/temperature/mlx90632.c | 10 +++++-----
>  2 files changed, 10 insertions(+), 10 deletions(-)
>
> --
> 2.37.1
>