| Message ID | 20220815061625.35568-1-marcus.folkesson@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Improve MCP3911 driver | expand |
On 15/08/2022 09:16, Marcus Folkesson wrote: > v5: > - Drop remove function > - Split tx&rx transfers in mcp3911_trigger_handler() > - Moved Kconfig changes to right patch > > v6: > - Go for devm_clk_get_enabled() > - Cosmetic cleanups > - Clarify the description of microchip,data-ready-hiz > Please include the diffstat (format-patch does it for you, but if you prefer to use other tools - it's your job). Best regards, Krzysztof
On Tue, Aug 16, 2022 at 01:22:31PM +0300, Krzysztof Kozlowski wrote: > On 15/08/2022 09:16, Marcus Folkesson wrote: > > v5: > > - Drop remove function > > - Split tx&rx transfers in mcp3911_trigger_handler() > > - Moved Kconfig changes to right patch > > > > v6: > > - Go for devm_clk_get_enabled() > > - Cosmetic cleanups > > - Clarify the description of microchip,data-ready-hiz > > > > Please include the diffstat (format-patch does it for you, but if you > prefer to use other tools - it's your job). I'm sorry, I do not get you. The diffstat is included in the patches, should it be included here as well? /Marcus > > Best regards, > Krzysztof
On 16/08/2022 17:57, Marcus Folkesson wrote: > On Tue, Aug 16, 2022 at 01:22:31PM +0300, Krzysztof Kozlowski wrote: >> On 15/08/2022 09:16, Marcus Folkesson wrote: >>> v5: >>> - Drop remove function >>> - Split tx&rx transfers in mcp3911_trigger_handler() >>> - Moved Kconfig changes to right patch >>> >>> v6: >>> - Go for devm_clk_get_enabled() >>> - Cosmetic cleanups >>> - Clarify the description of microchip,data-ready-hiz >>> >> >> Please include the diffstat (format-patch does it for you, but if you >> prefer to use other tools - it's your job). > > I'm sorry, I do not get you. > The diffstat is included in the patches, should it be included here as > well? Yes, in the cover letter, so when someone partially interested (e.g. me) opens the cover letter, it's easy to notice what files are affected. Again, this is exactly what Git is doing, so you have to on purpose use less-standard process to achieve cover letter without diffstat. Best regards, Krzysztof
On Mon, Aug 15, 2022 at 08:16:16AM +0200, Marcus Folkesson wrote: > This patch series intend to fix bugs and improve functionality of the MCP3911 driver. > The main features added are > - Support for buffers > - Interrupt driven readings > - Support for oversampling ratio > - Support for set scale values (Gain) > > Among the bug fixes, there are changes in the formula for calculate raw value and a fix for mismatch in the devicetree property. > > Another general improvement for the driver is to use managed resources for all allocated resources. > > See patch notes for more specific changes. > > General changes for the series: > > v3: > - Drop Phase patch > - Add Fixes tags for those patches that are fixes > - Move Fixes patches to the beginning of the patchset > > v4: > - Split up devm-cleanup functions > - Cosmetic cleanups > - Add > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > To Kconfig > - Add .endianness = IIO_BE > > v5: > - Drop remove function > - Split tx&rx transfers in mcp3911_trigger_handler() > - Moved Kconfig changes to right patch > > v6: > - Go for devm_clk_get_enabled() > - Cosmetic cleanups > - Clarify the description of microchip,data-ready-hiz > Marcus Folkesson (9): iio: adc: mcp3911: make use of the sign bit iio: adc: mcp3911: correct "microchip,device-addr" property iio: adc: mcp3911: use correct formula for AD conversion iio: adc: mcp3911: use resource-managed version of iio_device_register iio: adc: mcp3911: add support for buffers iio: adc: mcp3911: add support for interrupts dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry iio: adc: mcp3911: add support for oversampling ratio iio: adc: mcp3911: add support to set PGA .../bindings/iio/adc/microchip,mcp3911.yaml | 7 + drivers/iio/adc/Kconfig | 2 + drivers/iio/adc/mcp3911.c | 372 +++++++++++++++--- 3 files changed, 321 insertions(+), 60 deletions(-) > > Best regards, > Marcus Folkesson > >
This patch series intend to fix bugs and improve functionality of the MCP3911 driver. The main features added are - Support for buffers - Interrupt driven readings - Support for oversampling ratio - Support for set scale values (Gain) Among the bug fixes, there are changes in the formula for calculate raw value and a fix for mismatch in the devicetree property. Another general improvement for the driver is to use managed resources for all allocated resources. See patch notes for more specific changes. General changes for the series: v3: - Drop Phase patch - Add Fixes tags for those patches that are fixes - Move Fixes patches to the beginning of the patchset v4: - Split up devm-cleanup functions - Cosmetic cleanups - Add select IIO_BUFFER select IIO_TRIGGERED_BUFFER To Kconfig - Add .endianness = IIO_BE v5: - Drop remove function - Split tx&rx transfers in mcp3911_trigger_handler() - Moved Kconfig changes to right patch v6: - Go for devm_clk_get_enabled() - Cosmetic cleanups - Clarify the description of microchip,data-ready-hiz Best regards, Marcus Folkesson