[v3,0/4] Match data improvements for mcp4725 driver

Message

Biju Das Sept. 3, 2023, 11:55 a.m. UTC

This patch series aims to add match data improvements for mcp4725 driver.

This patch series is only compile tested.

v2->v3:
 * Added struct mcp4725_chip_info with chan_spec and chip_id variable and
   used that as OF/ID table match data.
 * Added variables use_ext_ref_voltage and dac_reg_offset to struct
   mcp4725_chip_info to handle hw differences between mcp4725 and
   mcp4726.
v1->v2:
 * Update commit description with reason for change.

Biju Das (4):
  iio: dac: mcp4725: Replace variable 'id' from struct mcp4725_data
  iio: dac: mcp4725: Use i2c_get_match_data()
  iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info
  iio: dac: mcp4725: Add dac_reg_offset to struct mcp4725_chip_info

 drivers/iio/dac/mcp4725.c | 42 ++++++++++++++++++++++++++-------------
 1 file changed, 28 insertions(+), 14 deletions(-)

Comments

Jonathan Cameron Sept. 3, 2023, 12:15 p.m. UTC | #1

On Sun,  3 Sep 2023 12:55:44 +0100
Biju Das <[e-mail]> wrote:

> This patch series aims to add match data improvements for mcp4725 driver.
> 
> This patch series is only compile tested.
> 
> v2->v3:
>  * Added struct mcp4725_chip_info with chan_spec and chip_id variable and
>    used that as OF/ID table match data.
>  * Added variables use_ext_ref_voltage and dac_reg_offset to struct
>    mcp4725_chip_info to handle hw differences between mcp4725 and
>    mcp4726.
> v1->v2:
>  * Update commit description with reason for change.
> 
> Biju Das (4):
>   iio: dac: mcp4725: Replace variable 'id' from struct mcp4725_data
>   iio: dac: mcp4725: Use i2c_get_match_data()
>   iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info
>   iio: dac: mcp4725: Add dac_reg_offset to struct mcp4725_chip_info
> 
>  drivers/iio/dac/mcp4725.c | 42 ++++++++++++++++++++++++++-------------
>  1 file changed, 28 insertions(+), 14 deletions(-)
> 

I've applied this, but still plenty of time for more comments as I'll only
be pushing it out as a non rebasing tree after rc1.

Thanks,

Jonathan