mbox series

[v2,0/8] iio: ad9467 and axi-adc cleanups

Message ID 20231207-iio-backend-prep-v2-0-a4a33bc4d70e@analog.com (mailing list archive)
Headers show
Series iio: ad9467 and axi-adc cleanups | expand

Message

Nuno Sa via B4 Relay Dec. 7, 2023, 12:39 p.m. UTC
As requested in [1], this is a preparatory series with some basic cleanups for
the ad9467 and adi-axi-adc drivers.

This means that the iio backend series [2] will depend on this one but
hopefully we'll quickly get this one in.

[1]: https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#ma7ed8a58d747e78e1ff2273c2d6cdd11de22f177
[2]: https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#m222f5175273b81dbfe40b7f0daffcdc67d6cb8ff

---
Changes in v2:
- Patch 1.
  * Use IS_ERR_OR_NULL() and PTR_ERR_OR_ZERO();
  * Improved commit message (mention it's inverted polarity).
- Patch 4:
  * Properly allocate enough memory for the scale array;
  * Use devm_kmalloc_array() as we don't need to zero initialize it;
  * Don't multiple by 2 in the for() loop. We just want to go over the
    rows.
 
- Link to v1: https://lore.kernel.org/r/20231205-iio-backend-prep-v1-0-7c9bc18d612b@analog.com

---
Nuno Sa (8):
      iio: adc: ad9467: fix reset gpio handling
      iio: adc: ad9467: don't ignore error codes
      iio: adc: ad9467: add mutex to struct ad9467_state
      iio: adc: ad9467: fix scale setting
      iio: adc: ad9467: use spi_get_device_match_data()
      iio: adc: ad9467: use chip_info variables instead of array
      iio: adc: ad9467: use the more common !val NULL check
      iio: adc: adi-axi-adc: convert to regmap

 drivers/iio/adc/ad9467.c            | 207 +++++++++++++++++++++++-------------
 drivers/iio/adc/adi-axi-adc.c       | 159 ++++++++++++---------------
 include/linux/iio/adc/adi-axi-adc.h |   4 +
 3 files changed, 204 insertions(+), 166 deletions(-)
---
base-commit: 5c8f90655a7bdb6232b2cea6503df16367b11a53
change-id: 20231205-iio-backend-prep-4d96ef364080
--

Thanks!
- Nuno Sá

Comments

Jonathan Cameron Dec. 10, 2023, 11:43 a.m. UTC | #1
On Thu, 07 Dec 2023 13:39:23 +0100
Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:

> As requested in [1], this is a preparatory series with some basic cleanups for
> the ad9467 and adi-axi-adc drivers.
> 
> This means that the iio backend series [2] will depend on this one but
> hopefully we'll quickly get this one in.
> 
> [1]: https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#ma7ed8a58d747e78e1ff2273c2d6cdd11de22f177
> [2]: https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#m222f5175273b81dbfe40b7f0daffcdc67d6cb8ff
> 
Series applied to the togreg branch of iio.git.
Note I haven't marked the fixes for stable, or taken them through the fixes tree.
If you want them backported then please request that after the next merge window

Thanks,

Jonathan

> ---
> Changes in v2:
> - Patch 1.
>   * Use IS_ERR_OR_NULL() and PTR_ERR_OR_ZERO();
>   * Improved commit message (mention it's inverted polarity).
> - Patch 4:
>   * Properly allocate enough memory for the scale array;
>   * Use devm_kmalloc_array() as we don't need to zero initialize it;
>   * Don't multiple by 2 in the for() loop. We just want to go over the
>     rows.
>  
> - Link to v1: https://lore.kernel.org/r/20231205-iio-backend-prep-v1-0-7c9bc18d612b@analog.com
> 
> ---
> Nuno Sa (8):
>       iio: adc: ad9467: fix reset gpio handling
>       iio: adc: ad9467: don't ignore error codes
>       iio: adc: ad9467: add mutex to struct ad9467_state
>       iio: adc: ad9467: fix scale setting
>       iio: adc: ad9467: use spi_get_device_match_data()
>       iio: adc: ad9467: use chip_info variables instead of array
>       iio: adc: ad9467: use the more common !val NULL check
>       iio: adc: adi-axi-adc: convert to regmap
> 
>  drivers/iio/adc/ad9467.c            | 207 +++++++++++++++++++++++-------------
>  drivers/iio/adc/adi-axi-adc.c       | 159 ++++++++++++---------------
>  include/linux/iio/adc/adi-axi-adc.h |   4 +
>  3 files changed, 204 insertions(+), 166 deletions(-)
> ---
> base-commit: 5c8f90655a7bdb6232b2cea6503df16367b11a53
> change-id: 20231205-iio-backend-prep-4d96ef364080
> --
> 
> Thanks!
> - Nuno Sá
>
Nuno Sá Dec. 11, 2023, 9:29 a.m. UTC | #2
On Sun, 2023-12-10 at 11:43 +0000, Jonathan Cameron wrote:
> On Thu, 07 Dec 2023 13:39:23 +0100
> Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:
> 
> > As requested in [1], this is a preparatory series with some basic cleanups
> > for
> > the ad9467 and adi-axi-adc drivers.
> > 
> > This means that the iio backend series [2] will depend on this one but
> > hopefully we'll quickly get this one in.
> > 
> > [1]:
> > https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#ma7ed8a58d747e78e1ff2273c2d6cdd11de22f177
> > [2]:
> > https://lore.kernel.org/linux-iio/20231204144925.4fe9922f@jic23-huawei/T/#m222f5175273b81dbfe40b7f0daffcdc67d6cb8ff
> > 
> Series applied to the togreg branch of iio.git.
> Note I haven't marked the fixes for stable, or taken them through the fixes
> tree.
> If you want them backported then please request that after the next merge
> window
> 

Nope, I think I even mention somewhere that I added the Fixes: tag kind of just
for correctness but up to you to backport them :)

Thanks for applying!
- Nuno Sá