mbox series

[0/2] iio: adc: ad_sigma_delta: misc fixes/improvements

Message ID 20240117-dev_sigma_delta_no_irq_flags-v1-0-db39261592cf@analog.com (mailing list archive)
Headers show
Series iio: adc: ad_sigma_delta: misc fixes/improvements | expand

Message

Nuno Sa Jan. 17, 2024, 12:41 p.m. UTC 
The first patch is for ensuring proper alignment for the sigma_delta
buffers so they can be safely used in DMA context. I'm adding a fixes tag
on it but I'm not sure if there's any urgency in backporting it so up to
you Jonathan :).

The second patch is about allowing the IRQ trigger type to be specified
in firmware.

The sigma delta ADCs have a fun history around this as they initially
forced the IRQF_TRIGGER_LOW flag and then changed to IRQF_TRIGGER_FALLING
as that is what is stated in the datasheet. However, as seen in [1], in
some platforms we can verify that IRQF_TRIGGER_LOW is the one flag that
makes things work.

Apart from the above, and as seen in similar patches, respecting the
firmware configuration is what makes sense. 

[1]: https://lore.kernel.org/all/CAPJMGm4GaSjD6bdqMwCr2EVZGenWzT-nCCf3BMRaD1TSfAabpA@mail.gmail.com/

---
Nuno Sa (2):
      iio: adc: ad_sigma_delta: ensure proper DMA alignment
      iio: adc: ad_sigma_delta: allow overwriting the IRQ flags

 drivers/iio/adc/ad_sigma_delta.c       | 7 ++++++-
 include/linux/iio/adc/ad_sigma_delta.h | 4 +++-
 2 files changed, 9 insertions(+), 2 deletions(-)
---
base-commit: 801590b27bfbdb6721f85e2c3af70e627e52c8d5
change-id: 20240115-dev_sigma_delta_no_irq_flags-2425795e2a00
--

Thanks!
- Nuno Sá