| Message ID | 20240218172731.1023367-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | IIO: Convert DT specific handling over to fwnode | expand |
On Sun, Feb 18, 2024 at 05:27:23PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Andy pointed out that some of the drivers I was using as examples for > "[PATCH 0/8] of: automate of_node_put() - new approach to loops." > should be converted over to fwnode / property.h based handling anyway > at which point the device_for_each_child_node_scoped() handler could be > used instead. He correctly observed that it made more sense to make this > transition directly than to improve the device tree specific handling. > > So this series does that and also some of the other drivers that were still > using device tree specific handling. Note the rcar-adc remains DT > specific due to it directly handling maching against of_device_id tables. > It probably doesn't make sense to move that custom handling over to > fwnode. > > I included one devm_ cleanup patch in here as I was touching the > driver anyway. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you! I have some minor comments, but in general I like this series, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Mon, 19 Feb 2024 14:06:54 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Sun, Feb 18, 2024 at 05:27:23PM +0000, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Andy pointed out that some of the drivers I was using as examples for > > "[PATCH 0/8] of: automate of_node_put() - new approach to loops." > > should be converted over to fwnode / property.h based handling anyway > > at which point the device_for_each_child_node_scoped() handler could be > > used instead. He correctly observed that it made more sense to make this > > transition directly than to improve the device tree specific handling. > > > > So this series does that and also some of the other drivers that were still > > using device tree specific handling. Note the rcar-adc remains DT > > specific due to it directly handling maching against of_device_id tables. > > It probably doesn't make sense to move that custom handling over to > > fwnode. > > > > I included one devm_ cleanup patch in here as I was touching the > > driver anyway. > > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Thank you! > I have some minor comments, but in general I like this series, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Applied with various suggestions acted on (even if that is asking Nuno to send a patch to tidy them up at a later date :) Applied to the togreg branch of iio.git and pushed out as testing to see what I missed. Thanks, Jonathan
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> Andy pointed out that some of the drivers I was using as examples for "[PATCH 0/8] of: automate of_node_put() - new approach to loops." should be converted over to fwnode / property.h based handling anyway at which point the device_for_each_child_node_scoped() handler could be used instead. He correctly observed that it made more sense to make this transition directly than to improve the device tree specific handling. So this series does that and also some of the other drivers that were still using device tree specific handling. Note the rcar-adc remains DT specific due to it directly handling maching against of_device_id tables. It probably doesn't make sense to move that custom handling over to fwnode. I included one devm_ cleanup patch in here as I was touching the driver anyway. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Depends on: [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling. https://lore.kernel.org/linux-iio/20240217164249.921878-1-jic23@kernel.org/T/#t Jonathan Cameron (8): iio: adc: fsl-imx25-gcq: Switch from of specific handing to fwnode based. iio: adc: fsl-imx25-gcq: Use devm_* and dev_err_probe() to simplify probe iio: adc: ad7124: Switch from of specific to fwnode based property handling iio: adc: ad7292: Switch from of specific to fwnode property handling iio: adc: ad7192: Convert from of specific to fwnode property handling iio: accel: mma8452: Switch from of specific to fwnode property handling. iio: accel: fxls8962af: Switch from of specific to fwnode based properties. iio: adc: hx711: Switch from of specific to fwnode property handling. drivers/iio/accel/fxls8962af-core.c | 10 +- drivers/iio/accel/mma8452.c | 6 +- drivers/iio/adc/ad7124.c | 55 +++++------ drivers/iio/adc/ad7192.c | 38 ++++---- drivers/iio/adc/ad7292.c | 13 ++- drivers/iio/adc/fsl-imx25-gcq.c | 140 +++++++++++----------------- drivers/iio/adc/hx711.c | 5 +- 7 files changed, 115 insertions(+), 152 deletions(-)