mbox series

[0/8] IIO: Drop incorrect includes of linux/of.h

Message ID 20240218173323.1023703-1-jic23@kernel.org (mailing list archive)
Headers show
Series IIO: Drop incorrect includes of linux/of.h | expand

Message

Jonathan Cameron Feb. 18, 2024, 5:33 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

These were false positives when I was looking at which drivers
should be converted over to fwnode based handling from
linux/property.h

None of them use anything defined in linux/of.h, so drop the include
and include more specific headers (mostly linux/mod_devicetable.h)
instead.

Jonathan Cameron (8):
  iio: light: vl6180: Drop unused linux/of.h include
  iio: light: al3320a: Drop unused linux/of.h include
  iio: light: al3010: Switch from linux/of.h to linux/mod_devicetable.h
  iio: adc: ads8688: Switch to mod_devicetable.h for struct of_device_id
    definition
  iio: accel: adxl372: Switch from linux/of.h to linux/mod_devicetable.h
  iio: accel: bma180: Switch from linux/of.h to linux/mod_devicetable.h
  iio: accel: kxsd9: Switch from linux/of.h to linux/mod_devicetable.h
  iio: dac: mcp4821: Switch to including mod_devicetable.h for struct
    of_device_id definition.

 drivers/iio/accel/adxl372_spi.c | 2 +-
 drivers/iio/accel/bma180.c      | 2 +-
 drivers/iio/accel/kxsd9-spi.c   | 2 +-
 drivers/iio/adc/ti-ads8688.c    | 2 +-
 drivers/iio/dac/mcp4821.c       | 2 +-
 drivers/iio/light/al3010.c      | 2 +-
 drivers/iio/light/al3320a.c     | 1 -
 drivers/iio/light/vl6180.c      | 1 -
 8 files changed, 6 insertions(+), 8 deletions(-)

Comments

Nuno Sá Feb. 19, 2024, 9:20 a.m. UTC | #1
On Sun, 2024-02-18 at 17:33 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> These were false positives when I was looking at which drivers
> should be converted over to fwnode based handling from
> linux/property.h
> 
> None of them use anything defined in linux/of.h, so drop the include
> and include more specific headers (mostly linux/mod_devicetable.h)
> instead.
> 
> Jonathan Cameron (8):
>   iio: light: vl6180: Drop unused linux/of.h include
>   iio: light: al3320a: Drop unused linux/of.h include
>   iio: light: al3010: Switch from linux/of.h to linux/mod_devicetable.h
>   iio: adc: ads8688: Switch to mod_devicetable.h for struct of_device_id
>     definition
>   iio: accel: adxl372: Switch from linux/of.h to linux/mod_devicetable.h
>   iio: accel: bma180: Switch from linux/of.h to linux/mod_devicetable.h
>   iio: accel: kxsd9: Switch from linux/of.h to linux/mod_devicetable.h
>   iio: dac: mcp4821: Switch to including mod_devicetable.h for struct
>     of_device_id definition.
> 
>  drivers/iio/accel/adxl372_spi.c | 2 +-
>  drivers/iio/accel/bma180.c      | 2 +-
>  drivers/iio/accel/kxsd9-spi.c   | 2 +-
>  drivers/iio/adc/ti-ads8688.c    | 2 +-
>  drivers/iio/dac/mcp4821.c       | 2 +-
>  drivers/iio/light/al3010.c      | 2 +-
>  drivers/iio/light/al3320a.c     | 1 -
>  drivers/iio/light/vl6180.c      | 1 -
>  8 files changed, 6 insertions(+), 8 deletions(-)
> 

Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Andy Shevchenko Feb. 19, 2024, 12:24 p.m. UTC | #2
On Sun, Feb 18, 2024 at 05:33:15PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> These were false positives when I was looking at which drivers
> should be converted over to fwnode based handling from
> linux/property.h
> 
> None of them use anything defined in linux/of.h, so drop the include
> and include more specific headers (mostly linux/mod_devicetable.h)
> instead.

Simple and important one (makes me not look into unrelated code),
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Jonathan Cameron Feb. 24, 2024, 3:57 p.m. UTC | #3
On Mon, 19 Feb 2024 14:24:29 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sun, Feb 18, 2024 at 05:33:15PM +0000, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > These were false positives when I was looking at which drivers
> > should be converted over to fwnode based handling from
> > linux/property.h
> > 
> > None of them use anything defined in linux/of.h, so drop the include
> > and include more specific headers (mostly linux/mod_devicetable.h)
> > instead.  
> 
> Simple and important one (makes me not look into unrelated code),
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 

Applied.