From patchwork Wed Jun 19 12:20:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramona Alexandra Nechita X-Patchwork-Id: 13703784 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75ADC1422C1; Wed, 19 Jun 2024 12:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718799743; cv=none; b=CAnFz9yiY0M88q08/VeheCLVT0Zps7oElmulvo3LbaqUQU6OZvnCCxGcJX1zJZx1rL9L2DXPCzfIvV4tApDd4RgjhWhajttSJYZyHETNfGuvBhEkxvdF9EMfzLKBq6zQY8RfFQNX4CWNlOXrMAjoI0EIwYImy6GPeTsfrCqykf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718799743; c=relaxed/simple; bh=Olzzvp24AOC4T+V7DJiEH5HUqYnKd+8BcbBEFc09ZE0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=VSiTrzUJ+szfKe52l0tCQk0imbWRvjsooOsTv2sAh3pYSWJ8Wv+nPXybTVXwwWk2g+NAzGMksjJx4DuppPq4PxPhOLPGc20hsRE/qDffSE88B0zTRjwOMM074QJQ79j068SUwSw08mgERRBETUTO26i2VYeNndfnTzwqRyHnsXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=HZxyltUm; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="HZxyltUm" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JBHNEP001428; Wed, 19 Jun 2024 08:21:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=DKIM; bh=vNRa5Oiplrn2Xgjadf1n6RmThiC 4FkAUT3lbnFrTe1s=; b=HZxyltUmGX8KKUc5FK1K2p5e+IZHgBoi2b1CTFHOe9f 6MT3ai9cZbplj/3RUFxaLPZKPrHd1PcFRLBiGNFnLTkbjhPCMen7zszstTyvwrbm fHE6SnmkQ5peMQDqPSh4yYnlCtV0TJ9tnaP1HftcYrDi5Rac9DMQuA1afEiKd9Iv dH5Dw3AGQjaVzJkJqa+VYLg6NVuLW64ub4tZMm5K7EV9fVE1pOzm2GPAN5D249/J YR08RqP3AbPLhbsKyKU1C7/1QloJgG238pBDUNx0rZSRw6YgHA/QhaHZO2s4iNb7 ZBdIfvpQXrjFN1yKFyXrg9Q/BaI2RRQR3DJ9GHYqqUQ== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 3yut929709-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 08:21:53 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 45JCLqV7057202 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 19 Jun 2024 08:21:52 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 19 Jun 2024 08:21:51 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 19 Jun 2024 08:21:51 -0400 Received: from HYB-hYN1yfF7zRm.ad.analog.com (HYB-hYN1yfF7zRm.ad.analog.com [10.48.65.166]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 45JCLWw9017121; Wed, 19 Jun 2024 08:21:34 -0400 From: Ramona Alexandra Nechita To: CC: Ramona Alexandra Nechita , Jonathan Cameron , Lars-Peter Clausen , Cosmin Tanislav , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , Nuno Sa , Marius Cristea , Marcelo Schmitt , Maksim Kiselev , Liam Beguin , Ivan Mikhaylov , Marcus Folkesson , Lee Jones , Mike Looijmans , Okan Sahin , , Subject: [PATCH v3 0/3] ad777x driver addressing patch comments Date: Wed, 19 Jun 2024 15:20:43 +0300 Message-ID: <20240619122105.22642-1-ramona.nechita@analog.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: n3K_sUnCP5GZdzH7d5N7gYGkpEXGehFx X-Proofpoint-ORIG-GUID: n3K_sUnCP5GZdzH7d5N7gYGkpEXGehFx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 suspectscore=0 impostorscore=0 malwarescore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190092 This patch series is sent to address the comments received with regards to the ad7779 driver patch: v2-0001-drivers-iio-adc-add-support-for-ad777x-family.patch, as well as the dt-bindings patch: v3-0001-dt-bindings-iio-adc-add-a7779-doc.patch. The patches were initially sent separated, this has now been corrected with this patch series, along with soeme other issues such as the cover letter and author. The changes in the series: v3: * drop spi-max-frequency from yaml and fix indent * separate ABI doc into different patch, drop ad4130 ABI doc file and combine the filter_mode/type properties in the sysfs-bus-iio file * update Kconfig help section for the driver * update driver commit message * drop crc_enabled and check crc by default on all regs except GEN_ERR_REG_1_EN * rename from "ad777x_*" to "ad7779_*" * switch from kfifo to triggered buffer and send w/timestamp * switched spidata_rx/tx buffer data type to u8 and declared channels as IIO_BE * switched to fsleep and added comments for each of them * changed "____cacheline_aligned" to "__aligned(IIO_DMA_MINALIGN)" * fixed allignments and removed redundant variables * removed local update_scan_mode in favor of iio active_scan_mask * requested trigger as NO_AUTOEN and it is enabled/disabled only in preenable/postdisable functions * removed separate ad777x_register function and moved the code in probe * switched to get_clk_enabled * check for irq earlier in probe * misc code style / format changes, as suggested Ramona Alexandra Nechita (3): dt-bindings: iio: adc: add a7779 doc Documentation: ABI: added filter mode doc in sysfs-bus-iio drivers: iio: adc: add support for ad777x family Documentation/ABI/testing/sysfs-bus-iio | 7 + .../ABI/testing/sysfs-bus-iio-adc-ad4130 | 46 - .../bindings/iio/adc/adi,ad7779.yaml | 84 ++ drivers/iio/adc/Kconfig | 11 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/ad7779.c | 936 ++++++++++++++++++ 6 files changed, 1039 insertions(+), 46 deletions(-) delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7779.yaml create mode 100644 drivers/iio/adc/ad7779.c