mbox series

[V3,0/2] Add support for Awinic SAR sensor

Message ID 20240712113200.2468249-1-wangshuaijie@awinic.com (mailing list archive)
Headers show
Series Add support for Awinic SAR sensor | expand

Message

wangshuaijie@awinic.com July 12, 2024, 11:31 a.m. UTC
From: shuaijie wang <wangshuaijie@awinic.com>

Add drivers that support Awinic SAR (Specific Absorption Rate)
sensors to the Linux kernel.

The AW9610X series and AW963XX series are high-sensitivity
capacitive proximity detection sensors.

This device detects human proximity and assists electronic devices
in reducing SAR to pass SAR related certifications.

The device reduces RF power and reduces harm when detecting human proximity.
Increase power and improve signal quality when the human body is far away.

This patch implements device initialization, registration,
I/O operation handling and interrupt handling, and passed basic testing.

shuaijie wang (2):
  dt-bindings: iio: Add YAML to Awinic proximity sensor
  Add support for Awinic proximity sensor

 .../iio/proximity/awinic,aw96xxx.yaml         |  127 ++
 drivers/iio/proximity/Kconfig                 |   10 +
 drivers/iio/proximity/Makefile                |    2 +
 drivers/iio/proximity/aw9610x.c               | 1150 ++++++++++
 drivers/iio/proximity/aw963xx.c               | 1371 ++++++++++++
 drivers/iio/proximity/aw_sar.c                | 1850 +++++++++++++++++
 drivers/iio/proximity/aw_sar.h                |   23 +
 drivers/iio/proximity/aw_sar_comm_interface.c |  550 +++++
 drivers/iio/proximity/aw_sar_comm_interface.h |  172 ++
 drivers/iio/proximity/aw_sar_type.h           |  371 ++++
 10 files changed, 5626 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml
 create mode 100644 drivers/iio/proximity/aw9610x.c
 create mode 100644 drivers/iio/proximity/aw963xx.c
 create mode 100644 drivers/iio/proximity/aw_sar.c
 create mode 100644 drivers/iio/proximity/aw_sar.h
 create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.c
 create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.h
 create mode 100644 drivers/iio/proximity/aw_sar_type.h


base-commit: 43db1e03c086ed20cc75808d3f45e780ec4ca26e

Comments

Waqar Hameed July 12, 2024, 11:49 a.m. UTC | #1
On Fri, Jul 12, 2024 at 11:31 +0000 wangshuaijie@awinic.com wrote:

> From: shuaijie wang <wangshuaijie@awinic.com>
>
> Add drivers that support Awinic SAR (Specific Absorption Rate)
> sensors to the Linux kernel.
>
> The AW9610X series and AW963XX series are high-sensitivity
> capacitive proximity detection sensors.
>
> This device detects human proximity and assists electronic devices
> in reducing SAR to pass SAR related certifications.
>
> The device reduces RF power and reduces harm when detecting human proximity.
> Increase power and improve signal quality when the human body is far away.
>
> This patch implements device initialization, registration,
> I/O operation handling and interrupt handling, and passed basic testing.
>
> shuaijie wang (2):
>   dt-bindings: iio: Add YAML to Awinic proximity sensor
>   Add support for Awinic proximity sensor
>
>  .../iio/proximity/awinic,aw96xxx.yaml         |  127 ++
>  drivers/iio/proximity/Kconfig                 |   10 +
>  drivers/iio/proximity/Makefile                |    2 +
>  drivers/iio/proximity/aw9610x.c               | 1150 ++++++++++
>  drivers/iio/proximity/aw963xx.c               | 1371 ++++++++++++
>  drivers/iio/proximity/aw_sar.c                | 1850 +++++++++++++++++
>  drivers/iio/proximity/aw_sar.h                |   23 +
>  drivers/iio/proximity/aw_sar_comm_interface.c |  550 +++++
>  drivers/iio/proximity/aw_sar_comm_interface.h |  172 ++
>  drivers/iio/proximity/aw_sar_type.h           |  371 ++++
>  10 files changed, 5626 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml
>  create mode 100644 drivers/iio/proximity/aw9610x.c
>  create mode 100644 drivers/iio/proximity/aw963xx.c
>  create mode 100644 drivers/iio/proximity/aw_sar.c
>  create mode 100644 drivers/iio/proximity/aw_sar.h
>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.c
>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.h
>  create mode 100644 drivers/iio/proximity/aw_sar_type.h
>
>
> base-commit: 43db1e03c086ed20cc75808d3f45e780ec4ca26e

This is version 3, but I cannot see a description of the incremental
changes between the versions (or links) in this cover letter. It will
therefore make it harder to review...

It also looks like the _actual_ commit messages in the patch series have
some kind of description of the changes from previous versions. That is
also not correct. Please read
https://docs.kernel.org/process/submitting-patches.html#respond-to-review-comments
and
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
wangshuaijie@awinic.com July 25, 2024, 12:48 p.m. UTC | #2
On Fri, 12 Jul 2024 13:49:28 +0200, waqar.hameed@axis.com wrote:
>On Fri, Jul 12, 2024 at 11:31 +0000 wangshuaijie@awinic.com wrote:
>
>> From: shuaijie wang <wangshuaijie@awinic.com>
>>
>> Add drivers that support Awinic SAR (Specific Absorption Rate)
>> sensors to the Linux kernel.
>>
>> The AW9610X series and AW963XX series are high-sensitivity
>> capacitive proximity detection sensors.
>>
>> This device detects human proximity and assists electronic devices
>> in reducing SAR to pass SAR related certifications.
>>
>> The device reduces RF power and reduces harm when detecting human proximity.
>> Increase power and improve signal quality when the human body is far away.
>>
>> This patch implements device initialization, registration,
>> I/O operation handling and interrupt handling, and passed basic testing.
>>
>> shuaijie wang (2):
>>   dt-bindings: iio: Add YAML to Awinic proximity sensor
>>   Add support for Awinic proximity sensor
>>
>>  .../iio/proximity/awinic,aw96xxx.yaml         |  127 ++
>>  drivers/iio/proximity/Kconfig                 |   10 +
>>  drivers/iio/proximity/Makefile                |    2 +
>>  drivers/iio/proximity/aw9610x.c               | 1150 ++++++++++
>>  drivers/iio/proximity/aw963xx.c               | 1371 ++++++++++++
>>  drivers/iio/proximity/aw_sar.c                | 1850 +++++++++++++++++
>>  drivers/iio/proximity/aw_sar.h                |   23 +
>>  drivers/iio/proximity/aw_sar_comm_interface.c |  550 +++++
>>  drivers/iio/proximity/aw_sar_comm_interface.h |  172 ++
>>  drivers/iio/proximity/aw_sar_type.h           |  371 ++++
>>  10 files changed, 5626 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml
>>  create mode 100644 drivers/iio/proximity/aw9610x.c
>>  create mode 100644 drivers/iio/proximity/aw963xx.c
>>  create mode 100644 drivers/iio/proximity/aw_sar.c
>>  create mode 100644 drivers/iio/proximity/aw_sar.h
>>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.c
>>  create mode 100644 drivers/iio/proximity/aw_sar_comm_interface.h
>>  create mode 100644 drivers/iio/proximity/aw_sar_type.h
>>
>>
>> base-commit: 43db1e03c086ed20cc75808d3f45e780ec4ca26e
>
>This is version 3, but I cannot see a description of the incremental
>changes between the versions (or links) in this cover letter. It will
>therefore make it harder to review...
>
>It also looks like the _actual_ commit messages in the patch series have
>some kind of description of the changes from previous versions. That is
>also not correct. Please read
>https://docs.kernel.org/process/submitting-patches.html#respond-to-review-comments
>and
>https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

Thank you for taking the time to reply to my email. You're right,
I did not do a good job of keeping track of the version update records.
I will include relevant change logs in the next version.

Kind regards,
Wang Shuaijie