| Message ID | 20240727-stk3310-v4-0-02497b1407ba@disroot.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: light: stk3310: stk3013 support | expand |
On Sat, 27 Jul 2024 00:23:30 +0530 Kaustabh Chakraborty <kauschluss@disroot.org> wrote: > STK3013 is a part manufactured by Sensortek which is marketed as a [1] > "Proximity Sensor". This part is available in several consumer mobile > devices, including, but not limited to, Samsung Galaxy J7 Prime and > Samsung Galaxy A2 Core. > > The existing ambient light sensor seemed suitable for this chip, and on > enabling the driver, it was discovered that these "Proximity Sensors" had > ambient light sensing capabilities as well. > > The downstream kernel driver shipped with this phone by Samsung [2] exposes > a sysfs interface for proximity sensing, but leaves out the light sensing > features, hence there's no such functionality in userspace. > > The following patch series aims to add support for STK3013 as an > ambient light/proximity sensor. > > [1] https://www.sensortek.com.tw/index.php/en/products/optical-sensor/ > [2] https://github.com/samsungexynos7870/android_kernel_samsung_exynos7870/blob/master/drivers/sensors/stk3013.c Series LGTM. I'll leave it on list for a few more days though for other review to come in. Thanks, Jonathan
On Sun, 28 Jul 2024 18:05:41 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Sat, 27 Jul 2024 00:23:30 +0530 > Kaustabh Chakraborty <kauschluss@disroot.org> wrote: > > > STK3013 is a part manufactured by Sensortek which is marketed as a [1] > > "Proximity Sensor". This part is available in several consumer mobile > > devices, including, but not limited to, Samsung Galaxy J7 Prime and > > Samsung Galaxy A2 Core. > > > > The existing ambient light sensor seemed suitable for this chip, and on > > enabling the driver, it was discovered that these "Proximity Sensors" had > > ambient light sensing capabilities as well. > > > > The downstream kernel driver shipped with this phone by Samsung [2] exposes > > a sysfs interface for proximity sensing, but leaves out the light sensing > > features, hence there's no such functionality in userspace. > > > > The following patch series aims to add support for STK3013 as an > > ambient light/proximity sensor. > > > > [1] https://www.sensortek.com.tw/index.php/en/products/optical-sensor/ > > [2] https://github.com/samsungexynos7870/android_kernel_samsung_exynos7870/blob/master/drivers/sensors/stk3013.c > Series LGTM. I'll leave it on list for a few more days though for other > review to come in. > > Thanks, > > Jonathan > Applied and initially pushed out as testing for 0-day to take a first look at this. Thanks, Jonathan
STK3013 is a part manufactured by Sensortek which is marketed as a [1] "Proximity Sensor". This part is available in several consumer mobile devices, including, but not limited to, Samsung Galaxy J7 Prime and Samsung Galaxy A2 Core. The existing ambient light sensor seemed suitable for this chip, and on enabling the driver, it was discovered that these "Proximity Sensors" had ambient light sensing capabilities as well. The downstream kernel driver shipped with this phone by Samsung [2] exposes a sysfs interface for proximity sensing, but leaves out the light sensing features, hence there's no such functionality in userspace. The following patch series aims to add support for STK3013 as an ambient light/proximity sensor. [1] https://www.sensortek.com.tw/index.php/en/products/optical-sensor/ [2] https://github.com/samsungexynos7870/android_kernel_samsung_exynos7870/blob/master/drivers/sensors/stk3013.c Changes in v4: - fixed incorrect indentation in doc - Link to v3: https://lore.kernel.org/r/20240721-stk3310-v3-0-98fcb6f551a1@disroot.org Changes in v3: - added a cover letter to the patch series - added stk3310 as a fallback compatible - Link to v2: https://lore.kernel.org/r/20240712152417.97726-1-kauschluss@disroot.org Changes in v2: - added a commit to relax unknown chipid warning - missed "v2" in patches - Link to v1: https://lore.kernel.org/r/20240625165122.231182-1-kauschluss@disroot.org Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- Kaustabh Chakraborty (3): iio: light: stk3310: relax chipid check warning iio: light: stk3310: add support for stk3013 dt-bindings: iio: light: stk33xx: add compatible for stk3013 Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 13 +++++++++---- drivers/iio/light/stk3310.c | 7 ++++++- 2 files changed, 15 insertions(+), 5 deletions(-) --- base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371 change-id: 20240714-stk3310-658f6f34a798 Best regards,