[v2,0/2] iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig

Message

Javier Carrasco Oct. 7, 2024, 8:06 p.m. UTC

This series adds some missing selects in the Kconfig entry for the
following drivers:
- ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
- adf4377 (REGMAP_SPI)
- admv4420 (REMGAP_SPI)
- ada4250 (REGMAP_SPI)
- ad4770r (REGMAP_SPI)
- ltc1660 (REGMAP_SPI)
- stm32-dac-core (REGMAP_MMIO)

Usually you will not notice the missing dependencies, but tiny
config files where those drivers are include will lead to multiple
errors when compiling and linking.

The issue was found while compiling the ad2s1210, and then I looked for
other cases where REGMAP was missing.

Signed-off-by: Javier Carrasco <[e-mail]>
---
Changes in v2:
- rebase onto iio/fixes-togreg to drop applied patches.
- Split [4/8] and extend the code formatting to adrf6780.
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Javier Carrasco (2):
      iio: frequency: {admv4420,adrf6780}: format Kconfig entries
      iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig

 drivers/iio/frequency/Kconfig | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)
---
base-commit: ccf9af8b0dadd0aecc24503ef289cbc178208418
change-id: 20241003-ad2s1210-select-a0a73a48038a

Best regards,

Comments

Jonathan Cameron Oct. 10, 2024, 6:29 p.m. UTC | #1

On Mon, 07 Oct 2024 22:06:37 +0200
Javier Carrasco <[e-mail]> wrote:

> This series adds some missing selects in the Kconfig entry for the
> following drivers:
> - ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
> - adf4377 (REGMAP_SPI)
> - admv4420 (REMGAP_SPI)
> - ada4250 (REGMAP_SPI)
> - ad4770r (REGMAP_SPI)
> - ltc1660 (REGMAP_SPI)
> - stm32-dac-core (REGMAP_MMIO)
> 
> Usually you will not notice the missing dependencies, but tiny
> config files where those drivers are include will lead to multiple
> errors when compiling and linking.
> 
> The issue was found while compiling the ad2s1210, and then I looked for
> other cases where REGMAP was missing.
> 
> Signed-off-by: Javier Carrasco <[e-mail]>
This is a pain. I was going to just flip the order of these, but turns
out that not only was it spaces rather than tabs but there weren't
even the right number of spaces.  As such I can't just have a mix
briefly and fix it up once I can take the white space patch.

Ah well, it's not that large to have as a precursor to a fix.
Applied both patches to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
> Changes in v2:
> - rebase onto iio/fixes-togreg to drop applied patches.
> - Split [4/8] and extend the code formatting to adrf6780.
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Javier Carrasco (2):
>       iio: frequency: {admv4420,adrf6780}: format Kconfig entries
>       iio: frequency: admv4420: fix missing select REMAP_SPI in Kconfig
> 
>  drivers/iio/frequency/Kconfig | 33 +++++++++++++++++----------------
>  1 file changed, 17 insertions(+), 16 deletions(-)
> ---
> base-commit: ccf9af8b0dadd0aecc24503ef289cbc178208418
> change-id: 20241003-ad2s1210-select-a0a73a48038a
> 
> Best regards,