mbox series

[v4,0/3] iio: light: add al3000a als support

Message ID 20250217140336.107476-1-clamor95@gmail.com (mailing list archive)
Headers show
Series iio: light: add al3000a als support | expand

Message

Svyatoslav Ryhel Feb. 17, 2025, 2:03 p.m. UTC
AL3000a is an illuminance sensor found in ASUS TF101 tablet.

---
Changes on switching from v3 to v4:
- return write function directly
- clean up and fix i2c_device_id

Changes on switching from v2 to v3:
- droped linux/iio/sysfs.h
- set driver name directly
- switched to IIO_CHAN_INFO_PROCESSED
- split al3000a_set_pwr into 2 functions
- added i2c_device_id
- improved code formatting 

Changes on switching from v1 to v2:
- sort compatible alphabetically in schema
- clarify commit descriptions
- convert to use regmap
- arrangle lux conversion table in rows of 8
- add more used headers
- improve code formatting 
---

Svyatoslav Ryhel (3):
  dt-bindings: iio: light: al3010: add al3000a support
  iio: light: Add support for AL3000a illuminance sensor
  ARM: tegra: tf101: Add al3000a illuminance sensor node

 .../bindings/iio/light/dynaimage,al3010.yaml  |   6 +-
 .../boot/dts/nvidia/tegra20-asus-tf101.dts    |  11 +
 drivers/iio/light/Kconfig                     |  10 +
 drivers/iio/light/Makefile                    |   1 +
 drivers/iio/light/al3000a.c                   | 209 ++++++++++++++++++
 5 files changed, 235 insertions(+), 2 deletions(-)
 create mode 100644 drivers/iio/light/al3000a.c

Comments

Jonathan Cameron Feb. 17, 2025, 2:30 p.m. UTC | #1
On Mon, 17 Feb 2025 16:03:33 +0200
Svyatoslav Ryhel <clamor95@gmail.com> wrote:

> AL3000a is an illuminance sensor found in ASUS TF101 tablet.
Hi Svyatoslav,

Just a small request.  Please reduce rate of sending new versions.
That tends to give time for discussions on earlier versions to progress
and for more reviewers to see the current version.

I'd suggest at least 3-4 days between versions.  It's great to
responsive to reviewers of course!

Jonathan


> 
> ---
> Changes on switching from v3 to v4:
> - return write function directly
> - clean up and fix i2c_device_id
> 
> Changes on switching from v2 to v3:
> - droped linux/iio/sysfs.h
> - set driver name directly
> - switched to IIO_CHAN_INFO_PROCESSED
> - split al3000a_set_pwr into 2 functions
> - added i2c_device_id
> - improved code formatting 
> 
> Changes on switching from v1 to v2:
> - sort compatible alphabetically in schema
> - clarify commit descriptions
> - convert to use regmap
> - arrangle lux conversion table in rows of 8
> - add more used headers
> - improve code formatting 
> ---
> 
> Svyatoslav Ryhel (3):
>   dt-bindings: iio: light: al3010: add al3000a support
>   iio: light: Add support for AL3000a illuminance sensor
>   ARM: tegra: tf101: Add al3000a illuminance sensor node
> 
>  .../bindings/iio/light/dynaimage,al3010.yaml  |   6 +-
>  .../boot/dts/nvidia/tegra20-asus-tf101.dts    |  11 +
>  drivers/iio/light/Kconfig                     |  10 +
>  drivers/iio/light/Makefile                    |   1 +
>  drivers/iio/light/al3000a.c                   | 209 ++++++++++++++++++
>  5 files changed, 235 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/iio/light/al3000a.c
>
Svyatoslav Ryhel Feb. 17, 2025, 2:33 p.m. UTC | #2
пн, 17 лют. 2025 р. о 16:30 Jonathan Cameron <jic23@kernel.org> пише:
>
> On Mon, 17 Feb 2025 16:03:33 +0200
> Svyatoslav Ryhel <clamor95@gmail.com> wrote:
>
> > AL3000a is an illuminance sensor found in ASUS TF101 tablet.
> Hi Svyatoslav,
>
> Just a small request.  Please reduce rate of sending new versions.
> That tends to give time for discussions on earlier versions to progress
> and for more reviewers to see the current version.
>
> I'd suggest at least 3-4 days between versions.  It's great to
> responsive to reviewers of course!
>
> Jonathan
>
>

Once you are satisfied with amount of time patch will hang, let me
know, I will upload new version. Thank you.

> >
> > ---
> > Changes on switching from v3 to v4:
> > - return write function directly
> > - clean up and fix i2c_device_id
> >
> > Changes on switching from v2 to v3:
> > - droped linux/iio/sysfs.h
> > - set driver name directly
> > - switched to IIO_CHAN_INFO_PROCESSED
> > - split al3000a_set_pwr into 2 functions
> > - added i2c_device_id
> > - improved code formatting
> >
> > Changes on switching from v1 to v2:
> > - sort compatible alphabetically in schema
> > - clarify commit descriptions
> > - convert to use regmap
> > - arrangle lux conversion table in rows of 8
> > - add more used headers
> > - improve code formatting
> > ---
> >
> > Svyatoslav Ryhel (3):
> >   dt-bindings: iio: light: al3010: add al3000a support
> >   iio: light: Add support for AL3000a illuminance sensor
> >   ARM: tegra: tf101: Add al3000a illuminance sensor node
> >
> >  .../bindings/iio/light/dynaimage,al3010.yaml  |   6 +-
> >  .../boot/dts/nvidia/tegra20-asus-tf101.dts    |  11 +
> >  drivers/iio/light/Kconfig                     |  10 +
> >  drivers/iio/light/Makefile                    |   1 +
> >  drivers/iio/light/al3000a.c                   | 209 ++++++++++++++++++
> >  5 files changed, 235 insertions(+), 2 deletions(-)
> >  create mode 100644 drivers/iio/light/al3000a.c
> >
>