| Message ID | cover.1676661174.git.mehdi.djait.k@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: accel: kionix-kx022a: Timestamp minor fix | expand |
Thanks again Mehdi. It's great to have this fixed :) On 2/17/23 21:19, Mehdi Djait wrote: > As discussed in [1] here is a patch to get the timestamp in the > trigger handler from the driver's private data > > [1] https://lore.kernel.org/linux-iio/Y+%2FLpcc0Wa2VGsGO@carbian/T/#mec923c14d1324ffabfa88dde225eeb227005b48f > By the way, I don't think a cover-letter is required for single patches. You can usually put the relevant information in the commit message. Additionally, if there is some questions, suggestions or other relevant bits you wish to say - but don't want to include in commit logs - you can usually place them in the patch mail directly after the first "---" Eg: <commit message> <Signed-off-by and other tags> --- Here we can add a note / request if required. drivers/iio/accel/kionix-kx022a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c index f866859855cd..1c3a72380fb8 100644 --- a/drivers/iio/accel/kionix-kx022a.c +++ b/drivers/iio/accel/kionix-kx022a.c > Mehdi Djait (1): > iio: accel: kionix-kx022a: Get the timestamp from the driver's private > data in the trigger_handler > > drivers/iio/accel/kionix-kx022a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Hi Matti, On Fri, Feb 17, 2023 at 10:04:30PM +0200, Matti Vaittinen wrote: > Thanks again Mehdi. It's great to have this fixed :) > > On 2/17/23 21:19, Mehdi Djait wrote: > > As discussed in [1] here is a patch to get the timestamp in the > > trigger handler from the driver's private data > > > > [1] https://lore.kernel.org/linux-iio/Y+%2FLpcc0Wa2VGsGO@carbian/T/#mec923c14d1324ffabfa88dde225eeb227005b48f > > > > By the way, I don't think a cover-letter is required for single patches. You > can usually put the relevant information in the commit message. > Additionally, if there is some questions, suggestions or other relevant bits > you wish to say - but don't want to include in commit logs - you can usually > place them in the patch mail directly after the first > "---" > > Eg: > > <commit message> > <Signed-off-by and other tags> > > --- > > Here we can add a note / request if required. > Yes, that's why I sent a cover-letter, I wanted to include relevant bits but not in the commit message (a reference to the discussion). I should have sent the patch --in-reply-to the thread with the discussion anyway. Thank you for the help :) -- Kind Regards Mehdi Djait
On Sat, 18 Feb 2023 14:32:46 +0100 Mehdi Djait <mehdi.djait.k@gmail.com> wrote: > Hi Matti, > > On Fri, Feb 17, 2023 at 10:04:30PM +0200, Matti Vaittinen wrote: > > Thanks again Mehdi. It's great to have this fixed :) > > > > On 2/17/23 21:19, Mehdi Djait wrote: > > > As discussed in [1] here is a patch to get the timestamp in the > > > trigger handler from the driver's private data > > > > > > [1] https://lore.kernel.org/linux-iio/Y+%2FLpcc0Wa2VGsGO@carbian/T/#mec923c14d1324ffabfa88dde225eeb227005b48f > > > > > > > By the way, I don't think a cover-letter is required for single patches. You > > can usually put the relevant information in the commit message. > > Additionally, if there is some questions, suggestions or other relevant bits > > you wish to say - but don't want to include in commit logs - you can usually > > place them in the patch mail directly after the first > > "---" > > > > Eg: > > > > <commit message> > > <Signed-off-by and other tags> > > > > --- > > > > Here we can add a note / request if required. > > > > Yes, that's why I sent a cover-letter, I wanted to include relevant bits > but not in the commit message (a reference to the discussion). > > I should have sent the patch --in-reply-to the thread with the discussion > anyway. Don't do that. Use a Link tag to the discussion instead. Otherwise the patch series can get buried and lost. > > Thank you for the help :) > > -- > Kind Regards > Mehdi Djait
As discussed in [1] here is a patch to get the timestamp in the trigger handler from the driver's private data [1] https://lore.kernel.org/linux-iio/Y+%2FLpcc0Wa2VGsGO@carbian/T/#mec923c14d1324ffabfa88dde225eeb227005b48f Mehdi Djait (1): iio: accel: kionix-kx022a: Get the timestamp from the driver's private data in the trigger_handler drivers/iio/accel/kionix-kx022a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)