From patchwork Mon May 29 06:22:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 13258159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE02C7EE31 for ; Mon, 29 May 2023 06:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231529AbjE2GW1 (ORCPT ); Mon, 29 May 2023 02:22:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231526AbjE2GW0 (ORCPT ); Mon, 29 May 2023 02:22:26 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81CD9B1; Sun, 28 May 2023 23:22:24 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2af24ee004dso28985001fa.0; Sun, 28 May 2023 23:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685341343; x=1687933343; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=vOdzodRAM2H1nmvYMP9+2ZlCwspQLwnxmVWQ2MZpYPM=; b=hxzRRdX8heyI8wsSG3Y9gXKRDUBm+h6aiIzm2U4NbVJcF0PPnKUQd2BPlNJbZfVPc7 rj9jYgzdEmjyhEmKiceZCYihYV2JUGLyKo5N/UwXjDxetguifQkcS1k7MiexOh4cb3Wm rVLzLGHpDbLhEjmwktDrHIljuSpGXt95JWP0djP/clnDnFvsqNWg8eLw9tVeB8WHTYFm uZ6rlZw91nPB5a3SdtsNW/19gS6JCeVgkpzd9vfV9bRk2XX1z4yzfst3M3DznMCPQMYj 21jL4XTQfD/HyQB8TYRGy2QOYOyx5Iln/oXIrqJ/YIRqdreMXEIPA6oxUS+R8Sgvm7bs feag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685341343; x=1687933343; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vOdzodRAM2H1nmvYMP9+2ZlCwspQLwnxmVWQ2MZpYPM=; b=YHFbanjSGF226sn1X/ZhY0M1X0pMuLr4Nq1aYRk9V+I6dcow81Vs2GpQ8Z4OXSbkAz sBqAllKaF3Nn06GBzvNbKOQbI+zaZ0t7ov+yrI8LWjjzGMK7Pw8JVQX/tjmnk4JShdlh 7ZCQKNDyuKt33OO7DSGSh5J4vlOmngC4yyTtXOG8L9f+36l5yjzikvQMZ5/foqDy8FwS btN1Zz5BZguGS6c5ZHq9OMycDfEq8WcmlYRLDnBCDf00eScCpda1xoHPSZBzl7lJg4ru VIt5Ya7Lh59N8igDj+1ho0dvrSZxmLAyYrDdRn7VJJ/nY15hqo5ooX5ov7f4E2GFFLPP 2EoQ== X-Gm-Message-State: AC+VfDx0MgNv2JfLH/NgSA4wCBXhviU0IxwMU6tFlVMlytRvRA6n8W9E 3xbuWNAYLH0+ws8Y+Ye0yGE= X-Google-Smtp-Source: ACHHUZ6z/suHetYnUAr6zG+ImfzBn9sW+n3lS/7H9NuTh8pRvMhTDM6QOBiCNx7BcByzLFd44sKzWA== X-Received: by 2002:a2e:8848:0:b0:2af:22a0:81ec with SMTP id z8-20020a2e8848000000b002af22a081ecmr3663644ljj.27.1685341342325; Sun, 28 May 2023 23:22:22 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id l19-20020a2e99d3000000b002a777ec77dcsm2303433ljj.34.2023.05.28.23.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 23:22:21 -0700 (PDT) Date: Mon, 29 May 2023 09:22:15 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v7 0/9] fix fwnode_irq_get[_byname()] returnvalue Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned zero if mapping the IRQ fails. This contradicts the fwnode_irq_get_byname() documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like: int probe(foo) { ... ret = fwnode_irq_get_byname(...); if (ret < 0) return ret; ... } or int probe(foo) { ... ret = fwnode_irq_get_byname(...); if (ret <= 0) return ret; ... } which are both likely to be wrong. First treats zero as successful call and misses the IRQ mapping failure. Second returns zero from probe even though it detects the IRQ mapping failure correvtly. Here we change the fwnode_irq_get() and the fwnode_irq_get_byname() to always return a negative errno upon failure. I have audited following callers (v6.4-rc2): fwnode_irq_get_byname(): drivers/i2c/i2c-smbus.c drivers/iio/accel/adxl355_core.c drivers/iio/accel/kionix-kx022a.c drivers/iio/adc/ad4130.c drivers/iio/adc/max11410.c drivers/iio/addac/ad74115.c drivers/iio/gyro/fxas21002c_core.c drivers/iio/imu/adis16480.c drivers/iio/imu/bmi160/bmi160_core.c drivers/iio/imu/bmi160/bmi160_core.c fwnode_irq_get(): drivers/gpio/gpio-dwapb.c drivers/iio/chemical/scd30_serial.c drivers/iio/proximity/mb1232.c drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c drivers/net/mdio/fwnode_mdio.c drivers/pinctrl/pinctrl-ingenic.c drivers/pinctrl/pinctrl-microchip-sgpio.c drivers/pinctrl/pinctrl-pistachio.c and it seems to me these calls will be Ok after the change. The i2c-smbus.c and kionix-kx022a.c will gain a functional change (bugfix?) as after this patch the probe will return -EINVAL should the IRQ mapping fail. The series will also adjust the return value check for zero to be omitted. NOTES: Changes are compile-tested only. drivers/pinctrl/nuvoton/pinctrl-wpcm450.c will also gain a functional change. The pinctrl-wpcm450.c change is easy to see - after this series the device-tree mapping failures will be handled as any other errors - probe will be aborted with -EINVAL. Other feasible option could be treating other errors in IRQ getting same way as the DT mapping failures - just silently skip the IRQ. Please see comment in the respective patch. drivers/iio/cdc/ad7150.c Changed logic so that all the IRQ getting errors jump to the same 'no-IRQ' branch as the DT mapping error did. Revision history: v6 => v7: - re-ordered patches per subsystem - mvpp2 - added a patch for not shadowing the return value v5 => v6: - iio: cdc: ad7150 - never abort probe if IRQ getting fails v4 => v5: - Fix subject lines for mvpp2 and wpcm450 - drop unnecessary irqno assignment from mb1232 - add back the drivers/i2c/i2c-smbus.c change which was accidentally dropped during v3 => v4 work v3 => v4: - Change also the fwnode_irq_get() as was suggested by Jonathan. Changelog v2 => v3: - rebase/resend/add kx022a fix. Changelog v1 => v2: - minor styling --- Matti Vaittinen (9): drivers: fwnode: fix fwnode_irq_get[_byname]() iio: mb1232: relax return value check for IRQ get iio: cdc: ad7150: relax return value check for IRQ get pinctrl: wpcm450: relax return value check for IRQ get pinctrl: ingenic: relax return value check for IRQ get pinctrl: pistachio: relax return value check for IRQ get i2c: i2c-smbus: fwnode_irq_get_byname() return value fix net-next: mvpp2: relax return value check for IRQ get net-next: mvpp2: don't shadow error drivers/base/property.c | 12 +++++++++--- drivers/i2c/i2c-smbus.c | 2 +- drivers/iio/cdc/ad7150.c | 10 +++++----- drivers/iio/proximity/mb1232.c | 7 ++----- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 12 ++++++------ drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 -- drivers/pinctrl/pinctrl-ingenic.c | 2 -- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 8 files changed, 23 insertions(+), 30 deletions(-) base-commit: f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6