From patchwork Sun Mar 18 13:36:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Veenstra X-Patchwork-Id: 10291167 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBAFB60385 for ; Sun, 18 Mar 2018 13:36:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB78628E11 for ; Sun, 18 Mar 2018 13:36:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C01832900F; Sun, 18 Mar 2018 13:36:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55C8028E11 for ; Sun, 18 Mar 2018 13:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753966AbeCRNgT (ORCPT ); Sun, 18 Mar 2018 09:36:19 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:51149 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbeCRNgT (ORCPT ); Sun, 18 Mar 2018 09:36:19 -0400 Received: by mail-wm0-f67.google.com with SMTP id w128so10799013wmw.0 for ; Sun, 18 Mar 2018 06:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=C6b6uP4lNLL+0S/0O82uofMwicQJ9CQH6I/hb+RMrIQ=; b=ai/8vSyZpJV2xD9bF/+awzg2y4vBZJYwRorSFVTaLqgKdqx0yV8NWD76clt92vPNK/ qzEemE8gMDU8IdmUz9bO2+6ZVZ1nfLzYuOGyg8q5FA17Hon+b+urKC36BiUQNMfnMoZO k6Mg2+qi7jyQuvsGHUs8BDfp0N2+4FEliyOxpyhGNYB8fdw9fKLPott4xMAWj+lZ9+5r 9Lrsul42HODkAHlMurb/gBi13WHweq0U3DDoGI8CSbTSKI8jyUWuzB8W58qDBU3+4Ji3 sUPZQ/Wz3i4VMF/5Yqjp1rq1cZ+HDoT6NBZFmfidYGeqRis9W6ZjILOSHLrfSiTRGorh Ce6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C6b6uP4lNLL+0S/0O82uofMwicQJ9CQH6I/hb+RMrIQ=; b=pdWHHBCvUVVDLRBnduVc+1u0Y+fvyzPvXLxRjsNnGeF8BlMnzYeeOjcpSIHzlsIuwY 6bOAmvJaw8Ey0eG/CaphL/0YIflryM+f6ncPvaAgCYn0oqBBM9sh7AocuTGpjb4LGlZP fF23ndsTLox4XLH5ONDOxZbgXh2d0vbujLaMQUeOPu5L2t3cA5M3MrUiKaZ+c6lNvF8i Muc+S5ts6TWL4yDZ83erM+0vtAnS9tLjQYuNPq2D2hUGx6DxqUvvuXPUuFofes5dkR1x 5la7CLA5AYMhjjwq9+4yp0dFhg0HoZQlUuDOxL4eQDdBQNoXUvOofEDyUUCwBFLckHVv p6KQ== X-Gm-Message-State: AElRT7F/u+U+VRLpQM3M3YFB4q3Oe5S+qVdLnvSEbQFyjb4zp/14nPWS kLPH8lJuw83YCTem+SHz2ro= X-Google-Smtp-Source: AG47ELss4ugFcNp25fmeJcg7rg5IqCaDPAZIidxh9I3JTcsguOdsoF0cfZ4Xkexp29YfpIw61UKCcA== X-Received: by 10.80.174.163 with SMTP id e32mr5048871edd.285.1521380178270; Sun, 18 Mar 2018 06:36:18 -0700 (PDT) Received: from zenbook-arch (s559434a1.adsl.online.nl. [85.148.52.161]) by smtp.gmail.com with ESMTPSA id c35sm4975517edb.87.2018.03.18.06.36.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 06:36:17 -0700 (PDT) Date: Sun, 18 Mar 2018 14:36:15 +0100 From: David Veenstra To: lars@metafoo.de, jic23@kernel.org Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH 07/11] staging: iio: ad2s1200: Ensure udelay(1) in all necessary code paths Message-ID: <0bf705c8d642bdd9d3a3b7e4653028a88df76ff9.1521379685.git.davidjulianveenstra@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After a successful spi transaction, a udelay(1) is needed. This doesn't happen for the default case of the switch statement in ad2s1200_read_raw. This patch makes sure that it does. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index e0e7c88368ed..6ce9ca13094a 100644 --- a/drivers/staging/iio/resolver/ad2s1200.c +++ b/drivers/staging/iio/resolver/ad2s1200.c @@ -78,20 +78,22 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev, switch (chan->type) { case IIO_ANGL: *val = vel >> 4; + ret = IIO_VAL_INT; break; case IIO_ANGL_VEL: *val = sign_extend32((s16)vel >> 4, 11); + ret = IIO_VAL_INT; break; default: - mutex_unlock(&st->lock); - return -EINVAL; + ret = -EINVAL; + break; } /* delay (2 * AD2S1200_TSCLK + 20) ns for sample pulse */ udelay(1); mutex_unlock(&st->lock); - return IIO_VAL_INT; + return ret; } static const struct iio_chan_spec ad2s1200_channels[] = {