| Message ID | 1286ea127d190e5708a0aaff271819b2d3f8802d.1660934107.git.mazziesaccount@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Use devm helpers for regulator get and enable | expand |
> -----Original Message----- > From: Matti Vaittinen <mazziesaccount@gmail.com> > Sent: Friday, August 19, 2022 9:21 PM > To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen > <matti.vaittinen@fi.rohmeurope.com> > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > <lars@metafoo.de>; Matti Vaittinen <mazziesaccount@gmail.com>; > Alexandru Ardelean <aardelean@deviqon.com>; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH v3 13/14] iio: max1363: simplify using > devm_regulator_get_enable() > > [External] > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > add_action_or_reset(regulator_disable)' and use the > devm_regulator_get_enable() and drop the pointer to the regulator. > This simplifies code and makes it less tempting to add manual control > for the regulator which is also controlled by devm. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > > --- Acked-by: Nuno Sá <nuno.sa@analog.com>
On Tue, 30 Aug 2022 11:50:05 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > -----Original Message----- > > From: Matti Vaittinen <mazziesaccount@gmail.com> > > Sent: Friday, August 19, 2022 9:21 PM > > To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen > > <matti.vaittinen@fi.rohmeurope.com> > > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > > <lars@metafoo.de>; Matti Vaittinen <mazziesaccount@gmail.com>; > > Alexandru Ardelean <aardelean@deviqon.com>; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [PATCH v3 13/14] iio: max1363: simplify using > > devm_regulator_get_enable() > > > > [External] > > > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > > add_action_or_reset(regulator_disable)' and use the > > devm_regulator_get_enable() and drop the pointer to the regulator. > > This simplifies code and makes it less tempting to add manual control > > for the regulator which is also controlled by devm. > > > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > > > > --- > > Acked-by: Nuno Sá <nuno.sa@analog.com> Applied.
On Sun, 16 Oct 2022 17:18:38 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On Tue, 30 Aug 2022 11:50:05 +0000 > "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > > > -----Original Message----- > > > From: Matti Vaittinen <mazziesaccount@gmail.com> > > > Sent: Friday, August 19, 2022 9:21 PM > > > To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen > > > <matti.vaittinen@fi.rohmeurope.com> > > > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen > > > <lars@metafoo.de>; Matti Vaittinen <mazziesaccount@gmail.com>; > > > Alexandru Ardelean <aardelean@deviqon.com>; linux- > > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: [PATCH v3 13/14] iio: max1363: simplify using > > > devm_regulator_get_enable() > > > > > > [External] > > > > > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > > > add_action_or_reset(regulator_disable)' and use the > > > devm_regulator_get_enable() and drop the pointer to the regulator. > > > This simplifies code and makes it less tempting to add manual control > > > for the regulator which is also controlled by devm. > > > > > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > > > > > > --- > > > > Acked-by: Nuno Sá <nuno.sa@analog.com> > > Applied. This one was missing cleaning up the docs as well. fixed up.
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c index eef55ed4814a..d900e29d6cb7 100644 --- a/drivers/iio/adc/max1363.c +++ b/drivers/iio/adc/max1363.c @@ -169,7 +169,6 @@ struct max1363_state { const struct max1363_chip_info *chip_info; const struct max1363_mode *current_mode; u32 requestedmask; - struct regulator *reg; struct mutex lock; /* Using monitor modes and buffer at the same time is @@ -1603,15 +1602,7 @@ static int max1363_probe(struct i2c_client *client, st = iio_priv(indio_dev); mutex_init(&st->lock); - st->reg = devm_regulator_get(&client->dev, "vcc"); - if (IS_ERR(st->reg)) - return PTR_ERR(st->reg); - - ret = regulator_enable(st->reg); - if (ret) - return ret; - - ret = devm_add_action_or_reset(&client->dev, max1363_reg_disable, st->reg); + ret = devm_regulator_get_enable(&client->dev, "vcc"); if (ret) return ret;
Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), add_action_or_reset(regulator_disable)' and use the devm_regulator_get_enable() and drop the pointer to the regulator. This simplifies code and makes it less tempting to add manual control for the regulator which is also controlled by devm. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- v2 => v3: New patch --- drivers/iio/adc/max1363.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)