| Message ID | 1508923665-2274-2-git-send-email-fabrice.gasnier@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 25 Oct 2017 11:27:43 +0200 Fabrice Gasnier <fabrice.gasnier@st.com> wrote: > STM32H7 ADC channels may be configured either as single-ended or > differential. > Add 'st,adc-diff-channels' property to support differential channels. > Differential channels are defined as a pair of positive and negative > inputs: vinp & vinn. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> Works for me, but I will want Rob to have time to look at this. Unfortunately we are very late in the cycle, so I think this one will have to wait for next cycle now. Sorry about that, sometimes timing is against us and I want to get my final pull request for this cycle out today. Jonathan > --- > Changes in v2: > - Add differential channels example > - Add a note on mixed single-ended / differential channels > --- > .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt > index 48bfcaa3..e8bb824 100644 > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt > @@ -62,6 +62,15 @@ Required properties: > - st,adc-channels: List of single-ended channels muxed for this ADC. > It can have up to 16 channels on stm32f4 or 20 channels on stm32h7, numbered > from 0 to 15 or 19 (resp. for in0..in15 or in0..in19). > +- st,adc-diff-channels: List of differential channels muxed for this ADC. > + Depending on part used, some channels can be configured as differential > + instead of single-ended (e.g. stm32h7). List here positive and negative > + inputs pairs as <vinp vinn>, <vinp vinn>,... vinp and vinn are numbered > + from 0 to 19 on stm32h7) > + Note: At least one of "st,adc-channels" or "st,adc-diff-channels" is required. > + Both properties can be used together. Some channels can be used as > + single-ended and some other ones as differential (mixed). But channels > + can't be configured both as single-ended and differential (invalid). > - #io-channel-cells = <1>: See the IIO bindings section "IIO consumers" in > Documentation/devicetree/bindings/iio/iio-bindings.txt > > @@ -111,3 +120,18 @@ Example: > ... > other adc child nodes follow... > }; > + > +Example to setup: > +- channel 1 as single-ended > +- channels 2 & 3 as differential (with resp. 6 & 7 negative inputs) > + > + adc: adc@40022000 { > + compatible = "st,stm32h7-adc-core"; > + ... > + adc1: adc@0 { > + compatible = "st,stm32h7-adc"; > + ... > + st,adc-channels = <1>; > + st,adc-diff-channels = <2 6>, <3 7>; > + }; > + }; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 25, 2017 at 11:27:43AM +0200, Fabrice Gasnier wrote: > STM32H7 ADC channels may be configured either as single-ended or > differential. > Add 'st,adc-diff-channels' property to support differential channels. > Differential channels are defined as a pair of positive and negative > inputs: vinp & vinn. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > Changes in v2: > - Add differential channels example > - Add a note on mixed single-ended / differential channels > --- > .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 27 Oct 2017 09:37:29 -0500 Rob Herring <robh@kernel.org> wrote: > On Wed, Oct 25, 2017 at 11:27:43AM +0200, Fabrice Gasnier wrote: > > STM32H7 ADC channels may be configured either as single-ended or > > differential. > > Add 'st,adc-diff-channels' property to support differential channels. > > Differential channels are defined as a pair of positive and negative > > inputs: vinp & vinn. > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > > --- > > Changes in v2: > > - Add differential channels example > > - Add a note on mixed single-ended / differential channels > > --- > > .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> > Thanks. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt index 48bfcaa3..e8bb824 100644 --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt @@ -62,6 +62,15 @@ Required properties: - st,adc-channels: List of single-ended channels muxed for this ADC. It can have up to 16 channels on stm32f4 or 20 channels on stm32h7, numbered from 0 to 15 or 19 (resp. for in0..in15 or in0..in19). +- st,adc-diff-channels: List of differential channels muxed for this ADC. + Depending on part used, some channels can be configured as differential + instead of single-ended (e.g. stm32h7). List here positive and negative + inputs pairs as <vinp vinn>, <vinp vinn>,... vinp and vinn are numbered + from 0 to 19 on stm32h7) + Note: At least one of "st,adc-channels" or "st,adc-diff-channels" is required. + Both properties can be used together. Some channels can be used as + single-ended and some other ones as differential (mixed). But channels + can't be configured both as single-ended and differential (invalid). - #io-channel-cells = <1>: See the IIO bindings section "IIO consumers" in Documentation/devicetree/bindings/iio/iio-bindings.txt @@ -111,3 +120,18 @@ Example: ... other adc child nodes follow... }; + +Example to setup: +- channel 1 as single-ended +- channels 2 & 3 as differential (with resp. 6 & 7 negative inputs) + + adc: adc@40022000 { + compatible = "st,stm32h7-adc-core"; + ... + adc1: adc@0 { + compatible = "st,stm32h7-adc"; + ... + st,adc-channels = <1>; + st,adc-diff-channels = <2 6>, <3 7>; + }; + };
STM32H7 ADC channels may be configured either as single-ended or differential. Add 'st,adc-diff-channels' property to support differential channels. Differential channels are defined as a pair of positive and negative inputs: vinp & vinn. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- Changes in v2: - Add differential channels example - Add a note on mixed single-ended / differential channels --- .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+)