From patchwork Fri Mar 16 20:06:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Himanshu Jha X-Patchwork-Id: 10290069 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23B17602C2 for ; Fri, 16 Mar 2018 20:09:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 132C028E0F for ; Fri, 16 Mar 2018 20:09:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05EDD28F90; Fri, 16 Mar 2018 20:09:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A30B228E0F for ; Fri, 16 Mar 2018 20:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbeCPUJK (ORCPT ); Fri, 16 Mar 2018 16:09:10 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36456 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbeCPUHA (ORCPT ); Fri, 16 Mar 2018 16:07:00 -0400 Received: by mail-pf0-f193.google.com with SMTP id 68so4575143pfx.3; Fri, 16 Mar 2018 13:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H5fB7kzBM00pK3mQhW7eIFmwqmSGcFOItyCpjM5wN84=; b=Iv04PV7ytBgfGKoDbeiKXa00q6r2LnVdB+v/YVEDCuTPrR3MYM9p+xq7Ah/7IfTinR gTQAd7GLirVIpouSnt1zyh2u5zXq6hstzlLSRHwhVGEVE22j4+UhZcVipCmZcw5BUPxb a0GRPa1tZGrFgjU/xgeDQwgT0T8ZYWZ3uWaLO8HWT8OZ/OB6HWa8EZFOQq4IiG8sBl/i KGvG4Eed6u6z3i0KxABqwBsMoXHepIgI7uL+g1hyKs9gF69uzzONt8BqvJrXYWWMgUL0 o1gHJKsKTS/UtpLGgvQZMBPj9a8MDvSI45jSblh1angwcotnin0JbAsc8lbEb/O/QcP3 ZmKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H5fB7kzBM00pK3mQhW7eIFmwqmSGcFOItyCpjM5wN84=; b=ZAwdX107+aUFwQTebZ+mC86mD3MCVlDStn4iU1IU3qssRyeAJdwXxn5A1RqNO6lZSR eZGPi8akCCh5ni7+YVS1/FHwiohoUBrp/zGZwgmYUE9MnmPNUc36vz60OpOtRhOQFnH3 5sTnxPEUhme8N8h3lNee5R5n96bo3zc6YrO0O08f6bpJH22WdU1jDVa/Wf2rwBVOBCo2 NbZovrXe3GDGuGuJMw07frN+ji56nz6gNN2m0zZPg5c0K4xNyFTUwbAfGCcOu5EAORoH gXNvv/Xk44YfVtv1Wwi7aRvWEpXq1hWwqBjqy8euFcbkSCYNj+2PglpOALV4opLbfYWi ZUzg== X-Gm-Message-State: AElRT7EKh1g/QDyws73dXxjTAhrhKOrjDVZTmJAkNt4OKOu6aLjvUuYj WJSmaXgqkgHJcm3ZqKWq1Ns= X-Google-Smtp-Source: AG47ELtUt9RKQPJLZdaLUWroZNeaC/khPXC/zTNyEsFuw7/JWt24rfmL7HOMmnugud4OBxW6yjxDDQ== X-Received: by 10.98.229.21 with SMTP id n21mr2625062pff.158.1521230819899; Fri, 16 Mar 2018 13:06:59 -0700 (PDT) Received: from localhost.localdomain ([103.46.193.14]) by smtp.gmail.com with ESMTPSA id s9sm15605347pfm.39.2018.03.16.13.06.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Mar 2018 13:06:59 -0700 (PDT) From: Himanshu Jha To: jic23@kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, daniel.baluta@gmail.com, 21cnbao@gmail.com, Himanshu Jha Subject: [PATCH v2 2/9] Staging: iio: accel: adis16201: Remove unnecessary comments Date: Sat, 17 Mar 2018 01:36:19 +0530 Message-Id: <1521230786-18155-3-git-send-email-himanshujha199640@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521230786-18155-1-git-send-email-himanshujha199640@gmail.com> References: <1521230786-18155-1-git-send-email-himanshujha199640@gmail.com> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove few unnecessary comments since the macro definitions clearly justify their purpose. Signed-off-by: Himanshu Jha --- v2: -reodered patch series. drivers/staging/iio/accel/adis16201.c | 36 ----------------------------------- 1 file changed, 36 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c index 767ebf0..6c06c0d 100644 --- a/drivers/staging/iio/accel/adis16201.c +++ b/drivers/staging/iio/accel/adis16201.c @@ -22,96 +22,66 @@ #define ADIS16201_STARTUP_DELAY_MS 220 -/* Flash memory write count */ #define ADIS16201_FLASH_CNT 0x00 -/* Output, power supply */ #define ADIS16201_SUPPLY_OUT 0x02 -/* Output, x-axis accelerometer */ #define ADIS16201_XACCL_OUT 0x04 -/* Output, y-axis accelerometer */ #define ADIS16201_YACCL_OUT 0x06 -/* Output, auxiliary ADC input */ #define ADIS16201_AUX_ADC 0x08 -/* Output, temperature */ #define ADIS16201_TEMP_OUT 0x0A -/* Output, x-axis inclination */ #define ADIS16201_XINCL_OUT 0x0C -/* Output, y-axis inclination */ #define ADIS16201_YINCL_OUT 0x0E -/* Calibration, x-axis acceleration offset */ #define ADIS16201_XACCL_OFFS 0x10 -/* Calibration, y-axis acceleration offset */ #define ADIS16201_YACCL_OFFS 0x12 -/* x-axis acceleration scale factor */ #define ADIS16201_XACCL_SCALE 0x14 -/* y-axis acceleration scale factor */ #define ADIS16201_YACCL_SCALE 0x16 -/* Calibration, x-axis inclination offset */ #define ADIS16201_XINCL_OFFS 0x18 -/* Calibration, y-axis inclination offset */ #define ADIS16201_YINCL_OFFS 0x1A -/* x-axis inclination scale factor */ #define ADIS16201_XINCL_SCALE 0x1C -/* y-axis inclination scale factor */ #define ADIS16201_YINCL_SCALE 0x1E -/* Alarm 1 amplitude threshold */ #define ADIS16201_ALM_MAG1 0x20 -/* Alarm 2 amplitude threshold */ #define ADIS16201_ALM_MAG2 0x22 -/* Alarm 1, sample period */ #define ADIS16201_ALM_SMPL1 0x24 -/* Alarm 2, sample period */ #define ADIS16201_ALM_SMPL2 0x26 -/* Alarm control */ #define ADIS16201_ALM_CTRL 0x28 -/* Auxiliary DAC data */ #define ADIS16201_AUX_DAC 0x30 -/* General-purpose digital input/output control */ #define ADIS16201_GPIO_CTRL 0x32 -/* Miscellaneous control */ #define ADIS16201_MSC_CTRL 0x34 -/* Internal sample period (rate) control */ #define ADIS16201_SMPL_PRD 0x36 /* Operation, filter configuration */ #define ADIS16201_AVG_CNT 0x38 -/* Operation, sleep mode control */ #define ADIS16201_SLP_CNT 0x3A -/* Diagnostics, system status register */ #define ADIS16201_DIAG_STAT 0x3C -/* Operation, system command register */ #define ADIS16201_GLOB_CMD 0x3E -/* MSC_CTRL */ -/* Self-test enable */ #define ADIS16201_MSC_CTRL_SELF_TEST_EN BIT(8) /* Data-ready enable: 1 = enabled, 0 = disabled */ @@ -123,18 +93,13 @@ /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */ #define ADIS16201_MSC_CTRL_DATA_RDY_DIO1 BIT(0) -/* DIAG_STAT */ -/* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */ #define ADIS16201_DIAG_STAT_ALARM2 BIT(9) -/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */ #define ADIS16201_DIAG_STAT_ALARM1 BIT(8) -/* SPI communications failure */ #define ADIS16201_DIAG_STAT_SPI_FAIL_BIT 3 -/* Flash update failure */ #define ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT 2 /* Power supply above 3.625 V */ @@ -143,7 +108,6 @@ /* Power supply below 3.15 V */ #define ADIS16201_DIAG_STAT_POWER_LOW_BIT 0 -/* GLOB_CMD */ #define ADIS16201_GLOB_CMD_SW_RESET BIT(7) #define ADIS16201_GLOB_CMD_FACTORY_RESET BIT(1)