From patchwork Wed Mar 21 14:28:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Hern=C3=A1n_Gonzalez?= X-Patchwork-Id: 10299555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B692A60385 for ; Wed, 21 Mar 2018 14:31:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A726D2987C for ; Wed, 21 Mar 2018 14:31:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A50E7298A0; Wed, 21 Mar 2018 14:31:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 224C32987C for ; Wed, 21 Mar 2018 14:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188AbeCUOby (ORCPT ); Wed, 21 Mar 2018 10:31:54 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:43923 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbeCUOaV (ORCPT ); Wed, 21 Mar 2018 10:30:21 -0400 Received: by mail-qt0-f193.google.com with SMTP id s48so5428861qtb.10 for ; Wed, 21 Mar 2018 07:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=QQ/aJSRs+3fVlHd8LYk9UThTcwN6pX8NGQ7ygZTNS+Y=; b=EbASJ83DgWQcfDwhkNbg2Ml1yWmaMrkBfBpHHL7btavZBK9gdZppZN6kutk4YiQZHY lQgl7l7gHi1C+UwF0/wTX7GYv9W4PHJ0iexWwcAYveo+vqP3BnzXyNpAPtDz24iGzJJ3 As9Ohjfb520vUohNNhUlscQAMn4FHKqv6L08LFDTq0aHVsr9k7ZGQ1olkYpHbLEcHPBw LkGcIzn1ExEY742kwM5D+m2O70M/9eh+lhiLzzNO9WmrkdK1keupAh9n6YYIy3Z1j/9b cACYycVT1q05ZlsKZiAKuMucmvWLNOrghT/07GKJJYfafiueK5v5LHX0AfJU3vg0bPlL 5zCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QQ/aJSRs+3fVlHd8LYk9UThTcwN6pX8NGQ7ygZTNS+Y=; b=WW2NUvnkYcydr2DSc0J60Ji+y+R65p+YSJtqmzhvGGU2G5Tua0pzDDrEaPG7jOldLB e3WC3L9G+XVePK43tezNz/LVVm8ZZ3bDnpHo+JIPemKzi6W9/YK3gSvVNVMxETpKWsTD l0aA1HU9xCrQ9SusK3RWqQvAyLSImvS6XI8Irs6WtTYtJssvmxvGUXy43toXkWh1pVYn RPDG8B8n2ElKwrwdlklrSdoMyxyJx0Z0tUKA0T/xAWB5cwaeYFKjWvTAXyK1RW+JTLhQ DVV6dfJSiD1fKPP7TXRLdgIHQylNPvCw3vbfSWDGOGWHQT3eF3HE6o8Gn96KjisstfW3 C6tg== X-Gm-Message-State: AElRT7EZQHIe2RXXT2bC/WMUrJskOH3mFqdU8bmxnNsDMPncl+NXYFTz zXPMCZqJQgT+3uBczwtxAtwSNg== X-Google-Smtp-Source: AG47ELuVnwDRgvb1D5FB/0X2eK5tmHb1aSJhuHconm4sgvBH10KiLASg3n7WWrRnPjokwjqtHBkHag== X-Received: by 10.200.25.252 with SMTP id s57mr29022683qtk.32.1521642620468; Wed, 21 Mar 2018 07:30:20 -0700 (PDT) Received: from localhost.localdomain ([190.210.56.45]) by smtp.gmail.com with ESMTPSA id g14sm3118592qtk.71.2018.03.21.07.30.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Mar 2018 07:30:19 -0700 (PDT) From: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, hernan@vanguardiasur.com.ar Subject: [PATCH 06/11] staging: iio: ad7746: Add dt-bindings Date: Wed, 21 Mar 2018 11:28:54 -0300 Message-Id: <1521642539-4845-7-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521642539-4845-1-git-send-email-hernan@vanguardiasur.com.ar> References: <1521642539-4845-1-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds dt bindings by populating a pdata struct in order to modify as little as possible the existing code. It supports both platform_data and dt-bindings but uses only one depending on CONFIG_OF's value. Signed-off-by: Hernán Gonzalez --- drivers/staging/iio/cdc/ad7746.c | 55 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index cba8cd1..815573c 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -658,6 +658,44 @@ static const struct iio_info ad7746_info = { /* * device probe and remove */ +#ifdef CONFIG_OF +static struct ad7746_platform_data *ad7746_parse_dt(struct device *dev) +{ + struct device_node *np = dev->of_node; + struct ad7746_platform_data *pdata; + unsigned int tmp; + int ret; + + /* The default excitation outputs are not inverted, it should be stated + * in the dt if needed. + */ + + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return NULL; + + tmp = 0; + ret = of_property_read_u32(np, "adi,exclvl", &tmp); + if (ret || tmp > 3) { + dev_warn(dev, "Wrong exclvl value, using default\n"); + pdata->exclvl = 3; /* default value */ + } else { + pdata->exclvl = tmp; + } + + pdata->exca_inv_en = of_property_read_bool(np, "adi,nexca_en"); + pdata->excb_inv_en = of_property_read_bool(np, "adi,nexcb_en"); + pdata->exca_en = !pdata->exca_inv_en; + pdata->excb_en = !pdata->excb_inv_en; + + return pdata; +} +#else +static struct ad7746_platform_data *ad7746_parse_dt(struct device *dev) +{ + return NULL; +} +#endif static int ad7746_probe(struct i2c_client *client, const struct i2c_device_id *id) @@ -668,6 +706,11 @@ static int ad7746_probe(struct i2c_client *client, unsigned char regval = 0; int ret = 0; + if (client->dev.of_node) + pdata = ad7746_parse_dt(&client->dev); + else + pdata = client->dev.platform_data; + indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip)); if (!indio_dev) return -ENOMEM; @@ -731,12 +774,22 @@ static const struct i2c_device_id ad7746_id[] = { { "ad7747", 7747 }, {} }; - MODULE_DEVICE_TABLE(i2c, ad7746_id); +#ifdef CONFIG_OF +static const struct of_device_id ad7746_of_match[] = { + { .compatible = "adi,ad7745" }, + { .compatible = "adi,ad7746" }, + { .compatible = "adi,ad7747" }, + { } +}; +MODULE_DEVICE_TABLE(of, ad7746_of_match); +#endif + static struct i2c_driver ad7746_driver = { .driver = { .name = KBUILD_MODNAME, + .of_match_table = of_match_ptr(ad7746_of_match), }, .probe = ad7746_probe, .id_table = ad7746_id,