From patchwork Fri Apr 13 16:36:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Hern=C3=A1n_Gonzalez?= X-Patchwork-Id: 10340485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C98EE60153 for ; Fri, 13 Apr 2018 16:40:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD78528950 for ; Fri, 13 Apr 2018 16:40:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B06632896D; Fri, 13 Apr 2018 16:40:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2675628950 for ; Fri, 13 Apr 2018 16:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbeDMQhr (ORCPT ); Fri, 13 Apr 2018 12:37:47 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:42389 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbeDMQhp (ORCPT ); Fri, 13 Apr 2018 12:37:45 -0400 Received: by mail-qt0-f196.google.com with SMTP id j3so8640017qtn.9 for ; Fri, 13 Apr 2018 09:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AQ+TIPQWmENrQncV6f3ZGjV/67cQJ+PcqdWnTWyhAFM=; b=XbgltohdxD0CaR+AtF/a2xKAloRrt1CEjnZHdF6M3RH/m+2+8AQuFiBmpq1MsH96Q/ BO9eZq4tZ0ZDn4MTjZ0CHYWBW2eq5YhtFqkhlBKC7pslpvEQ9/uHJjbagRO7wk8wwiWM J6is/Le6c7filuOovKs8kZjLUQF11D7edxA+oyBzG9PowcmVjq3kGPGZwgqzYufydhMf aR5y5oUSCSpsJHAmKW2gpoN7bFw6lYe2DdPWp767El8yuMlYWNF5l+kNEvWvtC5SQB8v 8ikBwkkVGRnTve1NDA93VnWFlfRDl4+0UmjFwWZ6WfedS6L9FmZnYN7CLIrZZlgsPETX GrCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AQ+TIPQWmENrQncV6f3ZGjV/67cQJ+PcqdWnTWyhAFM=; b=lUnfG2TLyhl0Fm+rMTXs03prErLRjKCXmZSLBJyt3rhrQ2mmA9mkz/MaYGvzMfHBQj Any5BIrsTDF3PQ/9J+MTgG4hb2oLQdvNIZqRxsKJubOHVHVS17ZbgaZy34MxUzcI/+iZ 0mlE3GK/t2RksI5jnPVy9Kq8kkG9G0hT1GMyh59GeR03HzP0LnIhaQ+EhbWFZa0ZmKk9 fJJbGNAyflPzPVnyEOtaKtW/Zz+9tNkPjveTl7MEz5pCUcEk7ck2Jk8p08Qcldi/gYFW lLrqSGybfCWH0KR6RIPwIguJDaVMF+ADcolr2YqKRyDbby5p3bdSQQON4p1z1t0hjJze 9ASA== X-Gm-Message-State: ALQs6tC9ogv5xvsMmC8nJa46R6UQcYb7H71dwcbgOPhTYkR/GRal7HOY T9UhgqqdrmsU2psGV537I4U/Iw== X-Google-Smtp-Source: AIpwx48W6HGKxbDU/0ZgP1Nt8slwWI/8unAQZzVZcgleOcT0GjGmePdfF7PcM8uswdyJbLZWd0t69A== X-Received: by 10.200.37.85 with SMTP id 21mr3926344qtn.270.1523637465233; Fri, 13 Apr 2018 09:37:45 -0700 (PDT) Received: from localhost.localdomain ([190.210.56.45]) by smtp.gmail.com with ESMTPSA id t82sm5024687qke.52.2018.04.13.09.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Apr 2018 09:37:44 -0700 (PDT) From: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= Subject: [PATCH v2 01/14] staging: iio: ad7746: Automatically swap values in readings/writings Date: Fri, 13 Apr 2018 13:36:38 -0300 Message-Id: <1523637411-8531-2-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> References: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Data to read or write was being handled with the swab16() macro instead of using i2c_smbus_{read,write}_swapped. Signed-off-by: Hernán Gonzalez --- drivers/staging/iio/cdc/ad7746.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 4882dbc..53e28ae 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -451,7 +451,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, goto out; } - ret = i2c_smbus_write_word_data(chip->client, reg, swab16(val)); + ret = i2c_smbus_write_word_swapped(chip->client, reg, val); if (ret < 0) goto out; @@ -462,8 +462,8 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, ret = -EINVAL; goto out; } - ret = i2c_smbus_write_word_data(chip->client, - AD7746_REG_CAP_OFFH, swab16(val)); + ret = i2c_smbus_write_word_swapped(chip->client, + AD7746_REG_CAP_OFFH, val); if (ret < 0) goto out; @@ -594,21 +594,21 @@ static int ad7746_read_raw(struct iio_dev *indio_dev, goto out; } - ret = i2c_smbus_read_word_data(chip->client, reg); + ret = i2c_smbus_read_word_swapped(chip->client, reg); if (ret < 0) goto out; /* 1 + gain_val / 2^16 */ *val = 1; - *val2 = (15625 * swab16(ret)) / 1024; + *val2 = (15625 * ret) / 1024; ret = IIO_VAL_INT_PLUS_MICRO; break; case IIO_CHAN_INFO_CALIBBIAS: - ret = i2c_smbus_read_word_data(chip->client, - AD7746_REG_CAP_OFFH); + ret = i2c_smbus_read_word_swapped(chip->client, + AD7746_REG_CAP_OFFH); if (ret < 0) goto out; - *val = swab16(ret); + *val = ret; ret = IIO_VAL_INT; break;