From patchwork Fri Apr 13 16:36:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Hern=C3=A1n_Gonzalez?= X-Patchwork-Id: 10340437 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 98F9860153 for ; Fri, 13 Apr 2018 16:38:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D625285FF for ; Fri, 13 Apr 2018 16:38:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 81CF128643; Fri, 13 Apr 2018 16:38:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 332C2285FF for ; Fri, 13 Apr 2018 16:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbeDMQiB (ORCPT ); Fri, 13 Apr 2018 12:38:01 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:38968 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbeDMQh5 (ORCPT ); Fri, 13 Apr 2018 12:37:57 -0400 Received: by mail-qk0-f196.google.com with SMTP id j73so9722158qke.6 for ; Fri, 13 Apr 2018 09:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AUYcWjSzrPAo1AAFd0fCJjYN3y2sBNkuo6UzBvviTWY=; b=eJn5J1b5ebCmEQO79s6k0j67Uhq4Bj5WeMByaHWtazssI/8g4UesxtSJC1Wa0cKQBL BFZ/HKILTyoVe28JBySYDUDwBk7yQg5vWVJ3sza0zaObCiO2SgGnX5Vr2cA1sEX7xZdC x35GJ3HnbRf7MfqcrKgauXGhxkWeMafl35P0k+Z7dcOKBso9PgBvsSgVYPrnmJc+VQFp CZDZfblnJJlIVJvMeNO0AEoP/J2dEPW9gL+r2uyDBA3a3IRofox6CErJMIZhLzFCZzXC JLVSojJnlB0khqWgFFOWy0aZoqvLbej1SH7xtDerQtbQ2xxa/+iqp88qEx8J8fP1I7MU odLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AUYcWjSzrPAo1AAFd0fCJjYN3y2sBNkuo6UzBvviTWY=; b=HTh/Fp/hCYOWcQnFvduI+1SW8JTOGh9zLgFBOwwd8EAPIdz41ryiKKxEaLSESFadik ZMR6dzvaC4eqSWz5NlohxNHG0wxknclOSmtzOOxdXgUR5u3zG0xbjzPyMTyTV5C5Jt+1 b8Ij81Jmmw5ebB7tMRa33TicLfcw4YxDyGDX7JKAEGMUS3v3FdP8acZh+XRGBGCaWG9b 1Z9kvKUiyOLJ8V9jb9G71sBmyRZ3qNaKvc0vK9TXK8bIuSW87EvPh0dSxZmker1Knvhj W3qVOf/VW+YkVo2ZQtIQSsIXwlb3TweD9JAn054uaoMSkvhOWwuCI3Ugp/bXf7L7YM7i e7fA== X-Gm-Message-State: ALQs6tA9FtYqWTCor27Sy+XS9xIaVxFfAURmPlbFzN9T5iUlJu1+azPn 58mvvNqOa+0H8DFZS9B4zdzeLQ== X-Google-Smtp-Source: AIpwx48o9zPklx5b4iASPHdOSQaHLWNovWPmheQHXbnC0Y3I/LQnFJCMISBylXQhBCRNVnZVpnMZTQ== X-Received: by 10.55.23.94 with SMTP id i91mr694510qkh.308.1523637476951; Fri, 13 Apr 2018 09:37:56 -0700 (PDT) Received: from localhost.localdomain ([190.210.56.45]) by smtp.gmail.com with ESMTPSA id t82sm5024687qke.52.2018.04.13.09.37.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Apr 2018 09:37:56 -0700 (PDT) From: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= Subject: [PATCH v2 03/14] staging: iio: ad7746: Fix bound checkings Date: Fri, 13 Apr 2018 13:36:40 -0300 Message-Id: <1523637411-8531-4-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> References: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Also remove unnecessary parenthesis Signed-off-by: Hernán Gonzalez --- drivers/staging/iio/cdc/ad7746.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index 516aa93..d793785 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -458,7 +458,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, ret = 0; break; case IIO_CHAN_INFO_CALIBBIAS: - if ((val < 0) | (val > 0xFFFF)) { + if (val < 0 || val > 0xFFFF) { ret = -EINVAL; goto out; } @@ -470,7 +470,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, ret = 0; break; case IIO_CHAN_INFO_OFFSET: - if ((val < 0) | (val > 43008000)) { /* 21pF */ + if (val < 0 || val > 43008000) { /* 21pF */ ret = -EINVAL; goto out; }