| Message ID | 1523637411-8531-5-git-send-email-hernan@vanguardiasur.com.ar (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 13 Apr 2018 13:36:41 -0300 Hernán Gonzalez <hernan@vanguardiasur.com.ar> wrote: > Clear checkpatch.pl WARNING about multiple line derefence but creates a > new one of line over 80 characters. In my opinion, it improves > readability. > > Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar> I wouldn't say I personally have strong views either way on this, but your version is fine so I'll apply it. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7746.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index d793785..82fac76 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -410,8 +410,7 @@ static struct attribute *ad7746_attributes[] = { > &iio_dev_attr_in_capacitance1_calibbias_calibration.dev_attr.attr, > &iio_dev_attr_in_voltage0_calibscale_calibration.dev_attr.attr, > &iio_const_attr_in_voltage_sampling_frequency_available.dev_attr.attr, > - &iio_const_attr_in_capacitance_sampling_frequency_available. > - dev_attr.attr, > + &iio_const_attr_in_capacitance_sampling_frequency_available.dev_attr.attr, > NULL, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index d793785..82fac76 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -410,8 +410,7 @@ static struct attribute *ad7746_attributes[] = { &iio_dev_attr_in_capacitance1_calibbias_calibration.dev_attr.attr, &iio_dev_attr_in_voltage0_calibscale_calibration.dev_attr.attr, &iio_const_attr_in_voltage_sampling_frequency_available.dev_attr.attr, - &iio_const_attr_in_capacitance_sampling_frequency_available. - dev_attr.attr, + &iio_const_attr_in_capacitance_sampling_frequency_available.dev_attr.attr, NULL, };
Clear checkpatch.pl WARNING about multiple line derefence but creates a new one of line over 80 characters. In my opinion, it improves readability. Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar> --- drivers/staging/iio/cdc/ad7746.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)