From patchwork Fri Apr 13 16:36:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Hern=C3=A1n_Gonzalez?= X-Patchwork-Id: 10340449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 02342604D4 for ; Fri, 13 Apr 2018 16:38:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB00928926 for ; Fri, 13 Apr 2018 16:38:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D9E7E28922; Fri, 13 Apr 2018 16:38:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62C5928922 for ; Fri, 13 Apr 2018 16:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796AbeDMQie (ORCPT ); Fri, 13 Apr 2018 12:38:34 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:32986 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbeDMQib (ORCPT ); Fri, 13 Apr 2018 12:38:31 -0400 Received: by mail-qt0-f193.google.com with SMTP id p9so6334760qtn.0 for ; Fri, 13 Apr 2018 09:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gCLllH3REqUzI1sPIV3bnZhs1KmvZS77Al6RA0oTClI=; b=ODyU1ZFqHys5wMF6bQCVqa5bNNxo8v8X9QFdRWPoqCN5WUpgHdEQ+lZLJarvQ5fYUs LU1Ma/Upj8ItArmjAc11jS9p46j6Db7KWi00qsF5KrSKoZT5cKw1DwVmW87XWcJgLbfy YvffH4rKepW+MIAGzztI4kB0Xd4M6SdT8iqCNIpWAhx6yl0eYfLk5W3mswg1Iw5nS30Z UXUhZ2e9sbEoQVfSUHQeCgaxgECK2bg+gw6TJtrXdhT0/D7hmPI26cyRMRSceZkXRJh7 9hx16uyWiTK3pLXIV7RvTGi2W1uBTPWHC5YEW+QzlP+SsPInfXJdI4hwGjGHqlli8BHA mGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gCLllH3REqUzI1sPIV3bnZhs1KmvZS77Al6RA0oTClI=; b=H03sOFGLLZhX0DukXO+iV/6kyfM905gVcByWShq7rp9gzrJl9SHT0W23qmtl54jPJr egmhEGt+aFVcRDqrdqIQ0NCR8RPPa3OhVnu0MLkeKWAuaxiRUHfZyJeMr1xZXk7GCYOm rtsNxBHe+9yMHvBRsf1YJ14Li5tt5lnsZDZ3O4ZzCPHPxabD8qabrM7GdM+DfWDcm1cE rPfxxeL9q6thCYuveqtxo/kAnKgF8zNnKOsg1Fhl18EVUVnCdrIk+fIa2Odno9ApIJeE BKQ1yj9XI3i0xdU/V1pJc5MqPKfAt1iQEPHdfoMwN8MC6DwSO62V09uvwLi7lsqXPNia bS/A== X-Gm-Message-State: ALQs6tAvvfQHJALZ19W+JIKSbLDtsZij0X83eJ3RvEt2zAnuJcOMnlrr 3fBN+uMWvk2Z7HHGUfiVRwXiUQ== X-Google-Smtp-Source: AIpwx49pen0DvftBlHHRwoOaMn8sdnK13EqI2fiSDgDiOq8Ma1wMsnOu7yzNNByKxFp7azHQmj03+w== X-Received: by 10.200.39.39 with SMTP id g36mr3668023qtg.227.1523637510750; Fri, 13 Apr 2018 09:38:30 -0700 (PDT) Received: from localhost.localdomain ([190.210.56.45]) by smtp.gmail.com with ESMTPSA id t82sm5024687qke.52.2018.04.13.09.38.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Apr 2018 09:38:30 -0700 (PDT) From: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Hern=C3=A1n=20Gonzalez?= Subject: [PATCH v2 08/14] staging: iio: ad7746: Add dt-bindings Date: Fri, 13 Apr 2018 13:36:45 -0300 Message-Id: <1523637411-8531-9-git-send-email-hernan@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> References: <1523637411-8531-1-git-send-email-hernan@vanguardiasur.com.ar> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds dt bindings by populating a pdata struct in order to modify as little as possible the existing code. It supports both platform_data and dt-bindings but uses only one depending on CONFIG_OF's value. Signed-off-by: Hernán Gonzalez --- drivers/staging/iio/cdc/ad7746.c | 54 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index d39ab34..c29a221 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -666,6 +666,43 @@ static const struct iio_info ad7746_info = { /* * device probe and remove */ +#ifdef CONFIG_OF +static struct ad7746_platform_data *ad7746_parse_dt(struct device *dev) +{ + struct device_node *np = dev->of_node; + struct ad7746_platform_data *pdata; + unsigned int tmp; + int ret; + + /* The default excitation outputs are not inverted, it should be stated + * in the dt if needed. + */ + + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return NULL; + + ret = of_property_read_u32(np, "adi,exclvl", &tmp); + if (ret || tmp > 3) { + dev_warn(dev, "Wrong exclvl value, using default\n"); + pdata->exclvl = 3; /* default value */ + } else { + pdata->exclvl = tmp; + } + + pdata->exca_en = true; + pdata->excb_en = true; + pdata->exca_inv_en = of_property_read_bool(np, "adi,nexca_en"); + pdata->excb_inv_en = of_property_read_bool(np, "adi,nexcb_en"); + + return pdata; +} +#else +static struct ad7746_platform_data *ad7746_parse_dt(struct device *dev) +{ + return NULL; +} +#endif static int ad7746_probe(struct i2c_client *client, const struct i2c_device_id *id) @@ -676,6 +713,11 @@ static int ad7746_probe(struct i2c_client *client, unsigned char regval = 0; int ret = 0; + if (client->dev.of_node) + pdata = ad7746_parse_dt(&client->dev); + else + pdata = client->dev.platform_data; + indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip)); if (!indio_dev) return -ENOMEM; @@ -739,12 +781,22 @@ static const struct i2c_device_id ad7746_id[] = { { "ad7747", 7747 }, {} }; - MODULE_DEVICE_TABLE(i2c, ad7746_id); +#ifdef CONFIG_OF +static const struct of_device_id ad7746_of_match[] = { + { .compatible = "adi,ad7745" }, + { .compatible = "adi,ad7746" }, + { .compatible = "adi,ad7747" }, + { } +}; +MODULE_DEVICE_TABLE(of, ad7746_of_match); +#endif + static struct i2c_driver ad7746_driver = { .driver = { .name = KBUILD_MODNAME, + .of_match_table = of_match_ptr(ad7746_of_match), }, .probe = ad7746_probe, .id_table = ad7746_id,